22b197580b
Wrap create errors and cover the non-duplicate insert failure
...
Review follow-up: the Create fall-through returned the raw insert error
while Get and Delete wrap theirs, so wrap it the same way for consistent
diagnostics across the driver.
The 'insert failed and the release does not already exist' branch became
reachable with the rollback fix but had no coverage; add a test asserting
the original error is surfaced and that it is not ErrReleaseExists.
Signed-off-by: Mukul <nmukul32@gmail.com>
1 month ago
e02a54f3cc
Fix SQL driver error mapping for reads and duplicate creates
...
Two related error-contract problems in the SQL storage driver:
Get and Delete mapped *any* error from the release lookup to
ErrReleaseNotFound. A connection failure, a permission error or a
timeout was therefore indistinguishable from a release that genuinely
does not exist, and callers branch on that sentinel - a transient
database outage could be read as 'release absent'. Only sql.ErrNoRows
now maps to ErrReleaseNotFound; every other error is wrapped and
returned. Delete additionally left its transaction open on that path,
so it is now rolled back.
Create could never return ErrReleaseExists. After the insert fails the
transaction is in an aborted state, and PostgreSQL rejects every
subsequent statement on it, so the follow-up SELECT that decides
between 'already exists' and a genuine error always failed and the raw
driver error was surfaced instead. This diverges from the Secrets and
ConfigMaps drivers, which return ErrReleaseExists. The transaction is
now rolled back first and the existence check runs outside it.
Refs #32394 (items 2 and 3).
Signed-off-by: Mukul <nmukul32@gmail.com>
1 month ago
f3d68cdbea
chore(deps): bump the github-actions group with 4 updates ( #32523 )
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.5 to 4.37.6
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](d1ba80a13d...5595ccaf91
1 month ago
a0c2f6dade
fix: bump go.opentelemetry.io/otel to v1.44.0 for GO-2026-5158 ( #32521 )
...
* fix: bump go.opentelemetry.io/otel to v1.44.0 for GO-2026-5158
govulncheck on main flags GO-2026-5158 in go.opentelemetry.io/otel@v1.43.0
(fixed in v1.44.0). Bump the transitive otel dependency to clear the
vulnerability.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
* fix: bump otel/sdk and otel/sdk/metric to v1.44.0 for version parity
Keep the lockstep-versioned OpenTelemetry core and SDK modules aligned at
v1.44.0 to avoid version skew.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
---------
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 month ago
f8a308cd47
chore(deps): bump github.com/santhosh-tekuri/jsonschema/v6 ( #32514 )
...
Bumps [github.com/santhosh-tekuri/jsonschema/v6](https://github.com/santhosh-tekuri/jsonschema ) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/santhosh-tekuri/jsonschema/releases )
- [Commits](https://github.com/santhosh-tekuri/jsonschema/compare/v6.0.2...v6.0.3 )
---
updated-dependencies:
- dependency-name: github.com/santhosh-tekuri/jsonschema/v6
dependency-version: 6.0.3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 month ago
e8a24895d1
Merge pull request #31580 from biagiopietro/feature/rollback-description-flag
...
feat(rollback): add --description flag to provide rollback reason
1 month ago
819e069eb9
Merge pull request #32516 from helm/dependabot/github_actions/main/github-actions-abda45ccb9
...
chore(deps): bump the github-actions group with 4 updates
1 month ago
47eb219a71
chore(deps): bump the github-actions group with 4 updates
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.4 to 4.37.5
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13dhttps://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f205ea1c33...d1ba80a13d
1 month ago
b44d98328b
Merge branch 'helm:main' into feature/rollback-description-flag
1 month ago
ae877c8bfb
chore(deps): bump the github-actions group with 4 updates ( #32508 )
...
Bumps the github-actions group with 4 updates: [github/codeql-action/init](https://github.com/github/codeql-action ), [github/codeql-action/autobuild](https://github.com/github/codeql-action ), [github/codeql-action/analyze](https://github.com/github/codeql-action ) and [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ).
Updates `github/codeql-action/init` from 4.37.3 to 4.37.4
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e4fba868fa...f205ea1c33
1 month ago
2b239b84e4
Merge branch 'helm:main' into feature/rollback-description-flag
1 month ago
a8ab76e86f
test(action): poll for the interrupted install goroutine instead of a zero-margin sleep ( #32328 )
...
TestInstallRelease_Wait_Interrupted and
TestInstallRelease_RollbackOnFailure_Interrupted assert that the detached
installation goroutine has exited by sleeping a fixed 10s -- exactly the
FailingKubeClient WaitDuration the goroutine blocks on. Sleeping the same
duration the goroutine takes is a zero-margin race: if the goroutine
finishes a hair after the fixed sleep elapses (scheduler jitter under load),
getGoroutineCount() has not decremented yet and the assertion flakes.
Replace the fixed sleep + point-in-time assert with is.Eventually polling
getGoroutineCount() (30s ceiling, 10ms tick). It returns as soon as the
goroutine has actually finished and no longer races the exact wait
duration. Test-only; no change to install behavior.
Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
1 month ago
ac1c68746f
chore(deps): bump actions/stale in the github-actions group ( #32487 )
...
Bumps the github-actions group with 1 update: [actions/stale](https://github.com/actions/stale ).
Updates `actions/stale` from 10.4.0 to 11.0.0
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](1e223db275...4391f3da66
1 month ago
9b1eb018a3
Merge pull request #32339 from 1solomonwakhungu/fix/get-helm-cache-busting
...
fix(scripts): add cache-busting to Helm version checks
1 month ago
7e641d30a9
Merge pull request #32481 from mmorel-35/gofumpt
...
chore: fix gofumpt issues
2 months ago
fda6e6043d
Merge pull request #32484 from helm/dependabot/go_modules/main/go.yaml.in/yaml/v3-3.0.5
...
chore(deps): bump go.yaml.in/yaml/v3 from 3.0.4 to 3.0.5
2 months ago
ce27485634
chore(deps): bump go.yaml.in/yaml/v3 from 3.0.4 to 3.0.5
...
Bumps [go.yaml.in/yaml/v3](https://github.com/yaml/go-yaml ) from 3.0.4 to 3.0.5.
- [Commits](https://github.com/yaml/go-yaml/compare/v3.0.4...v3.0.5 )
---
updated-dependencies:
- dependency-name: go.yaml.in/yaml/v3
dependency-version: 3.0.5
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 months ago
bc0114c708
fix(scripts): clarify cache-busting behavior
...
Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
2 months ago
24bbb46c62
chore: fix gofumpt issues
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
bbaf420a10
fix(scripts): address cache-busting review feedback
...
Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
2 months ago
f3edb83df4
Make golangci-lint happy
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
94a3315f4d
Added missing import
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
500f02d597
Readded "unicode/utf8"
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
f1ede7c9c1
Potential fix for pull request finding
...
If the CLI-side description validation is removed, the unicode/utf8 import becomes unused and should also be dropped.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
4fcc4e4b3d
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
91520a7806
refactor(rollback): validate description length before cluster reachability check
...
Move description length validation to the beginning of Run(), before
IsReachable(), so programmatic callers get an immediate validation
error instead of a potentially misleading cluster reachability failure.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
e73dfab5fb
refactor(test): reuse existing rollback.txt golden file
...
Remove duplicate rollback-with-description.txt fixture that had
identical content to rollback.txt.
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
b177a8e906
Removed extra space in rollback-with-description.txt
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
a92611c202
Enhance rune count in pkg/cmd/rollback.go and pkg/action/rollback.go
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
8a34f3b7b4
Use rune count to count properly multi-byte UTF-8 characters
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
cb91040c44
Enhanced rollback description length
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
e69e424ab1
Changed if construction
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
b606955f09
Set 256 as limit for maxDescriptionLength. 256 comes from MAX value for key and value
...
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
f8180e6de4
feat(rollback): add --description flag to provide rollback reason
...
Add a new --description flag to the helm rollback command that allows
users to specify a custom description explaining why the rollback was
performed. This description is stored in the release metadata.
Changes:
- Add Description field to the Rollback action struct
- Add --description flag to the rollback CLI command
- Add 512 character limit validation for the description
- Default to 'Rollback to <version>' when no description is provided
The description flag is optional and follows the same pattern used by
the install and upgrade commands.
Closes #XXXX
Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>
2 months ago
8eb65528be
Merge pull request #32467 from mmorel-35/testify-assertions-pkg-3
...
chore(pkg): refactor: finer tests conversions to testify part 3
2 months ago
622f16b37f
Update resource_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
61d99a8bdb
Update labels_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
532eabf88a
Update chartrepo_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
bfca0688b1
Update show_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
b59dfd3901
Update rollback_test.go
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
a27f3a0620
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
e29e06e97d
Merge pull request #32466 from mmorel-35/testify-assertions-pkg-2
...
chore(pkg): refactor: finer tests conversions to testify part 2
2 months ago
b152447a15
Merge pull request #32465 from mmorel-35/testify-assertions-internal-1
...
chore(internal): refactor: finer tests conversions to testify part 1
2 months ago
c994f2a36a
Merge pull request #32464 from mmorel-35/testify-assertions-pkg-1
...
chore(pkg): refactor: finer tests conversions to testify part 1
2 months ago
828d01a878
chore(pkg): refactor: finer tests conversions to testify part 1
...
refactor: finer tests conversions to testify in pkg/strvals
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
9a2be11e6f
chore(pkg): refactor: finer tests conversions to testify part 3
...
refactor: finer tests conversions to testify in pkg/cmd
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
4d9c03f51c
chore(pkg): refactor: finer tests conversions to testify part 2
...
#### Description
refactor: finer tests conversions to testify in pkg/storage/driver
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
5142ca8ddc
chore(internal): refactor: finer tests conversions to testify part 1
...
#### Description
refactor: finer tests conversions to testify in internal/chart/v3/util
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2 months ago
8f74dce6ba
chore(deps): bump the k8s-io group across 1 directory with 7 updates ( #32459 )
...
Bumps the k8s-io group with 4 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api ), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl ).
Updates `k8s.io/api` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/api/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apiextensions-apiserver` from 0.36.2 to 0.36.3
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apimachinery` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/apiserver` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/cli-runtime` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/client-go` from 0.36.2 to 0.36.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.36.2...v0.36.3 )
Updates `k8s.io/kubectl` from 0.36.2 to 0.36.3
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.36.2...v0.36.3 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.36.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 months ago
050d3e99b9
chore(deps): bump ossf/scorecard-action in the github-actions group ( #32458 )
...
Bumps the github-actions group with 1 update: [ossf/scorecard-action](https://github.com/ossf/scorecard-action ).
Updates `ossf/scorecard-action` from 2.4.3 to 2.4.4
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](4eaacf0543...2d1146689b
2 months ago
Mukul
dependabot[bot]
Terry Howe
George Jenkins
MrJack
Nikolaus Schuetz
Solomon Wakhungu
Matthieu MOREL