Matt Farina
0d4ea9fd41
Merge pull request #8782 from mattfarina/update-lgtm-process
...
Adding size labels pointer
4 years ago
Matthew Fisher
03a1e8e03c
Merge pull request #8779 from bacongobbler/use-warning
...
use warning function
4 years ago
Matthew Fisher
92c4bda184
use warning function
...
This ensures warning messages are displayed on stderr rather than stdout.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matt Farina
8b546e90a9
Adding size labels pointer
...
Add size of labels and number of reviewers is listed twice, pointing
the area with less detail to the one with more detail.
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matt Farina
367277afc2
Merge pull request #8777 from mattfarina/fix-8771
...
Fixing issue with idempotent repo add
4 years ago
Matt Farina
baf5b76a95
Fixing issue with idempotent repo add
...
A security issue fixed in 3.3.2 caught repos with the same name
being added a second time and produced an error. This caused an
issue for tools, such as helmfile, that will add the same name
with the same configuration multiple times.
This fix checks that the configuration on the existing and new
repo are the same. If there is no change it notes it and exists
with a 0 exit code. If there is a change the existing error is
returned (for reverse compat). If --force-update is given the
user opts in to changing the config for the name.
Closes #8771
Signed-off-by: Matt Farina <matt@mattfarina.com>
4 years ago
Matthew Fisher
2ebe95a6ff
Merge pull request #8755 from bacongobbler/size-s
...
size/S and larger requiring 2 LGTMs
4 years ago
Sebastian Sdorra
467bd49bb0
support passing signing passphrase from file or stdin ( #8394 )
...
Signed-off-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
4 years ago
Matthew Fisher
1138def202
size/S and larger requiring 2 LGTMs
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
2fdd0348a2
Merge pull request #8762 from bacongobbler/chartmuseum-index
...
fix: allow serverInfo field on index files
4 years ago
Matthew Fisher
f19acbdc94
fix: allow serverInfo field on index files
...
A recent change merged into Helm fixes a number of security issues related to parsing malformed index files. Unfortunately, it also broke the ability for users to load index files from chartmuseum, which adds a "server info" field to add additional metadata.
This commit adds that field so that index files from chartmuseum can be validated. Since Helm does not use this field for anything, the information is discarded and unused.
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Adam Reese
5d5ef1d611
Merge pull request #8759 from adamreese/fix/go-build-tags
...
fix(cmd/helm): add build tags for architecture
4 years ago
Adam Reese
45d230fcc9
fix(cmd/helm): add build tags for architecture
...
Signed-off-by: Adam Reese <adam@reese.io>
4 years ago
Matthew Fisher
d9ef5ce8ba
Merge pull request from GHSA-c52f-pq47-2r9j
...
switched to stricter YAML parsing on plugin metadata files
4 years ago
Matthew Fisher
6eeec4a002
switched to stricter YAML parsing on plugin metadata files
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matt Butcher
809e2d999e
Merge pull request from GHSA-m54r-vrmv-hw33
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
055dd41cbe
Merge pull request from GHSA-jm56-5h66-w453
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
59d5b94d35
Merge pull request from GHSA-9vp5-m38w-j776
4 years ago
Matthew Fisher
aa5431ab71
Merge pull request #8751 from technosophos/fix/helm-create-overwrite
...
fixed bug that caused helm create to not overwrite modified files
4 years ago
Matthew Fisher
2a74204508
go fmt
...
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
4 years ago
Matthew Fisher
71ee2c23c8
Merge pull request #8754 from technosophos/fix/repo-add-force-update
...
replace --no-update with --force-update and invert default. BREAKING.
4 years ago
Matthew Fisher
84de24edc9
Merge pull request #8752 from technosophos/fix/better-http-plugin-checks
...
improve the HTTP detection for tar archives
4 years ago
Matt Farina
7953adb06c
Merge branch 'master' into fix/helm-create-overwrite
4 years ago
Matt Butcher
e2da16f514
improve the HTTP detection for tar archives
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
b5daf5a484
Merge pull request #8753 from technosophos/fix/dependency-status
...
handle case where dependency name collisions break dependency resolution
4 years ago
Matt Butcher
882eeac727
replace --no-update with --force-update and invert default. BREAKING.
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
11f75e420c
Merge pull request #8750 from technosophos/fix/helm-create-name
...
validate the name passed in during helm create
4 years ago
Matt Butcher
40b7800287
handle case where dependency name collisions break dependency resolution
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Farina
d3b049759d
Merge pull request #8749 from technosophos/fix/validname-consolidation
...
refactor the release name validation to be consistent across Helm
4 years ago
Matt Farina
37b0d268b3
Merge pull request #8748 from technosophos/fix/check-kubeconfig
...
fix: check mode bits on kubeconfig file
4 years ago
Matt Butcher
106f1fb45c
fixed bug that caused helm create to not overwrite modified files
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
ed5fba5142
refactor the release name validation to be consistent across Helm
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
c4ef82be13
validate the name passed in during helm create
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Matt Butcher
82398667df
fix: check mode bits on kubeconfig file
...
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
4 years ago
Marc Khouzam
459dcd7f72
fix(comp): Disable file comp for output formats
...
It does not make sense to suggest files to the user as output formats.
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
4 years ago
Matthew Fisher
f9077ecd65
Merge pull request #8678 from Foxboron/morten/fix-ldflags-override
...
Makefile: Fix LDFLAGS overriding
4 years ago
Morten Linderud
f917c169d0
Makefile: Fix LDFLAGS overriding
...
When distributions build software it's desirable to have the ability to
define own linker flags, or Go flags. As `-ldflags` defined in `go
build` overrides `-ldflags` defined in the env variable `GOFLAGS`, there
is a distinct need to be able to replace the default values with new
ones or append to them.
Fixes #8645
Signed-off-by: Morten Linderud <morten@linderud.pw>
4 years ago
Matthew Fisher
1b0a26ff32
Merge pull request #8684 from MaXinjian/install
...
Add support to make install helm
4 years ago
Matthew Fisher
55fbd985dd
Merge pull request #8707 from zhijianli88/cleanup-tempfiles
...
Cleanup tempfiles
4 years ago
Ma Xinjian
8b2cf17648
Add support to install helm
...
install the binary that was compiled by make build
Signed-off-by: Ma Xinjian <maxj.fnst@cn.fujitsu.com>
4 years ago
Matthew Fisher
dafeb1541b
Merge pull request #8493 from yxxhero/fix-insecure-skip-tls-verify-flag-not-work-on-helm-install
...
fix insecure-skip-tls-verify flag does't work on helm install
4 years ago
Martin Hickey
5b42157335
Merge pull request #8723 from object88/engine-typo
...
Fixing typo in engine comments
4 years ago
Paul Brousseau
3192408415
Fixing typo in engine comments
...
Signed-off-by: Paul Brousseau <object88@gmail.com>
4 years ago
Li Zhijian
4258e8664e
Use T.cleanup() to cleanup cmdtest_temp file
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
d9ad9153c8
Use RemoveAll to remove a non-empty directory
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
cccc2867ea
mark NewTempServer as Deprecated
...
Please use NewTempServerWithCleanup instead
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Li Zhijian
35c5268d9d
Use T.Cleanup() to cleanup temp dir helm-repotest
...
For backward compatibility, as suggested by @bacongobbler, we introduce
a new API NewTempServerWithCleanup
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
4 years ago
Matthew Fisher
e2442699fa
Merge pull request #8710 from stealthybox/kube-impersonate
...
Implement Impersonation via flags/env
4 years ago
leigh capili
9429af8b39
Support impersonation via flags similar to kubectl --as="user"
...
Signed-off-by: leigh capili <leigh@null.net>
4 years ago
leigh capili
6f780bb750
Document all env vars for CLI help
...
Signed-off-by: leigh capili <leigh@null.net>
4 years ago