069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
...
fix: add formatting for errors to make multiline stacktraces in helm templates
6 months ago
c0aa690c90
Merge pull request #30909 from jinjiadu/main
...
refactor: replace HasPrefix+TrimPrefix with CutPrefix
6 months ago
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
...
fix: action hooks delete policy mutex
6 months ago
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
...
Consider full GroupVersionKind when matching resources
6 months ago
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
...
chore: enable usetesting linter
6 months ago
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
...
fix: add debug logging to oci transport
6 months ago
f9ebe18dae
Merge pull request #30943 from helm/dependabot/github_actions/main/ossf/scorecard-action-2.4.2
...
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2
6 months ago
8706c441c4
build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](f49aabe0b5...05b42c6244
6 months ago
be607c9ec7
Merge pull request #30937 from TerryHowe/legacy-docker-support
...
fix: legacy docker support broken for login
6 months ago
a8cbf3aa51
fix: action hooks delete policy mutex
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 months ago
56a2bb4188
chore: enable usetesting linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
6ab7aa3612
fix: legacy docker support broken for login
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 months ago
5fe7a87138
fix: add debug logging to oci transport
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
6 months ago
de62ed1b2e
Merge pull request #30930 from benoittgt/30927-ci-fix
...
Fix flaky TestFindChartURL due to non-deterministic map iteration
6 months ago
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
...
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm ,
two repositories match due to trailing slash equivalence:
- testing-relative (URL: http://example.com/helm ) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/ ) - does not contain baz chart.. NOT GOOD
The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".
So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.
`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
...
fix: plugin installer test with no Internet
6 months ago
cc39d2428f
fix: plugin installer test with no Internet
...
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 months ago
01adbab466
Merge pull request #30914 from benoittgt/fix-30907
...
Fix dependabot upgrade of jsonschema to v6.0.2
6 months ago
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
...
Closes: https://github.com/helm/helm/pull/30907
To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.
I am wondering if it's related to this commit:
86cca28795
6 months ago
6f8e9e09a4
refactor: replace HasPrefix+TrimPrefix with CutPrefix
...
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
6 months ago
6638935d74
build(deps): bump github.com/santhosh-tekuri/jsonschema/v6
...
Bumps [github.com/santhosh-tekuri/jsonschema/v6](https://github.com/santhosh-tekuri/jsonschema ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/santhosh-tekuri/jsonschema/releases )
- [Commits](https://github.com/santhosh-tekuri/jsonschema/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: github.com/santhosh-tekuri/jsonschema/v6
dependency-version: 6.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
39305fc160
Merge pull request #30905 from robertsirc/forward-port-30902
...
forward porting 30902
6 months ago
b7e127dd6b
amending missed line to delete
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
6 months ago
937c533e37
forward porting 30902
...
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
6 months ago
52dddba759
Merge pull request #30894 from benoittgt/fix-#30881-main
...
Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
6 months ago
54eae46d1d
Merge pull request #30903 from helm/dependabot/go_modules/main/sigs.k8s.io/controller-runtime-0.21.0
...
build(deps): bump sigs.k8s.io/controller-runtime from 0.20.4 to 0.21.0
6 months ago
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
...
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
6 months ago
f939f6145f
Prevent fetching newReference again as we have in calling method
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
cb730c94b5
Help users avoid specifying URL scheme an path
...
We’ve noticed that some users still include the URL scheme and full path
when logging into an OCI registry, for example:
```sh
helm registry login -u $OCI_REGISTRY_USER --password-stdin oci://ghcr.io/org/repo
```
This is no longer necessary and will not be supported in Helm v4.
To guide users toward the correct usage, we should show an example of
the ideal command.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
85ba33bb1d
build(deps): bump sigs.k8s.io/controller-runtime from 0.20.4 to 0.21.0
...
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime ) from 0.20.4 to 0.21.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases )
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/compare/v0.20.4...v0.21.0 )
---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
dependency-version: 0.21.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
1b21f04b3b
Merge pull request #30865 from mmorel-35/github.com/evanphx/json-patch/v5
...
fix: update json-patch import path and add gomodguard settings
6 months ago
875e149d6b
Prevent failure when resolving version tags in oras memory store
...
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.
I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.
Close : #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
707f1aee42
Merge pull request #30884 from mattfarina/revert-toml-change
...
Reverting fix "renders int as float"
6 months ago
cf7613ba6b
Reverting fix "renders int as float"
...
This reverts #13533
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.
The change caused a significant regression.
Note: This kind of change can be put into v3 charts, that are in
active development, without causing a regression.
Closes #30880
Signed-off-by: Matt Farina <matt@mattfarina.com>
6 months ago
334045d002
Merge pull request #30882 from helm/add-lfx-insights
...
Add new LFX Insights Health Score Badge
6 months ago
0c91649ec8
Merge pull request #30871 from gjenkins8/gjenkins/test_registry_localhost
...
Run test OCI registry localhost
6 months ago
30e82e4d0d
Add new LFX Insights Health Score Badge
...
https://insights.linuxfoundation.org/project/helm
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
6 months ago
f043faf0a3
Merge pull request #30862 from OmriSteiner/fix-absolute-uri
...
fix: correctly concat absolute URIs in repo cache
6 months ago
ab56ac62ba
Merge pull request #30866 from mmorel-35/thelper
...
chore: enable thelper linter
6 months ago
b4bc0f1d88
Merge pull request #30872 from benoittgt/fix-30838
...
Bump golangci-lint version to match last golangci-lint-action
6 months ago
a418064a3d
Bump golangci lint to match golangci-lint Github Action version
...
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
6 months ago
46e79be5eb
Merge pull request #30869 from helm/dependabot/go_modules/main/k8s-io-d6f802ad31
...
build(deps): bump the k8s-io group with 7 updates
6 months ago
8ba181c343
Run test OCI registry localhost
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
6 months ago
e4a4855871
build(deps): bump the k8s-io group with 7 updates
...
Bumps the k8s-io group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) | `0.33.0` | `0.33.1` |
| [k8s.io/apiserver](https://github.com/kubernetes/apiserver ) | `0.33.0` | `0.33.1` |
| [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime ) | `0.33.0` | `0.33.1` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go ) | `0.33.0` | `0.33.1` |
| [k8s.io/kubectl](https://github.com/kubernetes/kubectl ) | `0.33.0` | `0.33.1` |
Updates `k8s.io/api` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/api/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiextensions-apiserver` from 0.33.0 to 0.33.1
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases )
- [Commits](https://github.com/kubernetes/apiextensions-apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apimachinery` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/apiserver` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/apiserver/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/cli-runtime` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/cli-runtime/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/client-go` from 0.33.0 to 0.33.1
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.33.0...v0.33.1 )
Updates `k8s.io/kubectl` from 0.33.0 to 0.33.1
- [Commits](https://github.com/kubernetes/kubectl/compare/v0.33.0...v0.33.1 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apiserver
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/cli-runtime
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/kubectl
dependency-version: 0.33.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
6 months ago
fbc153460f
Merge pull request #30863 from mattfarina/list-tests
...
Adding test for list command
6 months ago
b0da8a2eb9
Merge pull request #30864 from jessesimpson36/remove-redundant-debug-line
...
fix: remove duplicate error message
6 months ago
157f0ba10a
chore: enable thelper
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
706392fabb
fix: update json-patch import path and add gomodguard settings
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
6 months ago
098486d221
fix: remove duplicate error message
...
closes #30857
There are 2 ways the error message from any subcommand is printed:
1. through the debug log line that this PR removes
2. through the spf13/cobra package before the error type is returned to
the caller.
Since the spf13/cobra package already prints out the error, there is no
use in redundantly printing out the error again within the debug log
line.
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
6 months ago
b5a4781099
Adding test for list command
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
6 months ago
Scott Rigby
Robert Sirchia
dependabot[bot]
Matt Farina
Terry Howe
Matthieu MOREL
Benoit Tigeot
George Jenkins
jinjiadu
Matt Farina
Chris Aniszczyk
Jesse Simpson