PR #5072 followed by #5406 tweaked the handling of the associative
array 'aliashash' when in zsh. However, upon further investigation
the root of the problem was the 'aliashash' was not being declared
properly as it was declared within a method and therefore not
accessible to the rest of the completion script.
The previous commit of this PR makes the necessary change to properly
declare 'aliashash' which makes the previous tweak unecessary. This
commit removes the tweak.
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
This is a bug I ran into when working on Helm completion.
I was surprised that it didn't happen when I was using
kubectl, so I investigated and found a PR that fixed this
bug in kubectl:
https://github.com/kubernetes/kubernetes/pull/48553
I duplicated the code in this commit which:
Removes __helm_declare, which is safe to do since
`declare -F` is already replaced to `whence -w` by
__helm_convert_bash_to_zsh().
The problem was that calling "declare" from inside a function
scopes the declaration to that function only. So "declare"
should not be called through __helm_declare() but instead
directly.
To reproduce:
1- setup helm completion in zsh
2- helm --kubeconfig=$HOME/.kube/config statu<TAB>
you will get the error:
__helm_handle_flag:27: bad math expression: operand expected at end of string
Co-authored-by: Kazuki Suda <kazuki.suda@gmail.com>
Signed-off-by: Marc Khouzam <marc.khouzam@ville.montreal.qc.ca>
The 'app.kubernetes.io/version' label was not being rendered as
expected. It was appending onto the label before it and also
the next label label was appending onto it on the same line.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
I've added an alias to git.io the github url shortening service from git.io/get_helm.sh -> https://raw.githubusercontent.com/helm/helm/master/scripts/get
Like this:
```
$ curl -i https://git.io/ -F url=https://raw.githubusercontent.com/helm/helm/master/scripts/get -F code=get_helm.sh
HTTP/1.1 201 Created
Server: Cowboy
Connection: keep-alive
Date: Fri, 19 Apr 2019 23:20:39 GMT
Status: 201 Created
Content-Type: text/html;charset=utf-8
Location: https://git.io/get_helm.sh
Content-Length: 62
X-Xss-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Runtime: 0.008310
X-Node: f065811c-e0e8-4384-bf09-9d9d28586c4d
X-Revision: 392798d237fc1aa5cd55cada10d2945773e741a8
Strict-Transport-Security: max-age=31536000; includeSubDomains
Via: 1.1 vegur
```
I think it's a little easier to remember and use.
There is also no way to overwrite or modify alias. Once it's there it's there in perpetuity.
Thanks!
Signed-off-by: Duffie Cooley <dcooley@heptio.com>
Hi! This PR adds a link to [Cloudsmith](https://cloudsmith.io), which is a package management service SaaS. It's commercial, but it's completely free for open-source and it has generous free tiers otherwise. It has first-class support for Helm (and many other package formats, such as npm, Docker etc), plus org/teams management, granular access controls, private repositories, repository-specific entitlements, a worldwide content distribution network, webhooks, access logs, etc. Thank you. :)
Full disclosure: I work at Cloudsmith. \o/
Signed-off-by: Alan Carson <acarson@cloudsmith.io>
Note, he has been emailed regarding the move including an offer to
re-engage. He has not taken this up. The governance has a 3 months
of inactivity clause that causes maintainers to fall off. This
period has been long exceeded per metrics measured in devstats.
Signed-off-by: Matt Farina <matt@mattfarina.com>
Marc Khouzam
Matthew Fisher
Martin Hickey
Jeff Knurek
Morten Torkildsen
Matt Farina
Luis Davim
Jintao Zhang
Duffie Cooley
Panic Stevenson
Evan Vetere
Alan Carson
SataQiu
Tariq Ibrahim
Adam Reese
Adam Reese
dieutth
Taylor Thomas
xichengliudui