d461463085
Merge pull request #32299 from benoittgt/avoid-issue-with-govuln-deprecation
...
fix(ci): resolve Node 20 deprecation in govulncheck
1 month ago
ed651de9b1
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
1 month ago
ca24a55c31
fix(ci): resolve Node 20 deprecation in govulncheck
...
The pinned v1.0.4 used actions/checkout@v4 and
actions/setup-go@v5 internally, both built on Node 20.
Latest main uses v6 of both, which run on Node 24.
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
1 month ago
d262c7ca79
Merge pull request #32296 from mmorel-35/gocritic-singleCaseSwitch
...
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
1 month ago
50fb6ff85b
Merge pull request #32294 from mmorel-35/testifylint
...
chore: fix several checks issues from testifylint
1 month ago
a572f23b82
Merge pull request #32298 from helm/dependabot/go_modules/main/golang.org/x/text-0.39.0
...
chore(deps): bump golang.org/x/text from 0.38.0 to 0.39.0
1 month ago
e3fbe2e9d1
chore(deps): bump golang.org/x/text from 0.38.0 to 0.39.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.38.0 to 0.39.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.38.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-version: 0.39.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
96b315f188
chore: fix emptyStringTest, nestingReduce and singleCaseSwitch checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
c1569ea83f
Update pkg/cmd/history_test.go
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
65077c10fa
test: replace assert.Equal with require.EqualError for improved error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
4ade4a5495
test: replace assert.Contains with assert.ErrorContains for better error handling
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
f34ad6c337
chore: fix several checks issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
7b999ddc07
Merge pull request #32293 from mmorel-35/gocritic-httpNoBody
...
chore: fix several checks issues from gocritic
1 month ago
47bde11959
test(cli): use t.Cleanup for resetEnv with t.Setenv
...
Signed-off-by: LarytheLord <llawlietbagsum@gmail.com>
1 month ago
9b30076180
test(cli): isolate user-agent rest config test from host kubeconfig
...
Signed-off-by: LarytheLord <llawlietbagsum@gmail.com>
1 month ago
07259ecc86
chore: fix several checks issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 month ago
143631f735
fix(engine): prevent Files.Lines panic on empty file
...
Files.Lines guards against a nil entry but an empty file inside a
chart is stored as a non-nil zero-length byte slice, so the trailing
newline check indexes s[-1] and panics. The engine recovers the panic
into a render error, making every template/install/upgrade/lint that
references the file fail.
Extend the guard to len(f[path]) == 0 and return an empty slice,
matching the behaviour for missing files.
Fixes #32279
Signed-off-by: Mahesh Sadupalli <mahesh.sadupalli@gmail.com>
1 month ago
543b94d673
Merge pull request #31211 from kimsungmin1/main-fix-push-scope
...
fix: set [pull,push] scope when helm push to a registry(use token auth) - v4
1 month ago
d539556a8d
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: kimsungmin1 <142377392+kimsungmin1@users.noreply.github.com>
1 month ago
b229279def
Merge pull request #32285 from helm/dependabot/github_actions/main/github/codeql-action/upload-sarif-4.36.3
...
chore(deps): bump github/codeql-action/upload-sarif from 4.36.2 to 4.36.3
1 month ago
e9eda8c598
chore(deps): bump github/codeql-action/upload-sarif
...
Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action ) from 4.36.2 to 4.36.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](8aad20d150...54f647b7e1
1 month ago
503acff975
fix(registry): resolve golangci-lint issues in token-auth tests
...
- Use (*net.ListenConfig).Listen with the test context instead of
net.Listen (noctx).
- Use suite.NoError instead of suite.Nil for the error check
(testifylint).
- Drop the unnecessary leading blank lines in the scope test funcs
(whitespace).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
4e9ca06856
chore: go mod tidy after rebase on main
...
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
3cbee7e935
fix(registry): use plain-http registry in token-auth scope test
...
The scope test configured a TLS registry while advertising an http token
realm. oras refuses to send credentials to an http token realm when the
registry itself was contacted over https, so the auth server was never
reached and the test timed out ("timeout waiting for auth request").
Use a plain-http registry so the registry and token-realm schemes match;
the scope carried in the token request is what this test verifies, and
that is independent of TLS.
Also make the auth handler's channel send non-blocking so that a client
retry can never block the handler and stall the push/pull flow, which
addresses the review comment about a potential deadlock.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
26ada49c1a
Update pkg/registry/client.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 month ago
9b7a70f0ca
test: improve client_scope_test.go to avoid data races and brittle assertions
...
- Fix data race by using channel instead of shared variable for requestURL
- Make assertions more robust by parsing URL and checking query parameters instead of exact string matching
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
ee181f4570
fix typos in withScopeHint function comment
...
- Change 'bellow' to 'below' (spelling correction in multiple places)
- Change 'WithScopeHint' to 'withScopeHint' to match actual function name
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
1f0a728496
fix registry test failures by adjusting DockerRegistryHost and auth server listener management
...
- Change DockerRegistryHost to use 127.0.0.1 for HTTP tests and helm-test-registry for TLS tests to match certificate hostname
- Add defer ln.Close() to prevent resource leak in token auth server setup
- Restore requestURL variable and assertion in test body instead of handler to avoid potential race condition
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
8883c9cc70
fix variable naming requestUrl -> requestURL
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
530e728ea9
fix typo, remove unnecessary code, fix to avoid to use the assertion in http hanlder
...
Signed-off-by: kimsm28 <sm28.kim@samsung.com>
1 month ago
26e5071f66
change suite.Nil, suite.NotNill to more proper function(suite.NoError, suite.Error)
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
8c8d6e3262
change client_scope_test.go to use httptest
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
9d77ccd46d
fix typo
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
fc743b2a1b
remove freeport dependency
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
319e06cda3
add newline in license header
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
301e3a12d5
fix scope when helm push to a registry that use token auth
...
Signed-off-by: kimsungmin1 <sm28.kim@samsung.com>
1 month ago
af25d22902
Merge pull request #32275 from helm/dependabot/github_actions/main/golangci/golangci-lint-action-9.3.0
...
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
1 month ago
943242fb83
Merge pull request #32276 from helm/dependabot/go_modules/main/github.com/fluxcd/cli-utils-1.2.2
...
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
1 month ago
5a9b8a788f
chore(deps): bump github.com/fluxcd/cli-utils from 1.2.1 to 1.2.2
...
Bumps [github.com/fluxcd/cli-utils](https://github.com/fluxcd/cli-utils ) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/fluxcd/cli-utils/releases )
- [Commits](https://github.com/fluxcd/cli-utils/compare/v1.2.1...v1.2.2 )
---
updated-dependencies:
- dependency-name: github.com/fluxcd/cli-utils
dependency-version: 1.2.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
1 month ago
f76136d39f
chore(deps): bump golangci/golangci-lint-action from 9.2.1 to 9.3.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 9.2.1 to 9.3.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](82606bf257...ba0d7d2ec0
1 month ago
188d331dc3
Merge pull request #32259 from gjenkins8/refactor/testify-pkg-cli
...
refactor(pkg/cli): convert tests to testify assert/require
2 months ago
144246cd28
Potential fix for pull request finding
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
187a02298a
Merge pull request #32263 from helm/dependabot/github_actions/main/actions/setup-go-6.5.0
...
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
2 months ago
07faec5593
chore(deps): bump actions/setup-go from 6.4.0 to 6.5.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.4.0 to 6.5.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](4a3601121d...924ae3a1cd
2 months ago
61bba7c659
Apply suggestions
...
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Will Noble <4642422+ouillie@users.noreply.github.com>
2 months ago
d887779b9b
Properly format the extra field in gzipped packages
...
Signed-off-by: Will Noble <author@will.party>
2 months ago
1ffd0012d3
Merge pull request #32221 from gjenkins8/refactor/testify-pkg-small
...
refactor(pkg): convert tests to testify assert/require
2 months ago
dd443e9685
Merge pull request #32260 from gjenkins8/refactor/testify-internal-small
...
refactor(internal): convert tests to testify assert/require
2 months ago
addbab2e64
refactor(internal): convert tests to testify assert/require
...
Convert internal/urlutil, internal/cli/output, internal/monocular,
and internal/sympath test files from native Go testing patterns
(t.Errorf, t.Fatalf, t.Error, t.Fatal) to github.com/stretchr/testify
equivalents (assert.X, require.X).
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2 months ago
0bca9871ad
Merge pull request #32254 from gjenkins8/refactor/testify-pkg-registry
...
refactor(pkg/registry): convert tests to testify assert/require
2 months ago
Terry Howe
Benoit Tigeot
Benoit Tigeot
dependabot[bot]
Matthieu MOREL
George Jenkins
LarytheLord
Mahesh Sadupalli
kimsungmin1
kimsm28
Will Noble
Will Noble