test: replace assert.Equal with require.EqualError for improved error handling

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

pkg/strvals/literal_parser_test.go

@@ -451,9 +451,7 @@ func TestParseLiteralNestedLevels(t *testing.T) {
 		if err != nil {
 			if tt.err {
 				if tt.errStr != "" {
-					if err.Error() != tt.errStr {
-						assert.Equal(t, tt.errStr, err.Error())
-					}
+					require.EqualError(t, err, tt.errStr)
 				}
 				continue
 			}
@@ -468,9 +466,7 @@ func TestParseLiteralNestedLevels(t *testing.T) {
 		require.NoError(t, err)
 
 		y2, err := yaml.Marshal(got)
-		if err != nil {
-			require.NoError(t, err, "Error serializing parsed value")
-		}
+		require.NoError(t, err, "Error serializing parsed value")
 
 		if !bytes.Equal(y1, y2) {
 			assert.Equal(t, string(y1), string(y2), tt.str)

pkg/strvals/parser_test.go

@@ -779,9 +779,7 @@ func TestParseSetNestedLevels(t *testing.T) {
 		if err != nil {
 			if tt.err {
 				if tt.errStr != "" {
-					if err.Error() != tt.errStr {
-						assert.Equal(t, tt.errStr, err.Error())
-					}
+					require.EqualError(t, err, tt.errStr)
 				}
 				continue
 			}
@@ -794,9 +792,7 @@ func TestParseSetNestedLevels(t *testing.T) {
 		y1, err := yaml.Marshal(tt.expect)
 		require.NoError(t, err)
 		y2, err := yaml.Marshal(got)
-		if err != nil {
-			require.NoError(t, err, "Error serializing parsed value")
-		}
+		require.NoError(t, err, "Error serializing parsed value")
 
 		if !bytes.Equal(y1, y2) {
 			assert.Equal(t, string(y1), string(y2), tt.str)