From 65077c10fa3e4f339142f498d84c1c7bfb1d320b Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Mon, 6 Jul 2026 09:37:12 +0000 Subject: [PATCH] test: replace assert.Equal with require.EqualError for improved error handling Signed-off-by: Matthieu MOREL --- pkg/strvals/literal_parser_test.go | 8 ++------ pkg/strvals/parser_test.go | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/pkg/strvals/literal_parser_test.go b/pkg/strvals/literal_parser_test.go index 5d65557c5..aab8e1b73 100644 --- a/pkg/strvals/literal_parser_test.go +++ b/pkg/strvals/literal_parser_test.go @@ -451,9 +451,7 @@ func TestParseLiteralNestedLevels(t *testing.T) { if err != nil { if tt.err { if tt.errStr != "" { - if err.Error() != tt.errStr { - assert.Equal(t, tt.errStr, err.Error()) - } + require.EqualError(t, err, tt.errStr) } continue } @@ -468,9 +466,7 @@ func TestParseLiteralNestedLevels(t *testing.T) { require.NoError(t, err) y2, err := yaml.Marshal(got) - if err != nil { - require.NoError(t, err, "Error serializing parsed value") - } + require.NoError(t, err, "Error serializing parsed value") if !bytes.Equal(y1, y2) { assert.Equal(t, string(y1), string(y2), tt.str) diff --git a/pkg/strvals/parser_test.go b/pkg/strvals/parser_test.go index 6d254ca8d..1b73ae16a 100644 --- a/pkg/strvals/parser_test.go +++ b/pkg/strvals/parser_test.go @@ -779,9 +779,7 @@ func TestParseSetNestedLevels(t *testing.T) { if err != nil { if tt.err { if tt.errStr != "" { - if err.Error() != tt.errStr { - assert.Equal(t, tt.errStr, err.Error()) - } + require.EqualError(t, err, tt.errStr) } continue } @@ -794,9 +792,7 @@ func TestParseSetNestedLevels(t *testing.T) { y1, err := yaml.Marshal(tt.expect) require.NoError(t, err) y2, err := yaml.Marshal(got) - if err != nil { - require.NoError(t, err, "Error serializing parsed value") - } + require.NoError(t, err, "Error serializing parsed value") if !bytes.Equal(y1, y2) { assert.Equal(t, string(y1), string(y2), tt.str)