a7f84439aa
test(kube): fix flaky WaitForDelete test by avoiding informer sync race
...
The previous fix (increasing timeout / reducing deletion delay) did not
work because the flakiness is not a timing problem at all.
Root cause: fluxcd/cli-utils HasSynced() returns true after the initial
list item is *popped* from DeltaFIFO, which is before AddFunc delivers
the ResourceUpdateEvent to the collector. This creates a race where the
SyncEvent can arrive at the statusObserver *before* the pod's Current
status is recorded. When that happens:
- statusObserver sees pod as Unknown
- Unknown is skipped for WaitForDelete (by design, to handle resources
that were already deleted before watching started)
- AggregateStatus([], NotFoundStatus) == NotFoundStatus → cancel()
- The watch context is cancelled before DeleteFunc can fire
- Final check: pod still Current → error
The test intent is to verify that waitForDeleteCtx (not the cancelled
generalCtx) is selected. A non-existent resource satisfies this:
- With waitForDeleteCtx=Background(): informer syncs with empty list
→ Unknown → cancel → success ✓
- With generalCtx (cancelled, wrong): context immediately done
→ ctx.Err() appended → error returned ✓
Remove the goroutine-based deletion and the pod creation to eliminate
the race while preserving the context-selection assertion.
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
c004f4ddfe
Merge pull request #32014 from AnmolVirdi/doc-import-minor
...
Minor fix (docs.go): fix import instructions to comply with canonical import paths
4 months ago
4c0d21f53f
test(kube): fix flaky WaitForDelete timing in status wait tests
...
TestMethodContextOverridesGeneralContext/WaitForDelete used a 1s
timeout with a 500ms deletion delay, leaving only ~500ms for the
fake watcher to propagate the delete event. On loaded CI runners
this window is too tight and causes intermittent failures.
Increase the timeout to 5s and reduce the deletion delay to 100ms
so there is ample headroom. Apply the same deletion-delay reduction
to TestStatusWaitForDelete which shares the same pattern.
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
4 months ago
08dea9c140
chore(deps): bump github.com/distribution/distribution/v3
...
Bumps [github.com/distribution/distribution/v3](https://github.com/distribution/distribution ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/distribution/distribution/releases )
- [Commits](https://github.com/distribution/distribution/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: github.com/distribution/distribution/v3
dependency-version: 3.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
de58531ca7
Minor nit: fix import instructions to comply with canonical import paths
...
Signed-off-by: Anmol Virdi <anmolvirdi2000@gmail.com>
4 months ago
9b1ad4cf02
chore(deps): bump github.com/distribution/distribution/v3
...
Bumps [github.com/distribution/distribution/v3](https://github.com/distribution/distribution ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/distribution/distribution/releases )
- [Commits](https://github.com/distribution/distribution/compare/v3.0.0...v3.1.0 )
---
updated-dependencies:
- dependency-name: github.com/distribution/distribution/v3
dependency-version: 3.1.0
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
e4ace180d2
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
8ef2d45934
fix(action): return correct error variable in prepareUpgrade
...
When Deployed() succeeds but releaserToV1Release() fails, prepareUpgrade
returned err (nil) instead of cerr (the conversion error), causing a
silent nil return that could lead to nil pointer dereferences downstream.
Closes #32007
Signed-off-by: Rhys McNeill <rhysmcneill7@hotmail.co.uk>
4 months ago
1be395e7aa
Merge pull request #31996 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.2
...
chore(deps): bump github.com/lib/pq from 1.12.1 to 1.12.2
4 months ago
42db90d9e8
Merge branch 'helm:main' into feature/rollback-revision-history
4 months ago
cd7cf76a17
chore(deps): bump github.com/lib/pq from 1.12.1 to 1.12.2
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.12.1...v1.12.2 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.12.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
4 months ago
4d4642b83f
Merge pull request #31994 from helm/dependabot/github_actions/main/github/codeql-action-4.35.1
...
chore(deps): bump github/codeql-action from 4.30.7 to 4.35.1
4 months ago
45ee55b83f
chore(deps): bump github/codeql-action from 4.30.7 to 4.35.1
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 4.30.7 to 4.35.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e296a93559...c10b8064de
4 months ago
67ef801c98
Merge pull request #31974 from TerryHowe/fix/pin-actions-to-sha
...
fix: pin codeql-action/upload-sarif to commit SHA
4 months ago
e2a2ed5009
Merge pull request #31984 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.1
...
chore(deps): bump github.com/lib/pq from 1.12.0 to 1.12.1
5 months ago
9a06741884
chore(deps): bump github.com/lib/pq from 1.12.0 to 1.12.1
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.12.0...v1.12.1 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.12.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
d1e31ca507
chore(deps): bump actions/setup-go from 6.2.0 to 6.4.0
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 6.2.0 to 6.4.0.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](7a3fe6cf4c...4a3601121d
5 months ago
f257c95c78
fix(kube): clarify server-side apply patch errors
...
Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
5 months ago
7e149c7229
Merge pull request #31973 from Debasish-87/fix-registry-comments
...
docs(registry): fix incorrect and improve clarity of comments in client.go
5 months ago
7025480397
fix: pin codeql-action/upload-sarif to commit SHA in scorecards workflow
...
Pin the remaining unpinned GitHub Action reference to a full commit SHA,
matching the pinning convention already used across other workflows in
this repository. Aligns with the Kubernetes GitHub Actions security policy.
Signed-off-by: Terry Howe <thowe@nvidia.com>
5 months ago
64f1d0af5b
refactor(cli): decouple EnvSettings from pkg/kube
...
Move the retrying HTTP round-tripper used by EnvSettings into pkg/cli so
pkg/cli no longer imports pkg/kube, avoiding import cycles for Helm
library consumers while preserving retry behavior for transient API
server errors.
Add pkg/cli/roundtripper_test.go with parity coverage for the moved logic.
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com>
Made-with: Cursor
5 months ago
85bf56ea82
docs(registry): fix incorrect and improve clarity of comments in client.go
...
- Fixed incorrect comment in ClientOptPlainHTTP
- Improved clarity of LoginOptPlainText comment
- Enhanced Login function documentation
- Improved wording for ClientOptHTTPClient
No functional changes.
Signed-off-by: Debasish Mohanty <139056705+Debasish-87@users.noreply.github.com>
5 months ago
154993723a
refactor(cli): decouple EnvSettings from pkg/kube to avoid import cycles
...
Move the retrying round tripper used by EnvSettings into pkg/cli so
pkg/cli no longer imports pkg/kube. This preserves retry behavior while
breaking the import edge that triggers cycles for Helm library consumers
(such as the kustomize integration described in #31965 ).
Signed-off-by: Sumit Solanki <sumit.solanki@ibm.com>
5 months ago
b3927b3900
Merge pull request #31961 from helm/dependabot/go_modules/main/github.com/ProtonMail/go-crypto-1.4.1
...
chore(deps): bump github.com/ProtonMail/go-crypto from 1.3.0 to 1.4.1
5 months ago
23a25f67ff
Merge pull request #31960 from helm/dependabot/go_modules/main/github.com/lib/pq-1.12.0
...
chore(deps): bump github.com/lib/pq from 1.11.2 to 1.12.0
5 months ago
8e44f8e3fe
Merge pull request #31957 from Mentigen/add-mustToToml
...
feat(engine): add mustToToml template function
5 months ago
7369ac0eaa
Merge pull request #31959 from helm/dependabot/go_modules/main/github.com/fatih/color-1.19.0
...
chore(deps): bump github.com/fatih/color from 1.18.0 to 1.19.0
5 months ago
c7a75b16cb
chore(deps): bump github.com/ProtonMail/go-crypto from 1.3.0 to 1.4.1
...
Bumps [github.com/ProtonMail/go-crypto](https://github.com/ProtonMail/go-crypto ) from 1.3.0 to 1.4.1.
- [Release notes](https://github.com/ProtonMail/go-crypto/releases )
- [Commits](https://github.com/ProtonMail/go-crypto/compare/v1.3.0...v1.4.1 )
---
updated-dependencies:
- dependency-name: github.com/ProtonMail/go-crypto
dependency-version: 1.4.1
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
3a7573a81e
chore(deps): bump github.com/lib/pq from 1.11.2 to 1.12.0
...
Bumps [github.com/lib/pq](https://github.com/lib/pq ) from 1.11.2 to 1.12.0.
- [Release notes](https://github.com/lib/pq/releases )
- [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lib/pq/compare/v1.11.2...v1.12.0 )
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-version: 1.12.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
0229da1803
chore(deps): bump github.com/fatih/color from 1.18.0 to 1.19.0
...
Bumps [github.com/fatih/color](https://github.com/fatih/color ) from 1.18.0 to 1.19.0.
- [Release notes](https://github.com/fatih/color/releases )
- [Commits](https://github.com/fatih/color/compare/v1.18.0...v1.19.0 )
---
updated-dependencies:
- dependency-name: github.com/fatih/color
dependency-version: 1.19.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
ce203dc568
Merge pull request #31938 from mmorel-35/perfsprint
...
chore: enable perfsprint linter
5 months ago
563d1cfa73
Merge pull request #31934 from helm/dependabot/go_modules/main/golang.org/x/crypto-0.49.0
...
chore(deps): bump golang.org/x/crypto from 0.48.0 to 0.49.0
5 months ago
dde23c5e9c
Merge pull request #31945 from helm/dependabot/go_modules/google.golang.org/grpc-1.79.3
...
chore(deps): bump google.golang.org/grpc from 1.78.0 to 1.79.3
5 months ago
aa5e205b3b
Merge pull request #31953 from mmorel-35/revive-unnecessary-format
...
chore: fix unnecessary-format issues from revive
5 months ago
c1a5a6e260
docs(engine): fix misleading toTOML doc comment
...
The toTOML doc comment said "returns empty string on marshal error"
but the implementation actually returns err.Error(). Fix the comment
to match the real behavior. Also mention mustToToml as the strict
alternative.
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
5 months ago
b075f7a35d
feat(engine): add mustToToml template function
...
Add `mustToToml` that panics on marshal error, consistent with
`mustToYaml` and `mustToJson`. This makes it possible for chart authors
to get a hard failure when TOML serialization fails, rather than having
to inspect the output manually.
`toToml` behavior is unchanged in this commit.
Closes #31430
Signed-off-by: Ilya Kiselev <kis-ilya-a@yandex.ru>
5 months ago
7edfff33eb
chore: fix unnecessary-format issues from revive
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
37185d2ea6
chore(deps): bump google.golang.org/grpc from 1.78.0 to 1.79.3
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.78.0 to 1.79.3.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.78.0...v1.79.3 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-version: 1.79.3
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
071558d69f
chore: fix bool-compare issues from testifylint
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
83a0138172
chore: fix deprecatedComment issues from gocritic
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
af31a67924
chore: enable errorlint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
62494896e9
chore: enable perfsprint linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
1e0f702f00
chore: fix whitespace linter
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
5 months ago
42f78ba60e
Merge pull request #31872 from mmorel-35/perfsprint-pkg-6-5f845e3
...
chore(pkg): fix perfsprint linter issues part 6
5 months ago
e3b4808450
Merge pull request #31874 from mmorel-35/perfsprint-pkg-4-fb6db58
...
chore(pkg): fix perfsprint linter issues part 4
5 months ago
610547b570
Merge pull request #31873 from mmorel-35/perfsprint-pkg-5-3294250
...
chore(pkg): fix perfsprint linter issues part 5
5 months ago
a753caca76
Merge branch 'helm:main' into feature/rollback-revision-history
5 months ago
47a084091e
ignore error plugin loads (cli, getter)
...
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
5 months ago
3d06fd1feb
chore(deps): bump golang.org/x/crypto from 0.48.0 to 0.49.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.48.0 to 0.49.0.
- [Commits](https://github.com/golang/crypto/compare/v0.48.0...v0.49.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.49.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
5 months ago
d3df72e560
Merge pull request #31932 from TerryHowe/fix/remove-legacy-import-comments-test-files
...
pkg/kube: remove legacy import comments from test files
5 months ago
Terry Howe
dependabot[bot]
Anmol Virdi
MrJack
Rhys McNeill
abhay1999
Terry Howe
Sumit Solanki
Debasish Mohanty
George Jenkins
Ilya Kiselev
Matthieu MOREL