601 Commits (main)

Author	SHA1	Message	Date
Benoit Tigeot	b2380720eb	Migrate to pure slog without a custom wrapper ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	b42767be40	Migrate more code to log adapter ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	83cdffe4ae	Migrate to a dedicated internal package for slog adapter + migrate more ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	3a22df9731	Deal with linting errors ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	394ba2d55e	Properly use DefaultLogger ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	eb2dfe7dbf	Some interesting rephrasing by Terry Howe ... See: https://github.com/helm/helm/pull/30698#discussion_r2012394228 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	227d270788	Extra comment + Default logger fallback ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	b642bca8f6	Provide an adapter to easily pass a slog.Default() ... ``` helmClient.Log = NewSlogAdapter(slog.Default()) ``` Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	d6d7cff417	Try to make log more common and more easily grepable ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	8d30464f2c	Do no mask warning alerts ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	dfaf249221	Remove unreachable error ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	f4631bf3d8	Migrate kube package to slog ... As for helm v4. We want to migrate logs to slog. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Patrick Seidensal	e55707b09d	Fix --take-ownership ... If a resource exists in the cluster and is to be adopted by helm install --take-ownership, it is left unchanged while helm reports the installation to have succeeded. This is due to CRs and CRDs being merged without three-way-merge, which results in an empty patch. By using a three-way-merge transparently when --take-ownership is used, the helm behaves as expected without breaking previous behavior. Fixes #30622 Signed-off-by: Patrick Seidensal <pseidensal@suse.com>	1 year ago
Scott Rigby	985f5af538	Merge pull request #13604 from AustinAbro321/refactor-wait ... Introduce kstatus watcher	1 year ago
Scott Rigby	122e7b441a	Merge pull request #13458 from thudi/main ... #13449 Resolves: Replacing NewSimpleClientSet to NewClientSet due to deprecation	1 year ago
Austin Abro	21ee721242	go fmt ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	8efd428e5d	switch back to k8s rest mapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	83266254f0	merge ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	386523bdbc	update to get waiter instead of set ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Benoit Tigeot	4f4c858f9c	Ignore unused parameter ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	94cb21c7c4	Follow convention for error with slog.Any() ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	e3e84b6dfe	"beginning wait" is dedicated to be display as debug log ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Benoit Tigeot	0e4d185370	Inform about time spent waiting resources to be ready in slog format ... Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 year ago
Austin Abro	10f78c814c	legacy waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	600947b32e	client->restmapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	3a296aacad	rest mapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	24dc643822	restmapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	09faaac273	merge ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Robert Sirchia	4da004e2dc	removing old apis ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Austin Abro	29c250c233	add back interface log check ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	a18589c4d8	fmt ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	5a254dae21	cleanup ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	11eeb4a6b1	merge ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	4f33e5c97f	test refactoring ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	75292c5e04	refactor ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Austin Abro	b79dfd09b0	refactor ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	1 year ago
Scott Rigby	2cda65d444	Merge pull request #10309 from Bez625/main ... Add hook annotation to output hook logs to client on error	1 year ago
Robert Sirchia	8dd279271e	remove unused config.go ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	1 year ago
Chris Berry	6d30fa5990	Add HookOutputFunc and generic yaml unmarshaller ... Signed-off-by: Chris Berry <bez625@gmail.com>	1 year ago
Chris Berry	3d4e679d9f	Update based on review comments ... Signed-off-by: Chris Berry <bez625@gmail.com>	1 year ago
Chris	3964f84ac8	Tidy up imports ... Signed-off-by: Chris <bez625@gmail.com>	1 year ago
Chris Berry	cde407b7d1	Add hook annotations to output pod logs to client on success and fail ... Signed-off-by: Chris Berry <bez625@gmail.com>	1 year ago
Robert Sirchia	8207fafe13	fixing error handling from a previous PR ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Austin Abro	ea87c49d1b	print ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	efde830405	better name ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	ecd5316577	lint ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	5d12255497	wait for delete ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	7fde4962a8	set waiter in functions ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	978d5a3318	lint ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	f2dd2c9109	add hook only waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	2b03c527f1	set command line flags ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
wangjingcun	8b8cc94822	Use a more direct and less error-prone return value ... Signed-off-by: wangjingcun <wangjingcun@aliyun.com>	2 years ago
Austin Abro	bd3b5ee5d0	comment ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	7207565e12	lint ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	f866409c50	move statusreaders to it's own package ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	14391dea5b	pods and jobs working ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	d1cc9b39a3	tests for status reader ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	187e99d299	custom status readers look good ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	f49a7e134a	start watch until ready ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	cc83b7c2e6	tests passing ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	0314135290	tests passing ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	b9cbc93003	tests passing ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	59ef43e399	tests passing ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	bbe3246f0a	tests passing ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	a590999323	switch client ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	a8f53f98ee	WIP custom status reader ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
George Jenkins	d637595735	chore: Remove unused `WaitAndGetCompletedPodPhase` ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	2 years ago
Austin Abro	f1b642cb0d	unexport newWaiter function ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	916aecf1f1	Merge remote-tracking branch 'origin/main' into refactor-wait	2 years ago
Austin Abro	cf51d714e8	go fmt ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4e12f9d530	simplify messages ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	e56a6e678f	diff ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	a859742e28	remove rest mapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	c2dc44deb9	use dynamic rest mapper ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	9894d3ae78	shorten interface ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	8fe66998bf	refactor obj logic ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	f9736d9022	renames ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	d07f546003	get rid of rest client ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	eaa6e14546	test cleanup ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	674ab0d4f6	t.Parrallel ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	e9d9854364	introduce test for status wait ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	71434c0b38	implement logger ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	649475265d	implement logger ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	c26b44f651	update names ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	8ce1876192	get rid of ext interface ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	e6c6a40fe0	general error message ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	6b68a00440	change error messages ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	ac9012577a	status function ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	b8bdcc3a2b	Helm waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4c97d1276c	helm waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	86338215b7	ability to create different waiters ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	cb6d48e6ae	status wait ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4dd6e19b1d	provide path for creating new legacy waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	2cb999d72b	go fmt ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	c3eeab67f9	merge ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4b59583670	delete wait and get completed phase ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Jiasheng Zhu	f5d488122b	fix: check group for resource info match ... Closes: #13582 Signed-off-by: Jiasheng Zhu <gnehsaijuhz@hotmail.com>	2 years ago
Austin Abro	db90b17484	unknown status ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4dbdd7ce10	wait for delete working ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	9b63459bec	save state while I change up tests ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	265442c5eb	simplify things ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	28a9183ee3	context ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	b337790c10	paused as ready ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	e18f22071d	paused as ready now working ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	22af71f125	comments ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	7b896df4d1	option to wait for jobs ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	a6e5466942	refactor test ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	807cc925f5	refactor test ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	947425ee64	refactor new ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	aacaa08be2	only emebed waiter ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	859ff9b548	change structure of client ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	ad1f1c02ef	cleanup test ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Matt Farina	2236294119	Updating to helm.sh/helm/v4 ... Since Helm is going through breaking changes with Helm v4, the version path to Helm needs to be updated. Signed-off-by: Matt Farina <matt.farina@suse.com>	2 years ago
Austin Abro	4564b8f712	make a working test ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	4c1758143f	basic design up and balling ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	a61a35240e	understand it better ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	6f7ac066ae	extending factory to enable getting a watcher ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Austin Abro	2f44164fc6	Merge branch 'refactor-wait' of github.com:AustinAbro321/helm into refactor-wait	2 years ago
Matt Farina	5727f56a96	Update to Go 1.23 ... Multiple changes were made to pass linting. Some Go built-in names are being used for variables (e.g., min). This happens in the Go source itself including the Go standard library and is not always a bad practice. To handle allowing some built-in names to be used the linter config is updated to allow (via opt-in) some names to pass. This allows us to still check for re-use of Go built-in names and opt-in to any new uses. There were also several cases where a value was checked for nil before checking its length when this is already handled by len() or the types default value. These were cleaned up. The license validation was updated because it was checking everything in the .git directory including all remote content that was local. The previous vendor directory was from a time prior to Go modules when Helm handled dependencies differently. It was no longer needed. Signed-off-by: Matt Farina <matt.farina@suse.com>	2 years ago
Austin Abro	41700f0248	WIP ... Signed-off-by: Austin Abro <AustinAbro321@gmail.com>	2 years ago
Justen Stall	7df69020d8	revert duplicate slice conditions ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	2 years ago
Justen Stall	b0944e8e7e	fix incorrect error return ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	2 years ago
Justen Stall	63cf42a843	fix: replace "github.com/pkg/errors" with stdlib "errors" package ... Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>	2 years ago
KISHOREKUMAR THUDI	2c8cfaea41	Replacing NewSimpleClientSet to NewClientSet due to deprecation ... Signed-off-by: KISHOREKUMAR THUDI <kishorekumarthudi@kishore.myfiosgateway.com>	2 years ago
Alex Johnson	9fd943b481	Add tests to `helm/pkg/kube/client_test.go` to cover `wait.go` ... Signed-off-by: Alex Johnson <alex.kattathra.johnson@gmail.com>	2 years ago
Robert Sirchia	7e6b34d7dd	removing duplicate empty test ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Robert Sirchia	16a4e37f20	fixing unit test as per Matt ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Robert Sirchia	a205af755e	adding more unit test ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Robert Sirchia	999b85145a	adding test coverage for ready.go ... Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Matt Farina	8f59c8e807	Merge pull request #9713 from andreaskaris/issue9710 ... fix(helm): Retry Conflict error for createResource, deleteResource	2 years ago
Andreas Karis	79a1f2c801	fix(helm): Retry Conflict error for createResource, deleteResource ... kubernetes might at any time throw 409 Conflict Error codes. Clients are supposed to retry when this happens. As an example, see kubernetes/issues/67761 where such an issues might happen when the cluster manipulates a projects's ResourceQuotas. Catch such Conflict Errors on createResource and deleteResource and retry before giving up. Due to the more complex logic and focus on kubernetes/issues/67761, this patch purposefully omits possibly needed changes to updateResource and instead defers them to another patch if required in the future. Closes issue #9710 Signed-off-by: Andreas Karis <ak.karis@gmail.com>	2 years ago
Luis Davim	ab3c589809	chore: Make retryingRoundTripper type public ... Make retryingRoundTripper type public to allow being used in other projects fixes: #13052 Signed-off-by: Luis Davim <luis.davim@gmail.com>	2 years ago
Nathan Baulch	ef85fa7f2d	Grammar fixes ... Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2 years ago
Nathan Baulch	ff9dd262e3	Fix typos ... Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	2 years ago
Joe Julian	ff4877e696	Merge pull request #13224 from sttts/sttts-fix-apiext-registration ... kube/client: add to global client-go scheme in init func	2 years ago
Matt Farina	c261d0655c	Merge pull request #12876 from manno/sdk-ignore-missing-annotations ... Allow install, update action to adopt existing resources (sdk only)	2 years ago
Dr. Stefan Schimanski	b9bdeca93b	kube/client: add to global client-go scheme in init func ... Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>	2 years ago
Matt Farina	a753ee7f43	Merge pull request #12866 from robertsirc/Correcting-Linting-Errors ... Correcting linting errors	2 years ago
Matt Farina	2dea5bf335	Merge pull request #11790 from Nordix/waitRetry ... Add robustness to wait status checks	2 years ago
Mario Manno	a7856c0398	Add ability to adopt unmanaged resources ... Allow the SDK actions to adopt existing resources. This allows install and update to overwrite resources. If TakeOwnership is not set, adoption is only possible if they existing resources have the right labels (managed-by) and annotations (release-name, ...). Signed-off-by: Mario Manno <mmanno@suse.com>	2 years ago
Robert Sirchia	d58d7b3762	Fixing all the linting errors ... Cleaned up all the linting errors we are getting. Signed-off-by: Robert Sirchia <rsirchia@outlook.com>	2 years ago
Matt Farina	c042264a9d	Fix issues when verify generation readiness was merged ... CI, tests, and building failed after #10920 was merged. This change fixes the issues that were introduced. Signed-off-by: Matt Farina <matt.farina@suse.com>	3 years ago
Matt Farina	b299359f66	Merge pull request #10920 from muang0/readiness-generation-check ... Verify generation in readiness checks	3 years ago
Matt Farina	847369c184	Update to Go 1.21 for builds ... Noteis: 1. This moves golangci scanning to a GitHub action. This will enable inline pointers to issues in the PR where linting fails. 2. Go 1.21 is specified in the go.mod because Kubernetes libs require it. 3. The lint issues were removed. Some were fixed while others were handled by skipping linting or using _ as an argument. Many of these can be refactored later for better cleanup. Signed-off-by: Matt Farina <matt.farina@suse.com>	3 years ago
Serge Logvinov	b0d163771e	feat: print failed hook name ... Add more details when a hook fails. Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>	3 years ago
Joe Julian	eb4edc96c5	Merge pull request #10965 from mattfarina/factory-comment ... Adding details on the Factory interface	3 years ago
Joe Julian	02ef594a43	Merge pull request #11591 from ruanxin/use_wrapped_error ... Use wrapped error so that ErrNoObjectsVisited can be compared	3 years ago
Stefan McShane	1a3e9a95dd	addressing comment ... Signed-off-by: Stefan McShane <stefanmcshane@users.noreply.github.com>	3 years ago
MichaelMorris	d2cf8c66f1	Updated for review comments ... Signed-off-by: MichaelMorris <michael.morris@est.tech>	3 years ago
MichaelMorris	fc74964f8a	Add robustness to wait status checks ... When a user specifies --wait for an install or upgrade this commit will enable the user to specifiy a number of retries to attepmt if a status check fails Errors including a HTTP status code < 500 will not be retried Signed-off-by: MichaelMorris <michael.morris@est.tech>	3 years ago
Joe Julian	99e1dce8c8	Merge pull request #9950 from jeffrosenberg/error-on-failed-jobs-9285 ... Throw an error from jobReady() if the job exceeds its BackoffLimit	3 years ago
Joe Julian	dcd54d59e6	Merge branch 'main' into readiness-generation-check ... Signed-off-by: Joe Julian <me@joejulian.name>	3 years ago
Matt Farina	8b19f8df0e	Adding details on the Factory interface ... This covers both the property and the minimal copy of the Factory interface. It also notes that this interface is not covered by the Helm backwards compatibility and why. Signed-off-by: Matt Farina <matt.farina@suse.com> Signed-off-by: Joe Julian <me@joejulian.name>	3 years ago
Matt Farina	b81428919b	Merge pull request #12015 from yann-soubeyrand/bump-k8s-io-deps ... chore: bump k8s.io dependencies to v0.27.1	3 years ago
Matt Farina	3b74c13768	Merge pull request #11479 from MichaelMorrisEst/cascade ... Add option to support foreground cascade deletion	3 years ago
Tom Wieczorek	b9361407a3	Bump k8s.io deps from v0.26.0 to v0.27.0 ... Adapt to changes in 1.27 client libs: * The OpenAPIGetter method is now private, but the Validator method does what is needed instead. * The function wait.PollImmediateUntil is deprecated. Switch to the recommended new function wait.PollUntilContextCancel. Related dependency changes: change k8s.io/kube-openapi v0.0.0-20221012153701-172d655c2280 => v0.0.0-20230308215209-15aac26d736a And some transitive version changes: add github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 add github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 remove github.com/elazarl/goproxy v0.0.0-20180725130230-947c36da3153 github.com/go-errors/errors v1.0.1 => v1.4.2 github.com/go-openapi/jsonpointer v0.19.5 => v0.19.6 github.com/go-openapi/jsonreference v0.20.0 => v0.20.1 github.com/go-openapi/swag v0.19.14 => v0.22.3 github.com/golang/protobuf v1.5.2 => v1.5.3 github.com/mailru/easyjson v0.7.6 => v0.7.7 github.com/onsi/ginkgo/v2 v2.4.0 => v2.9.1 github.com/onsi/gomega v1.23.0 => v1.27.4 github.com/rogpeppe/go-internal v1.9.0 => v1.10.0 golang.org/x/mod v0.8.0 => v0.9.0 golang.org/x/net v0.7.0 => v0.8.0 golang.org/x/term v0.5.0 => v0.6.0 golang.org/x/tools v0.6.0 => v0.7.0 gotest.tools/v3 v3.0.3 => v3.4.0 sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 => v0.0.0-20221116044647-bc3834ca7abd sigs.k8s.io/kustomize/api v0.12.1 => v0.13.2 sigs.k8s.io/kustomize/kyaml v0.13.9 => v0.14.1 Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>	3 years ago
Matt Farina	cf3d2531a8	Merge pull request #11898 from willzgli/waitbatchPerform ... Fix goroutine leak in perform	3 years ago
Aman Nijhawan	eea2f27bab	Fixes Readiness Check for statefulsets using partitioned rolling update. (#11774) ... * Fixes Readiness Check for statefulsets using partitioned rolling update. Fixes #11773 This change updates readiness check in ready.go to correctly account for statefulsets that are utilizing a partitioned upgrade. These statefulsets only upgrade a subset of the managed pods with each call to helm upgrade. This causes the upgrade to legitimately hit the condition where sts.status.CurrentRevision != sts.Status.UpdateRevision which causes helm to mark the upgrade has failed when in fact it is successful. This change fixes that behavior to only check when partition is unspecified or 0. Signed-off-by: Aman Nijhawan <anijhawan@yugabyte.com> * Adding a unit test to verify that partitioned rolling upgrade for a statefulset works. Signed-off-by: Aman Nijhawan <anijhawan@yugabyte.com> --------- Signed-off-by: Aman Nijhawan <anijhawan@yugabyte.com> Co-authored-by: Aman Nijhawan <anijhawan@yugabyte.com>	3 years ago
Matt Farina	4e7e939f19	Updating the Go version in go.mod ... At this time both Go 1.19 and 1.20 are supported. The version specified in the go.mod file is the minimum version we expect Helm to be compiled against. This is the oldest supported version to support environments where others compile Helm. The Helm project is using Go 1.20 to build Helm itself. Updating to Go 1.19 also includes dealing with io/ioutil deprecation and some additional linting issues around staticcheck. All the staticcheck issues were in test files so linting was skipped for those. Signed-off-by: Matt Farina <matt.farina@suse.com>	3 years ago
Matt Farina	50c22ed7f9	Bump the Go version ... Needed to gofmt source to meet changes in style Signed-off-by: Matt Farina <matt.farina@suse.com>	3 years ago
willzgli	11150cdcc6	Fix goroutine leak in perform ... Signed-off-by: willzgli <willzgli@tencent.com>	3 years ago
muang0	141fa4a037	Update pkg/kube/ready.go ... more readable debug log fmt (i64) Co-authored-by: Bjorn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: muang0 <joden1995@gmail.com>	4 years ago
muang0	4cb62d1262	Update pkg/kube/ready.go ... more readable debug log fmt (i64) Co-authored-by: Bjorn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: muang0 <joden1995@gmail.com>	4 years ago
muang0	dbb21fcf44	Update pkg/kube/ready.go ... more readable debug log fmt (i64) Co-authored-by: Bjorn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: muang0 <joden1995@gmail.com>	4 years ago
muang0	fcc03324a6	Update pkg/kube/ready.go ... more readable debug log fmt (i64) Co-authored-by: Bjorn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: muang0 <joden1995@gmail.com>	4 years ago
muang0	a1a1aafb7d	Update pkg/kube/ready.go ... more readable debug log fmt (i64) Co-authored-by: Bjorn Svensson <bjorn.a.svensson@est.tech> Signed-off-by: muang0 <joden1995@gmail.com>	4 years ago
cpanato	006bc0f39d	update k8s registry domain ... Signed-off-by: cpanato <ctadeu@gmail.com>	4 years ago
MichaelMorris	830d4a9ee9	Add option to support cascade deletion options ... Add --cascade=<background|foreground|orphan> option to helm uninstall Current behaviour is hardcoded to background Addresses issue: https://github.com/helm/helm/issues/10586 Signed-off-by: MichaelMorris <michael.morris@est.tech>	4 years ago
Matt Farina	36e18fa6e1	Fix improper use of Table request/response to k8s API ... Fixes #11712 A change was made that when validation was turned off the Kubernetes packages were building objects as a Table type. This was done for display purposes. When details about the objects was going to be printed as part of #10912. This broke rollback, and possibly other functionality, as a Table type was returned in some cases that needed the regular object. This caused things to break silently. The fix involved adding in a new Function (and interface) to query for tables instead of the objects themselves. There was not a clean way to add it to the existing function that covered all cases. A second problem was noticed along the way. When data was output via status as YAML or JSON it was in the form of a table rather than the objects themselves. This did not reflect expectations and did not match the functionality in kubectl. The code was updated to return a table when that was presented and the objects when they are being output for YAML or JSON. The API also supports this handling to SDK users can replicate this functionality. API changes made here were never released. The functions were developed for this release of Helm and only ever appeared in an RC. In this case, they can be changed. Signed-off-by: Matt Farina <matt.farina@suse.com>	4 years ago
Matt Farina	774c6ce703	Merge pull request #11439 from phoenixsqf/main ... use intstr.GetScaledValueFromIntOrPercent instead of the deprecated	4 years ago
Xin Ruan	a2b98281a1	Use errors.Is to compare ... Signed-off-by: Xin Ruan <xin.ruan@sap.com>	4 years ago
Soujanya Mangipudi	038cc4a0ca	Merge branch 'main' into main ... Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>	4 years ago
Xin Ruan	f01486a0ef	Use wrapped error so that ErrNoObjectsVisited can be compared after return. ... Signed-off-by: Xin Ruan <xin.ruan@sap.com>	4 years ago
Martin Hickey	3974136b6e	Merge pull request #11426 from cenkalti/leader-changed ... Fix handling of "leader changed" errors	4 years ago
Andrew Block	269dd247d0	Merge pull request #11300 from porridge/better-logging ... During deletion, explicitly log already deleted resource.	4 years ago
Qifan Shen	9d59d92abb	use intstr.GetScaledValueFromIntOrPercent instead of the deprecated ... Signed-off-by: Qifan Shen <sqfphoenix@163.com>	4 years ago
Cenk Alti	d32c623699	Revert "Tolerate temporary errors from etcdserver" ... This reverts commit ebc79fa807. Signed-off-by: Cenk Alti <cenkalti@gmail.com>	4 years ago
Davanum Srinivas	ebc79fa807	Tolerate temporary errors from etcdserver ... There are cases when the etcdserver is temporarily unavailable and the errors that we get back from kube-apiserver reflect that error. It looks like we bail out immediately when these errors happen currently. We should retry until timeout is reached when this sort of errors happen. Signed-off-by: Davanum Srinivas <davanum@gmail.com>	4 years ago
Soujanya Mangipudi	ffa19a4b5d	Addressing review comments - move printing code out of client.go ... Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> fix circleci tests Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> fix formatting errors Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> fix tests Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> fix tests Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> fix gofmt issue Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>	4 years ago
Soujanya Mangipudi	20e3577543	Addressing review comments: ... Extend Interface with new InterfaceResources to avoid breaking changes Move change to staus command behind --show-resources flag Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>	4 years ago
Soujanya Mangipudi	9d5be803bc	feat(helm): Supporting helm3 to show up resource names that were deployed as part of release in helm status command ... Creating a new PR based on this existing stale PR https://github.com/helm/helm/pull/7728 Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com> # Conflicts: # go.sum	4 years ago
Marcin Owsiany	b7c35d2a0f	During deletion, explicitly log already deleted resource name. ... Unfortunately errors from the API server do not always (do they ever?) contain the name of the resource in question. Deletions for multiple resources are processed concurrently, so in a resulting log, a preceding "Starting delete" line might be for a different object. Signed-off-by: Marcin Owsiany <porridge@redhat.com>	4 years ago
James Oden	d008340891	ready checker- comment update ... Signed-off-by: James Oden <james.oden.dev@gmail.com>	4 years ago
James Oden	4f99c86914	ready checker- remove duplicate statefulset generational check ... Signed-off-by: James Oden <james.oden.dev@gmail.com>	4 years ago
James Oden	f067073e23	Merge branch 'main' into readiness-generation-check	4 years ago
Dominic Evans	7c74f1dd02	fix: improve logging & safety of statefulSetReady ... Confirm that the current and updated revision numbers also match as part of the readiness check. Add coverage for readiness scenarios where StatefulSet status does not reflect the most recent generation of the StatefulSet yet. Also add additional logging around the sts transitions from non-ready to ready. Fixes: #10163 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>	4 years ago
Andrew Seigner	bd7c97f786	Bump k8s packages from 0.23.6 to 0.24.0 ... This required modifying the `kube.Factory` interface to conform to changes in k8s' `cmdutil.Factory` interface: fe3772890f Signed-off-by: Andrew Seigner <andrew@sig.gy>	4 years ago
James Oden	d94c5094f6	Verify generation in readiness checks ... Signed-off-by: James Oden <james.oden.dev@gmail.com>	4 years ago
Martin Hickey	292368a64d	Merge pull request #10209 from yxxhero/fix_sa_issue ... Add more debug msg when helm upgrade	5 years ago
yxxhero	f82896b0b5	add more debug msg when helm upgrade ... Signed-off-by: yxxhero <aiopsclub@163.com>	5 years ago
Matthew Fisher	67f92d63fa	Merge pull request #9640 from wangchenglong01/wangchl01 ... Add error check to avoid panic	5 years ago
Bhavin Gandhi	c3310bb724	fix(pkg/kube): statefulSetReady: handle partition cases correctly ... The partition value can be greater than number of replicas, in that case no pods are rolled out. The expectedReplicas becomes a negative number. https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#partitions In the cases where the update does not change anything in the pod template, the updatedReplicas value from StatefulSet status remains unchanged. Such updates can still set some partition value, and UpdatedReplicas is always greater than expectedReplicas. Basically, the StatefulSet is ready / rolled-out. In both the above scenarios, providing `--wait` flag causes it to timeout waiting indefinitely. Because updatedReplicas can never be negative, or be equal to the expectedReplicas for the second case. This commit handles both the scenarios by checking if UpdatedReplicas is smaller than expectedReplicas. If it is, then the StatefulSet is not ready yet. Based on the code from kubectl rollout: a450ebd59c/pkg/polymorphichelpers/rollout_status.go (L138-L141) Closes #8674 Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>	5 years ago
Jeff Rosenberg	b13f3a13d4	Merge branch 'main' into error-on-failed-jobs-9285	5 years ago
Matt Farina	accf82ba1c	Merge pull request #9180 from Moser-ss/feature-handle-SIGINT ... Handle SIGTERMs during helm upgrade and helm install	5 years ago
Mike Ng	75fe8883cc	Rename newly introduced interface to InterfaceExt ... Signed-off-by: Mike Ng <ming@redhat.com>	5 years ago
Mike Ng	d51a61f9ab	Introduce a new interface for WaitForDelete() to avoid breaking backwards compatibility ... Signed-off-by: Mike Ng <ming@redhat.com>	5 years ago
Mike Ng	655bdcd2fd	feat: add optional boolean '--wait' flag to 'uninstall' command. ... If set, 'uninstall' command will wait until all the resources are deleted before returning. It will wait for as long as --timeout closes #2378 Signed-off-by: Mike Ng <ming@redhat.com>	5 years ago
lsowen	249d1b5fb9	Fix SIGSEGV when job.Spec.Completions is nil ... Signed-off-by: lsowen <logan@s1network.com>	5 years ago
Stephane Moser	4bc901c95f	Resolve PR comments ... Fix typos Remove condition arround time.Sleep Because a negative or zero duration causes Sleep to return immediately. Signed-off-by: Stephane Moser <moser.sts@gmail.com>	5 years ago
Rosenberg, Jeff	cd04e3f418	Throw an error from jobReady() if the job exceeds its BackoffLimit ... Closes #9285 Signed-off-by: Rosenberg, Jeff <jeff.rosenberg@icfnext.com>	5 years ago