7 Commits (main)

Author	SHA1	Message	Date
George Jenkins	ca6681ca55	chore: Fix independent-merge lint issues ... Signed-off-by: George Jenkins <gvjenkins@gmail.com>	1 month ago
Benoit Tigeot	11e2010aeb	refactor: remove per-file decompression size limit (#31748) ... * refactor: remove per-file decompression size limit Remove MaxDecompressedFileSize as it's no longer necessary after migrating to a maintained JSON schema library (santhosh-tekuri/jsonschema/v6). The original limit was added to protect against vulnerabilities in an unmaintained library. The total decompressed chart size limit (MaxDecompressedChartSize) remains to protect against other attack vectors. Partially resolves #30738 Related: - https://github.com/helm/helm/pull/30743 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * fix: deprecate MaxDecompressedFileSize instead of removing As Matt suggested we should keep the variable until v5 as it can be used because it is public. Related: - https://github.com/helm/helm/pull/31748#discussion_r2738518696 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * fix: enforce aggregate size budget on directory loading Directory-based chart loading (`LoadDir`) used unbounded `os.ReadFile` calls with no total size check. Archive loading already enforces `MaxDecompressedChartSize` via a remaining-byte budget but directory loading did not, leaving local charts and `file://` dependencies as an unbounded memory path. Add `ReadFileWithBudget` in the archive package and use it in both v2 and v3 directory loaders so they track the same aggregate budget. Ref: https://github.com/helm/helm/pull/31748#issuecomment-4138927643 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * fix: cap directory budget reads with LimitReader Use `os.Open` + `io.LimitReader` instead of `os.ReadFile` in `ReadFileWithBudget` so a file that grows between stat and read cannot allocate unbounded memory. Also fix `MaxDecompressedFileSize` doc comment to reflect it is unused/deprecated, add nil guard on remaining, and check `os.Stat` errors in tests. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * test: add v3 directory loader budget test Mirror the v2 `TestLoadDirExceedsBudget` test for the v3 loader to prevent budget enforcement regressions in either path. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * refactor(loader): make read budget configurable Follow recommendations from https://github.com/helm/helm/pull/31748#discussion_r3058581419 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * fix(loader): export BudgetedReader for cross-package use Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * fix(loader): rename max param to avoid shadowing built-in Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> --------- Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>	1 month ago
Matthieu MOREL	1d4665e54c	chore(pkg): refactor: convert tests to testify assert/require part 20 ... #### Description refactor: convert tests to testify assert/require in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 months ago
Matthieu MOREL	6d1490ed1e	fix(pkg): errorlint linter ... #### Description errorlint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	8 months ago
Mads Jensen	a490bb3c20	Use errors.Is to check for io.EOF and gzip.ErrHeader ... In GoLang, using the == operator to check for a certain error will not unwrap the error chain, and therefore may hide the problem. Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>	10 months ago
Matt Farina	ca8eae9361	Reproducible chart archive builds ... Building the same chart into an archive multiple times will have the same sha256 hash. Perviously, the time in the headers for a file was time.Now() which changed each time. The time is now collected from the operating system when the file is loaded and this time is used. Fixes: #3612 Signed-off-by: Matt Farina <matt.farina@suse.com>	11 months ago
Matt Farina	8dc7c57f50	Update the action interfaces for chart apiversions ... This change is about handling the interfaces to public functions for different chart apiVersions. The internals are still focused on v2. This enables v3 to be layered in layer. Signed-off-by: Matt Farina <matt.farina@suse.com>	1 year ago