9 Commits (main)

Author	SHA1	Message	Date
Matthieu MOREL	f34ad6c337	chore: fix several checks issues from testifylint ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 week ago
Matthieu MOREL	07259ecc86	chore: fix several checks issues from gocritic ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 weeks ago
George Jenkins	3ce02c585a	refactor(internal): convert tests to testify assert/require ... Convert internal/fileutil, internal/tlsutil, and internal/resolver test files from native Go testing patterns (t.Errorf, t.Fatalf, t.Error, t.Fatal) to github.com/stretchr/testify equivalents (assert.X, require.X). Signed-off-by: George Jenkins <gvjenkins@gmail.com>	4 weeks ago
Orgad Shaneh	76eb37c01a	fix(downloader): safely handle concurrent file writes on Windows ... When multiple processes try to download the same chart version concurrently (e.g., via Terraform), they can race to write the destination file. On Windows, this results in 'Access Denied' errors because the file cannot be renamed while another process has a handle to the destination. This commit introduces 'PlatformAtomicWriteFile' to the fileutil package. On Unix-like systems, it simply delegates to AtomicWriteFile, maintaining existing behavior. On Windows, it coordinates writes using a lock file (.lock). It acquires the lock, then performs the atomic write. Crucially, this implementation ensures that existing files are overwritten (rather than skipped). This ensures that if a chart is republished with the same version, the local cache is correctly updated, preventing stale data issues. Fixes #31633 Signed-off-by: Orgad Shaneh <orgad.shaneh@audiocodes.com>	5 months ago
Mile Druzijanic	934b4550d9	improve fileutil test coverage ... Signed-off-by: Mile Druzijanic <zedsprogramms@gmail.com>	10 months ago
Matt Farina	2236294119	Updating to helm.sh/helm/v4 ... Since Helm is going through breaking changes with Helm v4, the version path to Helm needs to be updated. Signed-off-by: Matt Farina <matt.farina@suse.com>	2 years ago
Matt Farina	4e7e939f19	Updating the Go version in go.mod ... At this time both Go 1.19 and 1.20 are supported. The version specified in the go.mod file is the minimum version we expect Helm to be compiled against. This is the oldest supported version to support environments where others compile Helm. The Helm project is using Go 1.20 to build Helm itself. Updating to Go 1.19 also includes dealing with io/ioutil deprecation and some additional linting issues around staticcheck. All the staticcheck issues were in test files so linting was skipped for those. Signed-off-by: Matt Farina <matt.farina@suse.com>	3 years ago
Eng Zer Jun	2e3e22a003	test: use `T.TempDir` to create temporary test directory ... The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>	4 years ago
Raphaël	984d2ac767	fix: write index.yaml file atomically (#7954) ... * fix: write index.yaml file atomically This refactors the already-existing `AtomicWriteFile` utility to a central location and uses it to write index files atomically. This is done to avoid having half-written index files break client requests. Drive-bys: - Add test for AtomicWriteFile. - Add test IndexFile.WriteFile. Signed-off-by: rabadin <rvbadin@gmail.com> * Review fix: use RenameWithFallback instead of os.Rename Signed-off-by: rabadin <rvbadin@gmail.com> Co-authored-by: rabadin <rvbadin@gmail.com>	6 years ago