mirror of https://github.com/helm/helm
fix(helm): Tunnel closing already closed channel (#3157)
k8s client-go closes the ready channel that's passed in (see https://github.com/kubernetes/client-go/blob/master/tools/portforward/portforward.go#L171) This means that Tunnel's Close will always panic, as the client-go library will have closed then channel. This isn't reproducible unless helm.Client is externally, as the helm cli runner doesn't actually invoke Close.pull/3185/head
parent
31ea2018fa
commit
fe3eeaf39d
Loading…
Reference in new issue