Grammar fixes

Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
pull/13301/head
Nathan Baulch 3 weeks ago
parent ff9dd262e3
commit ef85fa7f2d
No known key found for this signature in database

@ -274,7 +274,7 @@ Like any good open source project, we use Pull Requests (PRs) to track code chan
#### Documentation PRs #### Documentation PRs
Documentation PRs should be made on the docs repo: <https://github.com/helm/helm-www>. Keeping Helm's documentation up to date is highly desirable, and it is recommend all user facing changes. Accurate and helpful documentation is critical for effectively communicating Helm's behavior to a wide audience. Documentation PRs should be made on the docs repo: <https://github.com/helm/helm-www>. Keeping Helm's documentation up to date is highly desirable, and is recommended for all user facing changes. Accurate and helpful documentation is critical for effectively communicating Helm's behavior to a wide audience.
Small, ad-hoc changes/PRs to Helm which introduce user facing changes, which would benefit from documentation changes, should apply the `docs needed` label. Larger changes associated with a HIP should track docs via that HIP. The `docs needed` label doesn't block PRs, and maintainers/PR reviewers should apply discretion judging in whether the `docs needed` label should be applied. Small, ad-hoc changes/PRs to Helm which introduce user facing changes, which would benefit from documentation changes, should apply the `docs needed` label. Larger changes associated with a HIP should track docs via that HIP. The `docs needed` label doesn't block PRs, and maintainers/PR reviewers should apply discretion judging in whether the `docs needed` label should be applied.

@ -286,7 +286,7 @@ func addPluginCommands(plugin *plugin.Plugin, baseCmd *cobra.Command, cmds *plug
f.BoolP(longs[i], shorts[i], false, "") f.BoolP(longs[i], shorts[i], false, "")
} else { } else {
// Create a long flag with the same name as the short flag. // Create a long flag with the same name as the short flag.
// Not a perfect solution, but its better than ignoring the extra short flags. // Not a perfect solution, but it's better than ignoring the extra short flags.
f.BoolP(shorts[i], shorts[i], false, "") f.BoolP(shorts[i], shorts[i], false, "")
} }
} }

@ -139,7 +139,7 @@ func (o *searchRepoOptions) setupSearchedVersion() {
if o.devel { // search for releases and prereleases (alpha, beta, and release candidate releases). if o.devel { // search for releases and prereleases (alpha, beta, and release candidate releases).
debug("setting version to >0.0.0-0") debug("setting version to >0.0.0-0")
o.version = ">0.0.0-0" o.version = ">0.0.0-0"
} else { // search only for stable releases, prerelease versions will be skip } else { // search only for stable releases, prerelease versions will be skipped
debug("setting version to >0.0.0") debug("setting version to >0.0.0")
o.version = ">0.0.0" o.version = ">0.0.0"
} }

@ -172,7 +172,7 @@ func (r *Resolver) Resolve(reqs []*chart.Dependency, repoNames map[string]string
Repository: d.Repository, Repository: d.Repository,
Version: version, Version: version,
} }
// The version are already sorted and hence the first one to satisfy the constraint is used // The versions are already sorted and hence the first one to satisfy the constraint is used
for _, ver := range vs { for _, ver := range vs {
v, err := semver.NewVersion(ver.Version) v, err := semver.NewVersion(ver.Version)
// OCI does not need URLs // OCI does not need URLs

@ -260,7 +260,7 @@ func fixLongPath(path string) string {
// minus 12)." Since MAX_PATH is 260, 260 - 12 = 248. // minus 12)." Since MAX_PATH is 260, 260 - 12 = 248.
// //
// The MSDN docs appear to say that a normal path that is 248 bytes long // The MSDN docs appear to say that a normal path that is 248 bytes long
// will work; empirically the path must be less then 248 bytes long. // will work; empirically the path must be less than 248 bytes long.
if len(path) < 248 { if len(path) < 248 {
// Don't fix. (This is how Go 1.7 and earlier worked, // Don't fix. (This is how Go 1.7 and earlier worked,
// not automatically generating the \\?\ form) // not automatically generating the \\?\ form)

@ -65,7 +65,7 @@ func CertPoolFromFile(filename string) (*x509.CertPool, error) {
return cp, nil return cp, nil
} }
// CertFromFilePair returns an tls.Certificate containing the // CertFromFilePair returns a tls.Certificate containing the
// certificates public/private key pair from a pair of given PEM-encoded files. // certificates public/private key pair from a pair of given PEM-encoded files.
// Returns an error if the file could not be read, a certificate could not // Returns an error if the file could not be read, a certificate could not
// be parsed, or if the file does not contain any certificates // be parsed, or if the file does not contain any certificates

@ -631,7 +631,7 @@ func createOrOpenFile(filename string, append bool) (*os.File, error) {
return os.Create(filename) return os.Create(filename)
} }
// check if the directory exists to create file. creates if don't exist // check if the directory exists to create file. creates if doesn't exist
func ensureDirectoryForFile(file string) error { func ensureDirectoryForFile(file string) error {
baseDir := path.Dir(file) baseDir := path.Dir(file)
_, err := os.Stat(baseDir) _, err := os.Stat(baseDir)

@ -74,7 +74,7 @@ externalDatabase:
## Database host ## Database host
host: localhost host: localhost
## non-root Username for Wordpress Database ## non-root Username for WordPress Database
user: bn_wordpress user: bn_wordpress
## Database password ## Database password
@ -102,7 +102,7 @@ mariadb:
db: db:
name: bitnami_wordpress name: bitnami_wordpress
user: bn_wordpress user: bn_wordpress
## If the password is not specified, mariadb will generates a random password ## If the password is not specified, mariadb will generate a random password
## ##
# password: # password:
@ -165,7 +165,7 @@ readinessProbe:
successThreshold: 1 successThreshold: 1
## Configure the ingress resource that allows you to access the ## Configure the ingress resource that allows you to access the
## Wordpress installation. Set up the URL ## WordPress installation. Set up the URL
## ref: http://kubernetes.io/docs/user-guide/ingress/ ## ref: http://kubernetes.io/docs/user-guide/ingress/
## ##
ingress: ingress:

@ -101,7 +101,7 @@ func ensureArchive(name string, raw *os.File) error {
return nil return nil
} }
// isGZipApplication checks whether the achieve is of the application/x-gzip type. // isGZipApplication checks whether the archive is of the application/x-gzip type.
func isGZipApplication(data []byte) bool { func isGZipApplication(data []byte) bool {
sig := []byte("\x1F\x8B\x08") sig := []byte("\x1F\x8B\x08")
return bytes.HasPrefix(data, sig) return bytes.HasPrefix(data, sig)

@ -137,7 +137,7 @@ func processDependencyEnabled(c *chart.Chart, v map[string]interface{}, path str
// If any dependency is not a part of Chart.yaml // If any dependency is not a part of Chart.yaml
// then this should be added to chartDependencies. // then this should be added to chartDependencies.
// However, if the dependency is already specified in Chart.yaml // However, if the dependency is already specified in Chart.yaml
// we should not add it, as it would be anyways processed from Chart.yaml // we should not add it, as it would be processed from Chart.yaml anyway.
Loop: Loop:
for _, existing := range c.Dependencies() { for _, existing := range c.Dependencies() {

@ -73,7 +73,7 @@ func (o Format) Write(out io.Writer, w Writer) error {
} }
// ParseFormat takes a raw string and returns the matching Format. // ParseFormat takes a raw string and returns the matching Format.
// If the format does not exists, ErrInvalidFormatType is returned // If the format does not exist, ErrInvalidFormatType is returned
func ParseFormat(s string) (out Format, err error) { func ParseFormat(s string) (out Format, err error) {
switch s { switch s {
case Table.String(): case Table.String():

@ -34,7 +34,7 @@ const (
DataHomeEnvVar = "HELM_DATA_HOME" DataHomeEnvVar = "HELM_DATA_HOME"
) )
// lazypath is an lazy-loaded path buffer for the XDG base directory specification. // lazypath is a lazy-loaded path buffer for the XDG base directory specification.
type lazypath string type lazypath string
func (l lazypath) path(helmEnvVar, xdgEnvVar string, defaultFn func() string, elem ...string) string { func (l lazypath) path(helmEnvVar, xdgEnvVar string, defaultFn func() string, elem ...string) string {

@ -26,7 +26,7 @@ The formatting rules are as follows:
- Parsing is line-by-line - Parsing is line-by-line
- Empty lines are ignored - Empty lines are ignored
- Lines the begin with # (comments) will be ignored - Lines that begin with # (comments) will be ignored
- Leading and trailing spaces are always ignored - Leading and trailing spaces are always ignored
- Inline comments are NOT supported ('foo* # Any foo' does not contain a comment) - Inline comments are NOT supported ('foo* # Any foo' does not contain a comment)
- There is no support for multi-line patterns - There is no support for multi-line patterns

@ -634,7 +634,7 @@ func createPatch(target *resource.Info, current runtime.Object) ([]byte, types.P
// Get a versioned object // Get a versioned object
versionedObject := AsVersioned(target) versionedObject := AsVersioned(target)
// Unstructured objects, such as CRDs, may not have an not registered error // Unstructured objects, such as CRDs, may not have a not registered error
// returned from ConvertToVersion. Anything that's unstructured should // returned from ConvertToVersion. Anything that's unstructured should
// use the jsonpatch.CreateMergePatch. Strategic Merge Patch is not supported // use the jsonpatch.CreateMergePatch. Strategic Merge Patch is not supported
// on objects like CRDs. // on objects like CRDs.

@ -65,8 +65,7 @@ func GetTagMatchingVersionOrConstraint(tags []string, versionString string) (str
// If string is empty, set wildcard constraint // If string is empty, set wildcard constraint
constraint, _ = semver.NewConstraint("*") constraint, _ = semver.NewConstraint("*")
} else { } else {
// when customer input exact version, check whether have exact match // when customer inputs specific version, check whether there's an exact match first
// one first
for _, v := range tags { for _, v := range tags {
if versionString == v { if versionString == v {
return v, nil return v, nil

@ -31,13 +31,13 @@ const (
StatusSuperseded Status = "superseded" StatusSuperseded Status = "superseded"
// StatusFailed indicates that the release was not successfully deployed. // StatusFailed indicates that the release was not successfully deployed.
StatusFailed Status = "failed" StatusFailed Status = "failed"
// StatusUninstalling indicates that a uninstall operation is underway. // StatusUninstalling indicates that an uninstall operation is underway.
StatusUninstalling Status = "uninstalling" StatusUninstalling Status = "uninstalling"
// StatusPendingInstall indicates that an install operation is underway. // StatusPendingInstall indicates that an install operation is underway.
StatusPendingInstall Status = "pending-install" StatusPendingInstall Status = "pending-install"
// StatusPendingUpgrade indicates that an upgrade operation is underway. // StatusPendingUpgrade indicates that an upgrade operation is underway.
StatusPendingUpgrade Status = "pending-upgrade" StatusPendingUpgrade Status = "pending-upgrade"
// StatusPendingRollback indicates that an rollback operation is underway. // StatusPendingRollback indicates that a rollback operation is underway.
StatusPendingRollback Status = "pending-rollback" StatusPendingRollback Status = "pending-rollback"
) )

@ -200,7 +200,7 @@ func (i IndexFile) Get(name, version string) (*ChartVersion, error) {
} }
} }
// when customer input exact version, check whether have exact match one first // when customer inputs specific version, check whether there's an exact match first
if len(version) != 0 { if len(version) != 0 {
for _, ver := range vs { for _, ver := range vs {
if version == ver.Version { if version == ver.Version {

@ -120,7 +120,7 @@ func (mock *MockConfigMapsInterface) Get(_ context.Context, name string, _ metav
return object, nil return object, nil
} }
// List returns the a of ConfigMaps. // List returns all ConfigMaps.
func (mock *MockConfigMapsInterface) List(_ context.Context, opts metav1.ListOptions) (*v1.ConfigMapList, error) { func (mock *MockConfigMapsInterface) List(_ context.Context, opts metav1.ListOptions) (*v1.ConfigMapList, error) {
var list v1.ConfigMapList var list v1.ConfigMapList
@ -206,7 +206,7 @@ func (mock *MockSecretsInterface) Get(_ context.Context, name string, _ metav1.G
return object, nil return object, nil
} }
// List returns the a of Secret. // List returns all Secrets.
func (mock *MockSecretsInterface) List(_ context.Context, opts metav1.ListOptions) (*v1.SecretList, error) { func (mock *MockSecretsInterface) List(_ context.Context, opts metav1.ListOptions) (*v1.SecretList, error) {
var list v1.SecretList var list v1.SecretList

Loading…
Cancel
Save