msb-public
/
helm
mirror of https://github.com/helm/helm
1
0
Code Issues Projects Releases Wiki Activity

fix(CONTRIBUTING): added not about who merges a PR

Browse Source 
A piece of folk knowledge got lost somewhere along the way: Core
contributors should merge their own PRs.
pull/2676/head
Matt Butcher 7 years ago
parent 0f8abb21a8
commit df13268e0b
No known key found for this signature in database
GPG Key ID: DCD5F5E5EF32C345
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File

4
CONTRIBUTING.md
Unescape View File

@ -143,6 +143,10 @@ Like any good open source project, we use Pull Requests to track code changes
- PRs should stay open until merged or if they have not been active for more than 30 days. - PRs should stay open until merged or if they have not been active for more than 30 days.
This will help keep the PR queue to a manageable size and reduce noise. Should the PR need This will help keep the PR queue to a manageable size and reduce noise. Should the PR need
to stay open (like in the case of a WIP), the `keep open` label can be added. to stay open (like in the case of a WIP), the `keep open` label can be added.
- If the owner of the PR is listed in `OWNERS`, that user **must** merge their own PRs
or explicitly request another OWNER do that for them.
- If the owner of a PR is _not_ listed in `OWNERS`, any core committer may
merge the PR once it is approved.
#### Documentation PRs #### Documentation PRs
Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the

Write Preview
Loading…
Cancel
Save