updated error logging to include list of allowed

Signed-off-by: Janit Sriganeshaelankovan <janits_27@hotmail.com>
pull/31062/head
Janit Sriganeshaelankovan 2 months ago
parent 2ce368eac7
commit dc16941075
No known key found for this signature in database
GPG Key ID: 82CD06AA03D8CEF1

@ -823,7 +823,7 @@ func validateChartName(name string) error {
return fmt.Errorf("chart name must be between 1 and %d characters", maxChartNameLength)
}
if !chartName.MatchString(name) {
return fmt.Errorf("chart name must match the regular expression %q", chartName.String())
return fmt.Errorf("chart name must use only lowercase letters or digits optionally with dash separators")
}
return nil
}

@ -125,7 +125,7 @@ func validateChartName(cf *chart.Metadata) error {
return fmt.Errorf("chart name must be between 1 and %d characters", maxChartNameLength)
}
if !chartName.MatchString(cf.Name) {
return fmt.Errorf("chart name must use only lowercase letters, digits, and dashes (no underscores, dots, or uppercase letters)")
return fmt.Errorf("chart name must use only lowercase letters or digits optionally with dash separators")
}
return nil
}

@ -78,7 +78,6 @@ func TestValidateChartName(t *testing.T) {
}
failTests := []*chart.Metadata{
{Name: ""}, // empty
{Name: "ChartName"}, // uppercase
{Name: "chart_name"}, // underscore
@ -90,15 +89,13 @@ func TestValidateChartName(t *testing.T) {
{Name: "chart/name"}, // forward slash
{Name: "chart\\name"}, // backslash
{Name: "chart name"}, // space
{Name: strings.Repeat("a", 251)}, // 241 chars — too long
{Name: strings.Repeat("a", 251)}, // 251 chars — too long
}
successTests := []*chart.Metadata{
{Name: "nginx"},
{Name: "nginx-lego"},
{Name: "aws-cluster-autoscaler"},
{Name: "abc123"},
{Name: "chartname"},
{Name: "chart-name"},
{Name: "chart-name-success"},
{Name: "chartname123"},
{Name: strings.Repeat("a", 250)},
}

Loading…
Cancel
Save