release: simplify hook sorting

Signed-off-by: Raushan Kumar <raus7n@gmail.com>

internal/release/v2/util/kind_sorter.go

@@ -144,16 +144,15 @@ func sortManifestsByKind(manifests []Manifest, ordering KindSortOrder) []Manifes
 func sortHooksByKind(hooks []*release.Hook, ordering KindSortOrder) []*release.Hook {
 	orderMap := buildKindOrderMap(ordering)
 
-	h := hooks
+	sort.SliceStable(hooks, func(i, j int) bool {
-	sort.SliceStable(h, func(i, j int) bool {
 		return lessByKind(
-			h[i].Kind,
+			hooks[i].Kind,
-			h[j].Kind,
+			hooks[j].Kind,
 			orderMap,
 		)
 	})
 
-	return h
+	return hooks
 }
 
 func lessByKind(

pkg/release/v1/util/kind_sorter.go

@@ -145,16 +145,15 @@ func sortManifestsByKind(manifests []Manifest, ordering KindSortOrder) []Manifes
 func sortHooksByKind(hooks []*release.Hook, ordering KindSortOrder) []*release.Hook {
 	orderMap := buildKindOrderMap(ordering)
 
-	h := hooks
+	sort.SliceStable(hooks, func(i, j int) bool {
-	sort.SliceStable(h, func(i, j int) bool {
 		return lessByKind(
-			h[i].Kind,
+			hooks[i].Kind,
-			h[j].Kind,
+			hooks[j].Kind,
 			orderMap,
 		)
 	})
 
-	return h
+	return hooks
 }
 
 func lessByKind(kindA string, kindB string, ordering map[string]int) bool {