mirror of https://github.com/helm/helm
Yarden Shoham
7 months ago
commit
d9c9fd8796
@ -1,58 +0,0 @@
|
|||||||
//go:build !windows
|
|
||||||
|
|
||||||
/*
|
|
||||||
Copyright The Helm Authors.
|
|
||||||
|
|
||||||
Licensed under the Apache License, Version 2.0 (the "License");
|
|
||||||
you may not use this file except in compliance with the License.
|
|
||||||
You may obtain a copy of the License at
|
|
||||||
|
|
||||||
http://www.apache.org/licenses/LICENSE-2.0
|
|
||||||
|
|
||||||
Unless required by applicable law or agreed to in writing, software
|
|
||||||
distributed under the License is distributed on an "AS IS" BASIS,
|
|
||||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
||||||
See the License for the specific language governing permissions and
|
|
||||||
limitations under the License.
|
|
||||||
*/
|
|
||||||
|
|
||||||
package main
|
|
||||||
|
|
||||||
import (
|
|
||||||
"os"
|
|
||||||
"os/user"
|
|
||||||
"path/filepath"
|
|
||||||
)
|
|
||||||
|
|
||||||
func checkPerms() {
|
|
||||||
// This function MUST NOT FAIL, as it is just a check for a common permissions problem.
|
|
||||||
// If for some reason the function hits a stopping condition, it may panic. But only if
|
|
||||||
// we can be sure that it is panicking because Helm cannot proceed.
|
|
||||||
|
|
||||||
kc := settings.KubeConfig
|
|
||||||
if kc == "" {
|
|
||||||
kc = os.Getenv("KUBECONFIG")
|
|
||||||
}
|
|
||||||
if kc == "" {
|
|
||||||
u, err := user.Current()
|
|
||||||
if err != nil {
|
|
||||||
// No idea where to find KubeConfig, so return silently. Many helm commands
|
|
||||||
// can proceed happily without a KUBECONFIG, so this is not a fatal error.
|
|
||||||
return
|
|
||||||
}
|
|
||||||
kc = filepath.Join(u.HomeDir, ".kube", "config")
|
|
||||||
}
|
|
||||||
fi, err := os.Stat(kc)
|
|
||||||
if err != nil {
|
|
||||||
// DO NOT error if no KubeConfig is found. Not all commands require one.
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
perm := fi.Mode().Perm()
|
|
||||||
if perm&0040 > 0 {
|
|
||||||
warning("Kubernetes configuration file is group-readable. This is insecure. Location: %s", kc)
|
|
||||||
}
|
|
||||||
if perm&0004 > 0 {
|
|
||||||
warning("Kubernetes configuration file is world-readable. This is insecure. Location: %s", kc)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@ -1,82 +0,0 @@
|
|||||||
//go:build !windows
|
|
||||||
|
|
||||||
/*
|
|
||||||
Copyright The Helm Authors.
|
|
||||||
|
|
||||||
Licensed under the Apache License, Version 2.0 (the "License");
|
|
||||||
you may not use this file except in compliance with the License.
|
|
||||||
You may obtain a copy of the License at
|
|
||||||
|
|
||||||
http://www.apache.org/licenses/LICENSE-2.0
|
|
||||||
|
|
||||||
Unless required by applicable law or agreed to in writing, software
|
|
||||||
distributed under the License is distributed on an "AS IS" BASIS,
|
|
||||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
||||||
See the License for the specific language governing permissions and
|
|
||||||
limitations under the License.
|
|
||||||
*/
|
|
||||||
|
|
||||||
package main
|
|
||||||
|
|
||||||
import (
|
|
||||||
"bytes"
|
|
||||||
"io"
|
|
||||||
"os"
|
|
||||||
"path/filepath"
|
|
||||||
"strings"
|
|
||||||
"testing"
|
|
||||||
)
|
|
||||||
|
|
||||||
func checkPermsStderr() (string, error) {
|
|
||||||
r, w, err := os.Pipe()
|
|
||||||
if err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
|
|
||||||
stderr := os.Stderr
|
|
||||||
os.Stderr = w
|
|
||||||
defer func() {
|
|
||||||
os.Stderr = stderr
|
|
||||||
}()
|
|
||||||
|
|
||||||
checkPerms()
|
|
||||||
w.Close()
|
|
||||||
|
|
||||||
var text bytes.Buffer
|
|
||||||
io.Copy(&text, r)
|
|
||||||
return text.String(), nil
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestCheckPerms(t *testing.T) {
|
|
||||||
tdir := t.TempDir()
|
|
||||||
tfile := filepath.Join(tdir, "testconfig")
|
|
||||||
fh, err := os.OpenFile(tfile, os.O_CREATE|os.O_APPEND|os.O_RDWR, 0440)
|
|
||||||
if err != nil {
|
|
||||||
t.Errorf("Failed to create temp file: %s", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
tconfig := settings.KubeConfig
|
|
||||||
settings.KubeConfig = tfile
|
|
||||||
defer func() { settings.KubeConfig = tconfig }()
|
|
||||||
|
|
||||||
text, err := checkPermsStderr()
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("could not read from stderr: %s", err)
|
|
||||||
}
|
|
||||||
expectPrefix := "WARNING: Kubernetes configuration file is group-readable. This is insecure. Location:"
|
|
||||||
if !strings.HasPrefix(text, expectPrefix) {
|
|
||||||
t.Errorf("Expected to get a warning for group perms. Got %q", text)
|
|
||||||
}
|
|
||||||
|
|
||||||
if err := fh.Chmod(0404); err != nil {
|
|
||||||
t.Errorf("Could not change mode on file: %s", err)
|
|
||||||
}
|
|
||||||
text, err = checkPermsStderr()
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("could not read from stderr: %s", err)
|
|
||||||
}
|
|
||||||
expectPrefix = "WARNING: Kubernetes configuration file is world-readable. This is insecure. Location:"
|
|
||||||
if !strings.HasPrefix(text, expectPrefix) {
|
|
||||||
t.Errorf("Expected to get a warning for world perms. Got %q", text)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@ -1 +1 @@
|
|||||||
{"name":"thomas-guide","chart":"foo","version":"0.1.0-beta.1","appVersion":"1.0","namespace":"default","revision":1,"status":"deployed","deployedAt":"1977-09-02T22:04:05Z"}
|
{"name":"thomas-guide","chart":"foo","version":"0.1.0-beta.1","appVersion":"1.0","annotations":{"category":"web-apps","supported":"true"},"dependencies":[{"name":"cool-plugin","version":"1.0.0","repository":"https://coolplugin.io/charts","condition":"coolPlugin.enabled","enabled":true},{"name":"crds","version":"2.7.1","repository":"","condition":"crds.enabled"}],"namespace":"default","revision":1,"status":"deployed","deployedAt":"1977-09-02T22:04:05Z"}
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Loading…
Reference in new issue