Feedback from CoPilot

Signed-off-by: Mads Jensen <atombrella@users.noreply.github.com>

internal/chart/v3/lint/lint_test.go

@@ -234,7 +234,7 @@ func TestMalformedTemplate(t *testing.T) {
 	var values map[string]any
 	c := time.After(3 * time.Second)
 	ch := make(chan int, 1)
-	var m []support.MessageError
+	var m []support.LintMessageError
 	go func() {
 		m = RunAll(malformedTemplate, values, namespace).Messages
 		ch <- 1

internal/chart/v3/lint/support/message.go

@@ -35,27 +35,27 @@ var sev = []string{"UNKNOWN", "INFO", "WARNING", "ERROR"}
 
 // Linter encapsulates a linting run of a particular chart.
 type Linter struct {
-	Messages []MessageError
+	Messages []LintMessageError
 	// The highest severity of all the failing lint rules
 	HighestSeverity int
 	ChartDir        string
 }
 
-// Message describes an error encountered while linting.
+// LintMessageError describes an error encountered while linting.
-type MessageError struct {
+type LintMessageError struct {
 	// Severity is one of the *Sev constants
 	Severity int
 	Path     string
 	Err      error
 }
 
-func (m MessageError) Error() string {
+func (m LintMessageError) Error() string {
 	return fmt.Sprintf("[%s] %s: %s", sev[m.Severity], m.Path, m.Err.Error())
 }
 
 // NewMessage creates a new Message struct
-func NewMessage(severity int, path string, err error) MessageError {
+func NewMessage(severity int, path string, err error) LintMessageError {
-	return MessageError{Severity: severity, Path: path, Err: err}
+	return LintMessageError{Severity: severity, Path: path, Err: err}
 }
 
 // RunLinterRule returns true if the validation passed

internal/chart/v3/lint/support/message_test.go

@@ -62,17 +62,17 @@ func TestRunLinterRule(t *testing.T) {
 }
 
 func TestMessage(t *testing.T) {
-	m := MessageError{ErrorSev, "Chart.yaml", errors.New("Foo")}
+	m := LintMessageError{ErrorSev, "Chart.yaml", errors.New("Foo")}
 	if m.Error() != "[ERROR] Chart.yaml: Foo" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}
 
-	m = MessageError{WarningSev, "templates/", errors.New("Bar")}
+	m = LintMessageError{WarningSev, "templates/", errors.New("Bar")}
 	if m.Error() != "[WARNING] templates/: Bar" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}
 
-	m = MessageError{InfoSev, "templates/rc.yaml", errors.New("FooBar")}
+	m = LintMessageError{InfoSev, "templates/rc.yaml", errors.New("FooBar")}
 	if m.Error() != "[INFO] templates/rc.yaml: FooBar" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}

internal/chart/v3/util/dependencies_test.go

@@ -255,7 +255,7 @@ func TestProcessDependencyImportValues(t *testing.T) {
 	case common.NoValueError:
 		// We found what we expected
 	default:
-		t.Errorf("expected an NoValueErr but got %q instead", xerr)
+		t.Errorf("expected a NoValueError but got %q instead", xerr)
 	}
 
 	c = loadChart(t, "testdata/subpop")

pkg/action/lint.go

@@ -43,7 +43,7 @@ type Lint struct {
 // LintResult is the result of Lint
 type LintResult struct {
 	TotalChartsLinted int
-	Messages          []support.MessageError
+	Messages          []support.LintMessageError
 	Errors            []error
 }
 

pkg/chart/v2/lint/lint_test.go

@@ -238,7 +238,7 @@ func TestMalformedTemplate(t *testing.T) {
 	var values map[string]any
 	c := time.After(3 * time.Second)
 	ch := make(chan int, 1)
-	var m []support.MessageError
+	var m []support.LintMessageError
 	go func() {
 		m = RunAll(malformedTemplate, values, namespace).Messages
 		ch <- 1

pkg/chart/v2/lint/support/message.go

@@ -35,27 +35,27 @@ var sev = []string{"UNKNOWN", "INFO", "WARNING", "ERROR"}
 
 // Linter encapsulates a linting run of a particular chart.
 type Linter struct {
-	Messages []MessageError
+	Messages []LintMessageError
 	// The highest severity of all the failing lint rules
 	HighestSeverity int
 	ChartDir        string
 }
 
 // Message describes an error encountered while linting.
-type MessageError struct {
+type LintMessageError struct {
 	// Severity is one of the *Sev constants
 	Severity int
 	Path     string
 	Err      error
 }
 
-func (m MessageError) Error() string {
+func (m LintMessageError) Error() string {
 	return fmt.Sprintf("[%s] %s: %s", sev[m.Severity], m.Path, m.Err.Error())
 }
 
 // NewMessage creates a new Message struct
-func NewMessage(severity int, path string, err error) MessageError {
+func NewMessage(severity int, path string, err error) LintMessageError {
-	return MessageError{Severity: severity, Path: path, Err: err}
+	return LintMessageError{Severity: severity, Path: path, Err: err}
 }
 
 // RunLinterRule returns true if the validation passed

pkg/chart/v2/lint/support/message_test.go

@@ -62,17 +62,17 @@ func TestRunLinterRule(t *testing.T) {
 }
 
 func TestMessage(t *testing.T) {
-	m := MessageError{ErrorSev, "Chart.yaml", errors.New("Foo")}
+	m := LintMessageError{ErrorSev, "Chart.yaml", errors.New("Foo")}
 	if m.Error() != "[ERROR] Chart.yaml: Foo" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}
 
-	m = MessageError{WarningSev, "templates/", errors.New("Bar")}
+	m = LintMessageError{WarningSev, "templates/", errors.New("Bar")}
 	if m.Error() != "[WARNING] templates/: Bar" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}
 
-	m = MessageError{InfoSev, "templates/rc.yaml", errors.New("FooBar")}
+	m = LintMessageError{InfoSev, "templates/rc.yaml", errors.New("FooBar")}
 	if m.Error() != "[INFO] templates/rc.yaml: FooBar" {
 		t.Errorf("Unexpected output: %s", m.Error())
 	}

pkg/chart/v2/util/dependencies_test.go

@@ -255,7 +255,7 @@ func TestProcessDependencyImportValues(t *testing.T) {
 	case common.NoValueError:
 		// We found what we expected
 	default:
-		t.Errorf("expected an NoValueErr but got %q instead", xerr)
+		t.Errorf("expected a NoValueError but got %q instead", xerr)
 	}
 
 	c = loadChart(t, "testdata/subpop")