fix(rollback): `errors.Is` instead of string comp

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
pull/12564/head
Hidde Beydals 3 years ago
parent 2f1ecc7100
commit d158708fbf
No known key found for this signature in database
GPG Key ID: 979F380FC2341744

@ -18,8 +18,8 @@ package action
import ( import (
"bytes" "bytes"
"errors"
"fmt" "fmt"
"strings"
"time" "time"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@ -28,6 +28,7 @@ import (
"helm.sh/helm/v4/pkg/kube" "helm.sh/helm/v4/pkg/kube"
"helm.sh/helm/v4/pkg/release/common" "helm.sh/helm/v4/pkg/release/common"
release "helm.sh/helm/v4/pkg/release/v1" release "helm.sh/helm/v4/pkg/release/v1"
"helm.sh/helm/v4/pkg/storage/driver"
) )
// Rollback is the action for rolling back to a given release. // Rollback is the action for rolling back to a given release.
@ -278,7 +279,7 @@ func (r *Rollback) performRollback(currentRelease, targetRelease *release.Releas
} }
deployed, err := r.cfg.Releases.DeployedAll(currentRelease.Name) deployed, err := r.cfg.Releases.DeployedAll(currentRelease.Name)
if err != nil && !strings.Contains(err.Error(), "has no deployed releases") { if err != nil && !errors.Is(err, driver.ErrNoDeployedReleases) {
return nil, err return nil, err
} }
// Supersede all previous deployments, see issue #2941. // Supersede all previous deployments, see issue #2941.

Loading…
Cancel
Save