fix: plugin installer test with no Internet

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
pull/30928/head
Terry Howe 4 months ago
parent 39305fc160
commit cc39d2428f

@ -19,6 +19,7 @@ import (
"fmt" "fmt"
"os" "os"
"path/filepath" "path/filepath"
"strings"
"testing" "testing"
"github.com/Masterminds/vcs" "github.com/Masterminds/vcs"
@ -119,6 +120,8 @@ func TestVCSInstallerNonExistentVersion(t *testing.T) {
if err := Install(i); err == nil { if err := Install(i); err == nil {
t.Fatalf("expected error for version does not exists, got none") t.Fatalf("expected error for version does not exists, got none")
} else if strings.Contains(err.Error(), "Could not resolve host: github.com") {
t.Skip("Unable to run test without Internet access")
} else if err.Error() != fmt.Sprintf("requested version %q does not exist for plugin %q", version, source) { } else if err.Error() != fmt.Sprintf("requested version %q does not exist for plugin %q", version, source) {
t.Fatalf("expected error for version does not exists, got (%v)", err) t.Fatalf("expected error for version does not exists, got (%v)", err)
} }
@ -146,7 +149,11 @@ func TestVCSInstallerUpdate(t *testing.T) {
// Install plugin before update // Install plugin before update
if err := Install(i); err != nil { if err := Install(i); err != nil {
t.Fatal(err) if strings.Contains(err.Error(), "Could not resolve host: github.com") {
t.Skip("Unable to run test without Internet access")
} else {
t.Fatal(err)
}
} }
// Test FindSource method for positive result // Test FindSource method for positive result

Loading…
Cancel
Save