Fix action/List.Run to skip the latest release filter if ListSuperseded is set

If superseded releases should be returned, then do not filter for only the
latest releases, because the latest releases exclude superseded releases, by
definition.

Previously, the logic was: if _only_ superseded releases should be included,
then do not filter for only the latest releases. That is incorrect; for
example, when _all_ releases were requested, only the latest releases would be
returned.

Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
pull/9135/head
Daniel Lipovetsky 5 years ago
parent b3a20d5b4a
commit cba5d86737
No known key found for this signature in database
GPG Key ID: 559B3DEDDDF8FF82

@ -172,10 +172,10 @@ func (l *List) Run() ([]*release.Release, error) {
return results, nil return results, nil
} }
// by definition, superseded releases are never shown if // If superseded releases should be returned, then do not filter for only
// only the latest releases are returned. so if requested statemask // the latest releases, because the latest releases exclude superseded
// is _only_ ListSuperseded, skip the latest release filter // releases, by definition.
if l.StateMask != ListSuperseded { if (l.StateMask & ListSuperseded) == 0 {
results = filterLatestReleases(results) results = filterLatestReleases(results)
} }

Loading…
Cancel
Save