msb-public
/
helm
mirror of https://github.com/helm/helm
1
0
Code Issues Projects Releases Wiki Activity

docs(helm): Mention commit signing in the Developer Guide (#5018)

Browse Source 
This change adds a mention to the reqruiement for commit signing
to the Git Convention outline in the Developer Guide, while
leaving the existing detail on signing in the Contributing doc.

Closes #5016

Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
pull/5021/head
Henry Nash 6 years ago committed by Matthew Fisher
parent 88af9659a2
commit c80f7ddaeb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File

2
docs/developers.md
Unescape View File

@ -167,7 +167,7 @@ workflow for doing this is as follows:
3. Add your repository as a remote for `$GOPATH/src/k8s.io/helm` 3. Add your repository as a remote for `$GOPATH/src/k8s.io/helm`
4. Create a new working branch (`git checkout -b feat/my-feature`) and 4. Create a new working branch (`git checkout -b feat/my-feature`) and
do your work on that branch. do your work on that branch.
5. When you are ready for us to review, push your branch to GitHub, and 5. When you are ready for us to review, sign your commit, push your branch to GitHub, and
then open a new pull request with us. then open a new pull request with us.
For Git commit messages, we follow the [Semantic Commit Messages](http://karma-runner.github.io/0.13/dev/git-commit-msg.html): For Git commit messages, we follow the [Semantic Commit Messages](http://karma-runner.github.io/0.13/dev/git-commit-msg.html):

Write Preview
Loading…
Cancel
Save