Merge pull request #434 from michelleN/pack

helm chart pack [PATH]

cmd/helm/chart.go

@@ -18,10 +18,13 @@ package main
 
 import (
 	"errors"
+	"fmt"
+	"os"
 	"path/filepath"
 
 	"github.com/codegangsta/cli"
 	"github.com/kubernetes/helm/pkg/chart"
+	"github.com/kubernetes/helm/pkg/format"
 )
 
 func init() {
@@ -61,6 +64,13 @@ func chartCommands() cli.Command {
 				Usage:     "given a chart, show all the deployments that reference it.",
 				ArgsUsage: "CHART",
 			},
+			{
+				Name:      "package",
+				Aliases:   []string{"pack"},
+				Usage:     "Given a chart directory, package it into a release.",
+				ArgsUsage: "PATH",
+				Action:    func(c *cli.Context) { run(c, pack) },
+			},
 		},
 	}
 }
@@ -81,4 +91,35 @@ func createChart(c *cli.Context) error {
 
 	_, err := chart.Create(cf, dir)
 	return err
+
+}
+
+func pack(cxt *cli.Context) error {
+	args := cxt.Args()
+	if len(args) < 1 {
+		return errors.New("'helm package' requires a path to a chart directory as an argument")
+	}
+
+	dir := args[0]
+	if fi, err := os.Stat(dir); err != nil {
+		return fmt.Errorf("Could not find directory %s: %s", dir, err)
+	} else if !fi.IsDir() {
+		return fmt.Errorf("Not a directory: %s", dir)
+	}
+
+	fname, err := packDir(dir)
+	if err != nil {
+		return err
+	}
+	format.Msg(fname)
+	return nil
+}
+
+func packDir(dir string) (string, error) {
+	c, err := chart.LoadDir(dir)
+	if err != nil {
+		return "", fmt.Errorf("Failed to load %s: %s", dir, err)
+	}
+
+	return chart.Save(c, ".")
 }

cmd/helm/pack.go

@@ -1,71 +0,0 @@
-/*
-Copyright 2016 The Kubernetes Authors All rights reserved.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package main
-
-import (
-	"errors"
-	"fmt"
-	"os"
-
-	"github.com/codegangsta/cli"
-	"github.com/kubernetes/helm/pkg/chart"
-	"github.com/kubernetes/helm/pkg/format"
-)
-
-func init() {
-	addCommands(packageCmd())
-}
-
-func packageCmd() cli.Command {
-	return cli.Command{
-		Name:      "package",
-		Aliases:   []string{"pack"},
-		Usage:     "Given a chart directory, package it into a release.",
-		ArgsUsage: "PATH",
-		Action:    func(c *cli.Context) { run(c, pack) },
-	}
-}
-
-func pack(cxt *cli.Context) error {
-	args := cxt.Args()
-	if len(args) < 1 {
-		return errors.New("'helm package' requires a path to a chart directory as an argument")
-	}
-
-	dir := args[0]
-	if fi, err := os.Stat(dir); err != nil {
-		return fmt.Errorf("Could not find directory %s: %s", dir, err)
-	} else if !fi.IsDir() {
-		return fmt.Errorf("Not a directory: %s", dir)
-	}
-
-	fname, err := packDir(dir)
-	if err != nil {
-		return err
-	}
-	format.Msg(fname)
-	return nil
-}
-
-func packDir(dir string) (string, error) {
-	c, err := chart.LoadDir(dir)
-	if err != nil {
-		return "", fmt.Errorf("Failed to load %s: %s", dir, err)
-	}
-
-	return chart.Save(c, ".")
-}

docs/workflow/developer-workflows.md

@@ -354,7 +354,7 @@ helm lint PATH
 Package a chart:
 
 ```
-$ helm package .
+$ helm chart package PATH/TO/FOO
 Created foo-1.1.2.tgz
 ```
 
@@ -367,7 +367,7 @@ Uploaded to https://example.com/bucket/foo-1.1.2.tgz
 
 General pattern:
 ```
-helm package PATH
+helm chart package PATH
 helm release [-u destination] PATH|FILE
 ```
 

examples/charts/nginx/Chart.yaml

@@ -1,13 +1,12 @@
 name: nginx
-home: https://www.nginx.com
-version: 0.0.1
 description: nginx http service
-maintainers:
-  - Michelle Noorali <michelle@deis.com>
-details:
-  This is a basic nginx http service.
+version: 0.0.1
 keywords:
-  - web server
-  - http
-  - https
-  - proxy
+- web server
+- http
+- https
+- proxy
+maintainers:
+- name: Melinda Doe
+  email: Melinda@helm.com
+home: https://www.nginx.com