fixing missing attributes

Signed-off-by: Robert Sirchia <rsirchia@outlook.com>

pkg/chart/v2/util/dependencies.go

@@ -51,7 +51,7 @@ func processDependencyConditions(reqs []*chart.Dependency, cvals Values, cpath s
 					slog.Warn("Warning: Condition path '%s' for chart %s returned non-bool value", c, r.Name)
 				} else if _, ok := err.(ErrNoValue); !ok {
 					// this is a real error
-					slog.Error("Warning: PathValue returned error %v", err)
+					slog.Error("Warning: PathValue returned error %v", slog.Any("err", err))
 				}
 			}
 		}
@@ -271,7 +271,7 @@ func processImportValues(c *chart.Chart, merge bool) error {
 				})
 				vm, err := cvals.Table(r.Name + "." + child)
 				if err != nil {
-					slog.Error("Warning: ImportValues missing table: %v", err)
+					slog.Error("Warning: ImportValues missing table: %v", slog.Any("err", err))
 					continue
 				}
 				if merge {

pkg/engine/engine.go

@@ -203,7 +203,7 @@ func (e Engine) initFunMap(t *template.Template) {
 		if val == nil {
 			if e.LintMode {
 				// Don't fail on missing required values when linting
-				slog.Warn("[INFO] Missing required value: %s", warn)
+				slog.Warn("[INFO] Missing required value: %s", "LintMode", warn)
 				return "", nil
 			}
 			return val, errors.New(warnWrap(warn))
@@ -211,7 +211,7 @@ func (e Engine) initFunMap(t *template.Template) {
 			if val == "" {
 				if e.LintMode {
 					// Don't fail on missing required values when linting
-					slog.Warn("[INFO] Missing required value: %s", warn)
+					slog.Warn("[INFO] Missing required value: %s", "LintMode", warn)
 					return "", nil
 				}
 				return val, errors.New(warnWrap(warn))
@@ -224,7 +224,7 @@ func (e Engine) initFunMap(t *template.Template) {
 	funcMap["fail"] = func(msg string) (string, error) {
 		if e.LintMode {
 			// Don't fail when linting
-			slog.Info("[INFO] Fail: %s", msg)
+			slog.Info("[INFO] Fail: %s", "LintMode", msg)
 			return "", nil
 		}
 		return "", errors.New(warnWrap(msg))

pkg/engine/lookup_func.go

@@ -111,7 +111,7 @@ func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config)
 	}
 	intf, err := dynamic.NewForConfig(config)
 	if err != nil {
-		slog.Error("[ERROR] unable to get dynamic client %s", err)
+		slog.Error("[ERROR] unable to get dynamic client %s", slog.Any("err", err))
 		return nil, false, err
 	}
 	res := intf.Resource(gvr)
@@ -122,7 +122,7 @@ func getAPIResourceForGVK(gvk schema.GroupVersionKind, config *rest.Config) (met
 	res := metav1.APIResource{}
 	discoveryClient, err := discovery.NewDiscoveryClientForConfig(config)
 	if err != nil {
-		slog.Error("[ERROR] unable to create discovery client %s", err)
+		slog.Error("[ERROR] unable to create discovery client %s", slog.Any("err", err))
 		return res, err
 	}
 	resList, err := discoveryClient.ServerResourcesForGroupVersion(gvk.GroupVersion().String())

pkg/ignore/rules.go

@@ -102,7 +102,7 @@ func (r *Rules) Ignore(path string, fi os.FileInfo) bool {
 	}
 	for _, p := range r.patterns {
 		if p.match == nil {
-			slog.Info("ignore: no matcher supplied for %q", p.raw)
+			slog.Info("ignore: no matcher supplied for %q", "patterns", p.raw)
 			return false
 		}
 

pkg/plugin/installer/vcs_installer.go

@@ -95,7 +95,7 @@ func (i *VCSInstaller) Install() error {
 
 // Update updates a remote repository
 func (i *VCSInstaller) Update() error {
-	slog.Debug("updating %s", i.Repo.Remote())
+	slog.Debug("updating %s", "repo", i.Repo.Remote())
 	if i.Repo.IsDirty() {
 		return errors.New("plugin repo was modified")
 	}
@@ -129,7 +129,7 @@ func (i *VCSInstaller) solveVersion(repo vcs.Repo) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	slog.Debug("found refs: %s", refs)
+	slog.Debug("found refs: %s", "refs", refs)
 
 	// Convert and filter the list to semver.Version instances
 	semvers := getSemVers(refs)
@@ -140,7 +140,7 @@ func (i *VCSInstaller) solveVersion(repo vcs.Repo) (string, error) {
 		if constraint.Check(v) {
 			// If the constraint passes get the original reference
 			ver := v.Original()
-			slog.Debug("setting to %s", ver)
+			slog.Debug("setting to %s", "versions", ver)
 			return ver, nil
 		}
 	}
@@ -150,7 +150,7 @@ func (i *VCSInstaller) solveVersion(repo vcs.Repo) (string, error) {
 
 // setVersion attempts to checkout the version
 func (i *VCSInstaller) setVersion(repo vcs.Repo, ref string) error {
-	slog.Debug("setting version to %q", i.Version)
+	slog.Debug("setting version to %q", "versions", i.Version)
 	return repo.UpdateVersion(ref)
 }
 
@@ -160,7 +160,7 @@ func (i *VCSInstaller) sync(repo vcs.Repo) error {
 		slog.Debug("cloning %s to %s", repo.Remote(), repo.LocalPath())
 		return repo.Get()
 	}
-	slog.Debug("updating %s", repo.Remote())
+	slog.Debug("updating %s", "remote", repo.Remote())
 	return repo.Update()
 }
 

pkg/release/util/manifest_sorter.go

@@ -196,7 +196,7 @@ func (file *manifestFile) sort(result *result) error {
 		}
 
 		if isUnknownHook {
-			slog.Info("info: skipping unknown hook: %q", hookTypes)
+			slog.Info("info: skipping unknown hook: %q", "hookTypes", hookTypes)
 			continue
 		}
 

pkg/repo/chartrepo.go

@@ -343,7 +343,7 @@ func ResolveReferenceURL(baseURL, refURL string) (string, error) {
 func (e *Entry) String() string {
 	buf, err := json.Marshal(e)
 	if err != nil {
-		slog.Error("failed to marshal entry: %s", err)
+		slog.Error("failed to marshal entry: %s", slog.Any("err", err))
 		panic(err)
 	}
 	return string(buf)