pkg/chart/chart_test.go: refactor the chart1 and chart2 setup code in a separate function

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

pkg/chart/chart_test.go

@@ -97,41 +97,31 @@ func TestMetadata(t *testing.T) {
 	is.Equal(nil, chrt.Validate())
 }
 
-func TestRoot(t *testing.T) {
+func newTestFixtureCharts() (*Chart, *Chart) {
-	chrt1 := Chart{
+	return &Chart{
 			parent: &Chart{
 				Metadata: &Metadata{
 					Name: "foo",
 				},
 			},
-	}
+		}, &Chart{
-
-	chrt2 := Chart{
 			Metadata: &Metadata{
 				Name: "foo",
 			},
 		}
+}
+
+func TestRoot(t *testing.T) {
+	chrt1, chrt2 := newTestFixtureCharts()
 
 	is := assert.New(t)
 
-	is.Equal(&chrt2, chrt1.Root())
+	is.Equal(chrt2, chrt1.Root())
-	is.Equal(&chrt2, chrt2.Root())
+	is.Equal(chrt2, chrt2.Root())
 }
 
 func TestIsRoot(t *testing.T) {
-	chrt1 := Chart{
+	chrt1, chrt2 := newTestFixtureCharts()
-		parent: &Chart{
-			Metadata: &Metadata{
-				Name: "foo",
-			},
-		},
-	}
-
-	chrt2 := Chart{
-		Metadata: &Metadata{
-			Name: "foo",
-		},
-	}
 
 	is := assert.New(t)
 
@@ -140,19 +130,7 @@ func TestIsRoot(t *testing.T) {
 }
 
 func TestChartPath(t *testing.T) {
-	chrt1 := Chart{
+	chrt1, chrt2 := newTestFixtureCharts()
-		parent: &Chart{
-			Metadata: &Metadata{
-				Name: "foo",
-			},
-		},
-	}
-
-	chrt2 := Chart{
-		Metadata: &Metadata{
-			Name: "foo",
-		},
-	}
 
 	is := assert.New(t)
 
@@ -161,19 +139,7 @@ func TestChartPath(t *testing.T) {
 }
 
 func TestChartFullPath(t *testing.T) {
-	chrt1 := Chart{
+	chrt1, chrt2 := newTestFixtureCharts()
-		parent: &Chart{
-			Metadata: &Metadata{
-				Name: "foo",
-			},
-		},
-	}
-
-	chrt2 := Chart{
-		Metadata: &Metadata{
-			Name: "foo",
-		},
-	}
 
 	is := assert.New(t)