Display local times in 'helm history' table output

Signed-off-by: Reinaldo de Souza Jr <github@rei.nal.do>
pull/9187/head
Reinaldo de Souza Jr 5 years ago
parent 960b3b53c6
commit bd13ad3052

@ -107,7 +107,7 @@ func (r releaseHistory) WriteTable(out io.Writer) error {
tbl := uitable.New() tbl := uitable.New()
tbl.AddRow("REVISION", "UPDATED", "STATUS", "CHART", "APP VERSION", "DESCRIPTION") tbl.AddRow("REVISION", "UPDATED", "STATUS", "CHART", "APP VERSION", "DESCRIPTION")
for _, item := range r { for _, item := range r {
tbl.AddRow(item.Revision, item.Updated.Format(time.ANSIC), item.Status, item.Chart, item.AppVersion, item.Description) tbl.AddRow(item.Revision, item.Updated.Local().Format(time.ANSIC), item.Status, item.Chart, item.AppVersion, item.Description)
} }
return output.EncodeTable(out, tbl) return output.EncodeTable(out, tbl)
} }

@ -19,6 +19,7 @@ package main
import ( import (
"fmt" "fmt"
"testing" "testing"
"time"
"helm.sh/helm/v3/pkg/release" "helm.sh/helm/v3/pkg/release"
) )
@ -67,7 +68,25 @@ func TestHistoryCmd(t *testing.T) {
}, },
golden: "output/history.json", golden: "output/history.json",
}} }}
prevLocal := time.Local
time.Local = time.UTC
runTestCmd(t, tests) runTestCmd(t, tests)
time.Local = time.FixedZone("Arbitrary", 5*60*60)
runTestCmd(t, []cmdTestCase{{
name: "get history for release in UTC+5",
cmd: "history angry-bird",
rels: []*release.Release{
mk("angry-bird", 4, release.StatusDeployed),
mk("angry-bird", 3, release.StatusSuperseded),
mk("angry-bird", 2, release.StatusSuperseded),
mk("angry-bird", 1, release.StatusSuperseded),
},
golden: "output/history-utc+5.txt",
}})
time.Local = prevLocal
} }
func TestHistoryOutputCompletion(t *testing.T) { func TestHistoryOutputCompletion(t *testing.T) {

@ -0,0 +1,5 @@
REVISION UPDATED STATUS CHART APP VERSION DESCRIPTION
1 Sat Sep 3 03:04:05 1977 superseded foo-0.1.0-beta.1 1.0 Release mock
2 Sat Sep 3 03:04:05 1977 superseded foo-0.1.0-beta.1 1.0 Release mock
3 Sat Sep 3 03:04:05 1977 superseded foo-0.1.0-beta.1 1.0 Release mock
4 Sat Sep 3 03:04:05 1977 deployed foo-0.1.0-beta.1 1.0 Release mock
Loading…
Cancel
Save