msb-public
/
helm
mirror of https://github.com/helm/helm
1
0
Code Issues Projects Releases Wiki Activity

Merge pull request #5236 from Lentil1016/migrate-sort-manifest

Browse Source 
Refactor: migrate SortManifests and its test case to releaseutil
pull/5283/head
Matthew Fisher 6 years ago committed by GitHub
parent c45496bc2e 223148dac9
commit a8d73ff2e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File

1
pkg/action/install.go
Unescape View File

@ -329,7 +329,6 @@ func (i *Install) renderResources(ch *chart.Chart, values chartutil.Values, vs c
// Sort hooks, manifests, and partials. Only hooks and manifests are returned, // Sort hooks, manifests, and partials. Only hooks and manifests are returned,
// as partials are not used after renderer.Render. Empty manifests are also // as partials are not used after renderer.Render. Empty manifests are also
// removed here. // removed here.
// TODO: Can we migrate SortManifests out of pkg/tiller?
hooks, manifests, err := releaseutil.SortManifests(files, vs, releaseutil.InstallOrder) hooks, manifests, err := releaseutil.SortManifests(files, vs, releaseutil.InstallOrder)
if err != nil { if err != nil {
// By catching parse errors here, we can prevent bogus releases from going // By catching parse errors here, we can prevent bogus releases from going

Write Preview
Loading…
Cancel
Save