[#9136] - Deprecate ProcessDependencies for ProcessDependenciesWithValues, which copies the dependencies rather than mutating them.

Signed-off-by: Elliot Kennedy <me@elken.io>

pkg/action/install.go

@@ -207,7 +207,7 @@ func (i *Install) Run(chrt *chart.Chart, vals map[string]interface{}) (*release.
 		i.cfg.Log("API Version list given outside of client only mode, this list will be ignored")
 	}
 
-	if err := chartutil.ProcessDependencies(chrt, vals); err != nil {
+	if err := chartutil.ProcessDependenciesWithValues(chrt, vals); err != nil {
 		return nil, err
 	}
 

pkg/action/upgrade.go

@@ -188,7 +188,7 @@ func (u *Upgrade) prepareUpgrade(name string, chart *chart.Chart, vals map[strin
 		return nil, nil, err
 	}
 
-	if err := chartutil.ProcessDependencies(chart, vals); err != nil {
+	if err := chartutil.ProcessDependenciesWithValues(chart, vals); err != nil {
 		return nil, nil, err
 	}
 

pkg/chartutil/dependencies.go

@@ -25,7 +25,7 @@ import (
 )
 
 // ProcessDependencies checks through this chart's dependencies, processing accordingly.
-func ProcessDependencies(c *chart.Chart, vals map[string]interface{}) error {
+func ProcessDependenciesWithValues(c *chart.Chart, vals map[string]interface{}) error {
 	v, err := copystructure.Copy(vals)
 	if err != nil {
 		return err
@@ -39,6 +39,16 @@ func ProcessDependencies(c *chart.Chart, vals map[string]interface{}) error {
 	return process(c, valsCopy)
 }
 
+// ProcessDependencies checks through this chart's dependencies, processing accordingly.
+//
+// Deprecated: ProcessDependencies. Use ProcessDependenciesWithValues
+func ProcessDependencies(c *chart.Chart, v Values) error {
+	if err := processDependencyEnabled(c, v, ""); err != nil {
+		return err
+	}
+	return processDependencyImportValues(c, v)
+}
+
 // process processes the dependencies
 //
 // This is a helper function for ProcessDependencies.