fix(action): error when --dry-run=server is combined with --server-side=false on upgrade

Client-side update paths do not honor the dry-run flag, so validating under
SSA semantics when the real upgrade would use CSA gives misleading results.
Return an explicit error instead of silently forcing SSA.

Also use the computed serverSideApply value directly to avoid forcing SSA,
and gate UpgradeClientSideFieldManager on whether the previous release used
CSA (matching the real upgrade path).

Signed-off-by: MrJack <36191829+biagiopietro@users.noreply.github.com>

pkg/action/upgrade.go

@@ -399,17 +399,15 @@ func (u *Upgrade) performUpgrade(ctx context.Context, originalRelease, upgradedR
 		u.cfg.Logger().Debug("dry run for release", "name", upgradedRelease.Name)
 		// For server-side dry-run, validate resources against the API server
 		if u.DryRunStrategy == DryRunServer {
-			// Ensure this validation request is strictly non-mutating by always using
+			if !serverSideApply {
-			// server-side apply and disabling force-replace, regardless of the user's
+				return upgradedRelease, errors.New("--dry-run=server requires --server-side=true")
-			// normal upgrade options.
+			}
-			dryRunServerSideApply := true
+			upgradeClientSideFieldManager := isReleaseApplyMethodClientSideApply(originalRelease.ApplyMethod)
-			dryRunForceReplace := false
-			upgradeClientSideFieldManager := isReleaseApplyMethodClientSideApply(originalRelease.ApplyMethod) && dryRunServerSideApply
 			_, err := u.cfg.KubeClient.Update(
 				current,
 				target,
-				kube.ClientUpdateOptionForceReplace(dryRunForceReplace),
+				kube.ClientUpdateOptionForceReplace(false),
-				kube.ClientUpdateOptionServerSideApply(dryRunServerSideApply, u.ForceConflicts),
+				kube.ClientUpdateOptionServerSideApply(serverSideApply, u.ForceConflicts),
 				kube.ClientUpdateOptionDryRun(true),
 				kube.ClientUpdateOptionUpgradeClientSideFieldManager(upgradeClientSideFieldManager),
 			)