@ -28,7 +28,6 @@ import (
"os"
"os"
"path/filepath"
"path/filepath"
"regexp"
"regexp"
"runtime"
"strings"
"strings"
"testing"
"testing"
"time"
"time"
@ -48,9 +47,9 @@ import (
"helm.sh/helm/v4/pkg/chart/common"
"helm.sh/helm/v4/pkg/chart/common"
"helm.sh/helm/v4/pkg/kube"
"helm.sh/helm/v4/pkg/kube"
kubefake "helm.sh/helm/v4/pkg/kube/fake"
kubefake "helm.sh/helm/v4/pkg/kube/fake"
rcommon "helm.sh/helm/v4/pkg/release/common"
release "helm.sh/helm/v4/pkg/release/v1"
release "helm.sh/helm/v4/pkg/release/v1"
"helm.sh/helm/v4/pkg/storage/driver"
"helm.sh/helm/v4/pkg/storage/driver"
helmtime "helm.sh/helm/v4/pkg/time"
) )
type nameTemplateTestCase struct { type nameTemplateTestCase struct {
@ -132,14 +131,19 @@ func TestInstallRelease(t *testing.T) {
instAction := installAction ( t )
instAction := installAction ( t )
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
ctx , done := context . WithCancel ( t . Context ( ) )
ctx , done := context . WithCancel ( t . Context ( ) )
res , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
res i , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Equal ( res . Name , "test-install-release" , "Expected release name." )
is . Equal ( res . Name , "test-install-release" , "Expected release name." )
is . Equal ( res . Namespace , "spaced" )
is . Equal ( res . Namespace , "spaced" )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Len ( rel . Hooks , 1 )
is . Len ( rel . Hooks , 1 )
@ -158,7 +162,9 @@ func TestInstallRelease(t *testing.T) {
time . Sleep ( time . Millisecond * 100 )
time . Sleep ( time . Millisecond * 100 )
lastRelease , err := instAction . cfg . Releases . Last ( rel . Name )
lastRelease , err := instAction . cfg . Releases . Last ( rel . Name )
req . NoError ( err )
req . NoError ( err )
is . Equal ( lastRelease . Info . Status , release . StatusDeployed )
lrel , err := releaserToV1Release ( lastRelease )
is . NoError ( err )
is . Equal ( lrel . Info . Status , rcommon . StatusDeployed )
} }
func TestInstallReleaseWithTakeOwnership_ResourceNotOwned ( t * testing . T ) { func TestInstallReleaseWithTakeOwnership_ResourceNotOwned ( t * testing . T ) {
@ -177,12 +183,17 @@ func TestInstallReleaseWithTakeOwnership_ResourceNotOwned(t *testing.T) {
config := actionConfigFixtureWithDummyResources ( t , createDummyResourceList ( false ) )
config := actionConfigFixtureWithDummyResources ( t , createDummyResourceList ( false ) )
instAction := installActionWithConfig ( config )
instAction := installActionWithConfig ( config )
instAction . TakeOwnership = true
instAction . TakeOwnership = true
res , err := instAction . Run ( buildChart ( ) , nil )
res i , err := instAction . Run ( buildChart ( ) , nil )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Equal ( rel . Info . Description , "Install complete" )
is . Equal ( rel . Info . Description , "Install complete" )
@ -195,11 +206,16 @@ func TestInstallReleaseWithTakeOwnership_ResourceOwned(t *testing.T) {
config := actionConfigFixtureWithDummyResources ( t , createDummyResourceList ( true ) )
config := actionConfigFixtureWithDummyResources ( t , createDummyResourceList ( true ) )
instAction := installActionWithConfig ( config )
instAction := installActionWithConfig ( config )
instAction . TakeOwnership = false
instAction . TakeOwnership = false
res , err := instAction . Run ( buildChart ( ) , nil )
res i , err := instAction . Run ( buildChart ( ) , nil )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Equal ( rel . Info . Description , "Install complete" )
is . Equal ( rel . Info . Description , "Install complete" )
@ -229,14 +245,19 @@ func TestInstallReleaseWithValues(t *testing.T) {
"simpleKey" : "simpleValue" ,
"simpleKey" : "simpleValue" ,
} ,
} ,
}
}
res , err := instAction . Run ( buildChart ( withSampleValues ( ) ) , userVals )
res i , err := instAction . Run ( buildChart ( withSampleValues ( ) ) , userVals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Equal ( res . Name , "test-install-release" , "Expected release name." )
is . Equal ( res . Name , "test-install-release" , "Expected release name." )
is . Equal ( res . Namespace , "spaced" )
is . Equal ( res . Namespace , "spaced" )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Len ( rel . Hooks , 1 )
is . Len ( rel . Hooks , 1 )
@ -251,16 +272,6 @@ func TestInstallReleaseWithValues(t *testing.T) {
is . Equal ( expectedUserValues , rel . Config )
is . Equal ( expectedUserValues , rel . Config )
} }
func TestInstallReleaseClientOnly ( t * testing . T ) {
is := assert . New ( t )
instAction := installAction ( t )
instAction . ClientOnly = true
instAction . Run ( buildChart ( ) , nil ) // disregard output
is . Equal ( instAction . cfg . Capabilities , common . DefaultCapabilities )
is . Equal ( instAction . cfg . KubeClient , & kubefake . PrintingKubeClient { Out : io . Discard } )
}
func TestInstallRelease_NoName ( t * testing . T ) { func TestInstallRelease_NoName ( t * testing . T ) {
instAction := installAction ( t )
instAction := installAction ( t )
instAction . ReleaseName = ""
instAction . ReleaseName = ""
@ -277,15 +288,19 @@ func TestInstallRelease_WithNotes(t *testing.T) {
instAction := installAction ( t )
instAction := installAction ( t )
instAction . ReleaseName = "with-notes"
instAction . ReleaseName = "with-notes"
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withNotes ( "note here" ) ) , vals )
res i , err := instAction . Run ( buildChart ( withNotes ( "note here" ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Equal ( res . Name , "with-notes" )
is . Equal ( res . Name , "with-notes" )
is . Equal ( res . Namespace , "spaced" )
is . Equal ( res . Namespace , "spaced" )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Len ( rel . Hooks , 1 )
is . Len ( rel . Hooks , 1 )
is . Equal ( rel . Hooks [ 0 ] . Manifest , manifestWithHook )
is . Equal ( rel . Hooks [ 0 ] . Manifest , manifestWithHook )
@ -304,12 +319,16 @@ func TestInstallRelease_WithNotesRendered(t *testing.T) {
instAction := installAction ( t )
instAction := installAction ( t )
instAction . ReleaseName = "with-notes"
instAction . ReleaseName = "with-notes"
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withNotes ( "got-{{.Release.Name}}" ) ) , vals )
res i , err := instAction . Run ( buildChart ( withNotes ( "got-{{.Release.Name}}" ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
expectedNotes := fmt . Sprintf ( "got-%s" , res . Name )
expectedNotes := fmt . Sprintf ( "got-%s" , res . Name )
@ -323,14 +342,18 @@ func TestInstallRelease_WithChartAndDependencyParentNotes(t *testing.T) {
instAction := installAction ( t )
instAction := installAction ( t )
instAction . ReleaseName = "with-notes"
instAction . ReleaseName = "with-notes"
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withNotes ( "parent" ) , withDependency ( withNotes ( "child" ) ) ) , vals )
res i , err := instAction . Run ( buildChart ( withNotes ( "parent" ) , withDependency ( withNotes ( "child" ) ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . Equal ( "with-notes" , rel . Name )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Equal ( "with-notes" , rel . Name )
is . Equal ( "parent" , rel . Info . Notes )
is . Equal ( "parent" , rel . Info . Notes )
is . Equal ( rel . Info . Description , "Install complete" )
is . Equal ( rel . Info . Description , "Install complete" )
} }
@ -342,14 +365,18 @@ func TestInstallRelease_WithChartAndDependencyAllNotes(t *testing.T) {
instAction . ReleaseName = "with-notes"
instAction . ReleaseName = "with-notes"
instAction . SubNotes = true
instAction . SubNotes = true
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withNotes ( "parent" ) , withDependency ( withNotes ( "child" ) ) ) , vals )
res i , err := instAction . Run ( buildChart ( withNotes ( "parent" ) , withDependency ( withNotes ( "child" ) ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
rel , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( res . Name , res . Version )
is . Equal ( "with-notes" , rel . Name )
is . NoError ( err )
is . NoError ( err )
rel , err := releaserToV1Release ( r )
is . NoError ( err )
is . Equal ( "with-notes" , rel . Name )
// test run can return as either 'parent\nchild' or 'child\nparent'
// test run can return as either 'parent\nchild' or 'child\nparent'
if ! strings . Contains ( rel . Info . Notes , "parent" ) && ! strings . Contains ( rel . Info . Notes , "child" ) {
if ! strings . Contains ( rel . Info . Notes , "parent" ) && ! strings . Contains ( rel . Info . Notes , "child" ) {
t . Fatalf ( "Expected 'parent\nchild' or 'child\nparent', got '%s'" , rel . Info . Notes )
t . Fatalf ( "Expected 'parent\nchild' or 'child\nparent', got '%s'" , rel . Info . Notes )
@ -357,15 +384,19 @@ func TestInstallRelease_WithChartAndDependencyAllNotes(t *testing.T) {
is . Equal ( rel . Info . Description , "Install complete" )
is . Equal ( rel . Info . Description , "Install complete" )
} }
func TestInstallRelease_DryRun ( t * testing . T ) { func TestInstallRelease_DryRunClient ( t * testing . T ) {
for _ , dryRunStrategy := range [ ] DryRunStrategy { DryRunClient , DryRunServer } {
is := assert . New ( t )
is := assert . New ( t )
instAction := installAction ( t )
instAction := installAction ( t )
instAction . DryRun = true
instAction . DryRunStrategy = dryRunStrategy
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withSampleTemplates ( ) ) , vals )
res i , err := instAction . Run ( buildChart ( withSampleTemplates ( ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/hello\nhello: world" )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/hello\nhello: world" )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/goodbye\ngoodbye: world" )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/goodbye\ngoodbye: world" )
@ -379,18 +410,21 @@ func TestInstallRelease_DryRun(t *testing.T) {
is . True ( res . Hooks [ 0 ] . LastRun . CompletedAt . IsZero ( ) , "expect hook to not be marked as run" )
is . True ( res . Hooks [ 0 ] . LastRun . CompletedAt . IsZero ( ) , "expect hook to not be marked as run" )
is . Equal ( res . Info . Description , "Dry run complete" )
is . Equal ( res . Info . Description , "Dry run complete" )
}
}
}
func TestInstallRelease_DryRunHiddenSecret ( t * testing . T ) { func TestInstallRelease_DryRunHiddenSecret ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
instAction := installAction ( t )
instAction := installAction ( t )
// First perform a normal dry-run with the secret and confirm its presence.
// First perform a normal dry-run with the secret and confirm its presence.
instAction . DryRun = true
instAction . DryRun Strategy = DryRunClient
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
res i , err := instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/secret.yaml\napiVersion: v1\nkind: Secret" )
is . Contains ( res . Manifest , "---\n# Source: hello/templates/secret.yaml\napiVersion: v1\nkind: Secret" )
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
@ -400,10 +434,12 @@ func TestInstallRelease_DryRunHiddenSecret(t *testing.T) {
// Perform a dry-run where the secret should not be present
// Perform a dry-run where the secret should not be present
instAction . HideSecret = true
instAction . HideSecret = true
vals = map [ string ] interface { } { }
vals = map [ string ] interface { } { }
res2 , err := instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
res2 i , err := instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res2 , err := releaserToV1Release ( res2i )
is . NoError ( err )
is . NotContains ( res2 . Manifest , "---\n# Source: hello/templates/secret.yaml\napiVersion: v1\nkind: Secret" )
is . NotContains ( res2 . Manifest , "---\n# Source: hello/templates/secret.yaml\napiVersion: v1\nkind: Secret" )
@ -412,7 +448,7 @@ func TestInstallRelease_DryRunHiddenSecret(t *testing.T) {
is . Equal ( res2 . Info . Description , "Dry run complete" )
is . Equal ( res2 . Info . Description , "Dry run complete" )
// Ensure there is an error when HideSecret True but not in a dry-run mode
// Ensure there is an error when HideSecret True but not in a dry-run mode
instAction . DryRun = fals e
instAction . DryRun Strategy = DryRunNon e
vals = map [ string ] interface { } { }
vals = map [ string ] interface { } { }
_ , err = instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
_ , err = instAction . Run ( buildChart ( withSampleSecret ( ) , withSampleTemplates ( ) ) , vals )
if err == nil {
if err == nil {
@ -424,19 +460,22 @@ func TestInstallRelease_DryRunHiddenSecret(t *testing.T) {
func TestInstallRelease_DryRun_Lookup ( t * testing . T ) { func TestInstallRelease_DryRun_Lookup ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
instAction := installAction ( t )
instAction := installAction ( t )
instAction . DryRun = tru e
instAction . DryRun Strategy = DryRunNon e
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
mockChart := buildChart ( withSampleTemplates ( ) )
mockChart := buildChart ( withSampleTemplates ( ) )
mockChart . Templates = append ( mockChart . Templates , & common . File {
mockChart . Templates = append ( mockChart . Templates , & common . File {
Name : "templates/lookup" ,
Name : "templates/lookup" ,
ModTime : time . Now ( ) ,
Data : [ ] byte ( ` goodbye: {{ lookup "v1" "Namespace" "" "___" }} ` ) ,
Data : [ ] byte ( ` goodbye: {{ lookup "v1" "Namespace" "" "___" }} ` ) ,
} )
} )
res , err := instAction . Run ( mockChart , vals )
res i , err := instAction . Run ( mockChart , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Manifest , "goodbye: map[]" )
is . Contains ( res . Manifest , "goodbye: map[]" )
} }
@ -444,7 +483,7 @@ func TestInstallRelease_DryRun_Lookup(t *testing.T) {
func TestInstallReleaseIncorrectTemplate_DryRun ( t * testing . T ) { func TestInstallReleaseIncorrectTemplate_DryRun ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
instAction := installAction ( t )
instAction := installAction ( t )
instAction . DryRun = tru e
instAction . DryRun Strategy = DryRunNon e
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
_ , err := instAction . Run ( buildChart ( withSampleIncludingIncorrectTemplates ( ) ) , vals )
_ , err := instAction . Run ( buildChart ( withSampleIncludingIncorrectTemplates ( ) ) , vals )
expectedErr := ` hello / templates / incorrect : 1 : 10
expectedErr := ` hello / templates / incorrect : 1 : 10
@ -453,10 +492,8 @@ func TestInstallReleaseIncorrectTemplate_DryRun(t *testing.T) {
if err == nil {
if err == nil {
t . Fatalf ( "Install should fail containing error: %s" , expectedErr )
t . Fatalf ( "Install should fail containing error: %s" , expectedErr )
}
}
if err != nil {
is . Contains ( err . Error ( ) , expectedErr )
is . Contains ( err . Error ( ) , expectedErr )
} }
}
func TestInstallRelease_NoHooks ( t * testing . T ) { func TestInstallRelease_NoHooks ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
@ -466,10 +503,12 @@ func TestInstallRelease_NoHooks(t *testing.T) {
instAction . cfg . Releases . Create ( releaseStub ( ) )
instAction . cfg . Releases . Create ( releaseStub ( ) )
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( ) , vals )
res i , err := instAction . Run ( buildChart ( ) , vals )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . True ( res . Hooks [ 0 ] . LastRun . CompletedAt . IsZero ( ) , "hooks should not run with no-hooks" )
is . True ( res . Hooks [ 0 ] . LastRun . CompletedAt . IsZero ( ) , "hooks should not run with no-hooks" )
} }
@ -485,11 +524,13 @@ func TestInstallRelease_FailedHooks(t *testing.T) {
failer . PrintingKubeClient = kubefake . PrintingKubeClient { Out : io . Discard , LogOutput : outBuffer }
failer . PrintingKubeClient = kubefake . PrintingKubeClient { Out : io . Discard , LogOutput : outBuffer }
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( ) , vals )
res i , err := instAction . Run ( buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Info . Description , "failed post-install" )
is . Contains ( res . Info . Description , "failed post-install" )
is . Equal ( "" , outBuffer . String ( ) )
is . Equal ( "" , outBuffer . String ( ) )
is . Equal ( r elease . StatusFailed , res . Info . Status )
is . Equal ( r common . StatusFailed , res . Info . Status )
} }
func TestInstallRelease_ReplaceRelease ( t * testing . T ) { func TestInstallRelease_ReplaceRelease ( t * testing . T ) {
@ -498,21 +539,25 @@ func TestInstallRelease_ReplaceRelease(t *testing.T) {
instAction . Replace = true
instAction . Replace = true
rel := releaseStub ( )
rel := releaseStub ( )
rel . Info . Status = r elease . StatusUninstalled
rel . Info . Status = r common . StatusUninstalled
instAction . cfg . Releases . Create ( rel )
instAction . cfg . Releases . Create ( rel )
instAction . ReleaseName = rel . Name
instAction . ReleaseName = rel . Name
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( ) , vals )
resi , err := instAction . Run ( buildChart ( ) , vals )
is . NoError ( err )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . NoError ( err )
// This should have been auto-incremented
// This should have been auto-incremented
is . Equal ( 2 , res . Version )
is . Equal ( 2 , res . Version )
is . Equal ( res . Name , rel . Name )
is . Equal ( res . Name , rel . Name )
getres , err := instAction . cfg . Releases . Get ( rel . Name , res . Version )
r , err := instAction . cfg . Releases . Get ( rel . Name , res . Version )
is . NoError ( err )
getres , err := releaserToV1Release ( r )
is . NoError ( err )
is . NoError ( err )
is . Equal ( getres . Info . Status , release . StatusDeployed )
is . Equal ( getres . Info . Status , r common . StatusDeployed )
} }
func TestInstallRelease_KubeVersion ( t * testing . T ) { func TestInstallRelease_KubeVersion ( t * testing . T ) {
@ -540,14 +585,16 @@ func TestInstallRelease_Wait(t *testing.T) {
instAction . WaitStrategy = kube . StatusWatcherStrategy
instAction . WaitStrategy = kube . StatusWatcherStrategy
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
goroutines := runtime. NumGoroutine ( )
goroutines := instAction. getGoroutineCount ( )
res , err := instAction . Run ( buildChart ( ) , vals )
res i , err := instAction . Run ( buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Info . Description , "I timed out" )
is . Contains ( res . Info . Description , "I timed out" )
is . Equal ( res . Info . Status , release . StatusFailed )
is . Equal ( res . Info . Status , r common . StatusFailed )
is . Equal ( goroutines , runtime. NumGoroutine ( ) )
is . Equal ( goroutines , instAction. getGoroutineCount ( ) )
} }
func TestInstallRelease_Wait_Interrupted ( t * testing . T ) { func TestInstallRelease_Wait_Interrupted ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
@ -562,15 +609,15 @@ func TestInstallRelease_Wait_Interrupted(t *testing.T) {
ctx , cancel := context . WithCancel ( t . Context ( ) )
ctx , cancel := context . WithCancel ( t . Context ( ) )
time . AfterFunc ( time . Second , cancel )
time . AfterFunc ( time . Second , cancel )
goroutines := runtime. NumGoroutine ( )
goroutines := instAction. getGoroutineCount ( )
_ , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
_ , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
is . Contains ( err . Error ( ) , "context canceled" )
is . Contains ( err . Error ( ) , "context canceled" )
is . Equal ( goroutines + 1 , runtime. NumGoroutine ( ) ) // installation goroutine still is in background
is . Equal ( goroutines + 1 , instAction. getGoroutineCount ( ) ) // installation goroutine still is in background
time . Sleep ( 10 * time . Second ) // wait for goroutine to finish
time . Sleep ( 10 * time . Second ) // wait for goroutine to finish
is . Equal ( goroutines , runtime. NumGoroutine ( ) )
is . Equal ( goroutines , instAction. getGoroutineCount ( ) )
} }
func TestInstallRelease_WaitForJobs ( t * testing . T ) { func TestInstallRelease_WaitForJobs ( t * testing . T ) {
is := assert . New ( t )
is := assert . New ( t )
@ -583,10 +630,12 @@ func TestInstallRelease_WaitForJobs(t *testing.T) {
instAction . WaitForJobs = true
instAction . WaitForJobs = true
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( ) , vals )
res i , err := instAction . Run ( buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Contains ( res . Info . Description , "I timed out" )
is . Contains ( res . Info . Description , "I timed out" )
is . Equal ( res . Info . Status , release . StatusFailed )
is . Equal ( res . Info . Status , r common . StatusFailed )
} }
func TestInstallRelease_RollbackOnFailure ( t * testing . T ) { func TestInstallRelease_RollbackOnFailure ( t * testing . T ) {
@ -604,11 +653,13 @@ func TestInstallRelease_RollbackOnFailure(t *testing.T) {
instAction . DisableHooks = true
instAction . DisableHooks = true
vals := map [ string ] interface { } { }
vals := map [ string ] interface { } { }
res , err := instAction . Run ( buildChart ( ) , vals )
res i , err := instAction . Run ( buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
is . Contains ( err . Error ( ) , "I timed out" )
is . Contains ( err . Error ( ) , "I timed out" )
is . Contains ( err . Error ( ) , "rollback-on-failure" )
is . Contains ( err . Error ( ) , "rollback-on-failure" )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
// Now make sure it isn't in storage anymore
// Now make sure it isn't in storage anymore
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
is . Error ( err )
is . Error ( err )
@ -646,21 +697,23 @@ func TestInstallRelease_RollbackOnFailure_Interrupted(t *testing.T) {
ctx , cancel := context . WithCancel ( t . Context ( ) )
ctx , cancel := context . WithCancel ( t . Context ( ) )
time . AfterFunc ( time . Second , cancel )
time . AfterFunc ( time . Second , cancel )
goroutines := runtime. NumGoroutine ( )
goroutines := instAction. getGoroutineCount ( )
res , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
res i , err := instAction . RunWithContext ( ctx , buildChart ( ) , vals )
is . Error ( err )
is . Error ( err )
is . Contains ( err . Error ( ) , "context canceled" )
is . Contains ( err . Error ( ) , "context canceled" )
is . Contains ( err . Error ( ) , "rollback-on-failure" )
is . Contains ( err . Error ( ) , "rollback-on-failure" )
is . Contains ( err . Error ( ) , "uninstalled" )
is . Contains ( err . Error ( ) , "uninstalled" )
res , err := releaserToV1Release ( resi )
is . NoError ( err )
// Now make sure it isn't in storage anymore
// Now make sure it isn't in storage anymore
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
_ , err = instAction . cfg . Releases . Get ( res . Name , res . Version )
is . Error ( err )
is . Error ( err )
is . Equal ( err , driver . ErrReleaseNotFound )
is . Equal ( err , driver . ErrReleaseNotFound )
is . Equal ( goroutines + 1 , runtime. NumGoroutine ( ) ) // installation goroutine still is in background
is . Equal ( goroutines + 1 , instAction. getGoroutineCount ( ) ) // installation goroutine still is in background
time . Sleep ( 10 * time . Second ) // wait for goroutine to finish
time . Sleep ( 10 * time . Second ) // wait for goroutine to finish
is . Equal ( goroutines , runtime. NumGoroutine ( ) )
is . Equal ( goroutines , instAction. getGoroutineCount ( ) )
} }
func TestNameTemplate ( t * testing . T ) { func TestNameTemplate ( t * testing . T ) {
@ -859,32 +912,32 @@ func TestNameAndChartGenerateName(t *testing.T) {
{
{
"local filepath" ,
"local filepath" ,
"./chart" ,
"./chart" ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
{
{
"dot filepath" ,
"dot filepath" ,
"." ,
"." ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
{
{
"empty filepath" ,
"empty filepath" ,
"" ,
"" ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
{
{
"packaged chart" ,
"packaged chart" ,
"chart.tgz" ,
"chart.tgz" ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
{
{
"packaged chart with .tar.gz extension" ,
"packaged chart with .tar.gz extension" ,
"chart.tar.gz" ,
"chart.tar.gz" ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
{
{
"packaged chart with local extension" ,
"packaged chart with local extension" ,
"./chart.tgz" ,
"./chart.tgz" ,
fmt . Sprintf ( "chart-%d" , helm time. Now ( ) . Unix ( ) ) ,
fmt . Sprintf ( "chart-%d" , . Now ( ) . Unix ( ) ) ,
} ,
} ,
}
}
@ -910,10 +963,12 @@ func TestInstallWithLabels(t *testing.T) {
"key1" : "val1" ,
"key1" : "val1" ,
"key2" : "val2" ,
"key2" : "val2" ,
}
}
res , err := instAction . Run ( buildChart ( ) , nil )
res i , err := instAction . Run ( buildChart ( ) , nil )
if err != nil {
if err != nil {
t . Fatalf ( "Failed install: %s" , err )
t . Fatalf ( "Failed install: %s" , err )
}
}
res , err := releaserToV1Release ( resi )
is . NoError ( err )
is . Equal ( instAction . Labels , res . Labels )
is . Equal ( instAction . Labels , res . Labels )
} }
@ -997,3 +1052,19 @@ func TestUrlEqual(t *testing.T) {
} )
} )
}
}
} }
func TestInstallRun_UnreachableKubeClient ( t * testing . T ) {
config := actionConfigFixture ( t )
failingKubeClient := kubefake . FailingKubeClient { PrintingKubeClient : kubefake . PrintingKubeClient { Out : io . Discard } , DummyResources : nil }
failingKubeClient . ConnectionError = errors . New ( "connection refused" )
config . KubeClient = & failingKubeClient
instAction := NewInstall ( config )
ctx , done := context . WithCancel ( t . Context ( ) )
chrt := buildChart ( )
res , err := instAction . RunWithContext ( ctx , chrt , nil )
done ( )
assert . Nil ( t , res )
assert . ErrorContains ( t , err , "connection refused" )
}
Benoit Tigeot
11 months ago
committed by
Benoit Tigeot