Merge pull request #31060 from yumeiyin/main

refactor: replace Split in loops with more efficient SplitSeq

pkg/chart/v2/util/dependencies.go

@@ -38,7 +38,7 @@ func processDependencyConditions(reqs []*chart.Dependency, cvals Values, cpath s
 		return
 	}
 	for _, r := range reqs {
-		for _, c := range strings.Split(strings.TrimSpace(r.Condition), ",") {
+		for c := range strings.SplitSeq(strings.TrimSpace(r.Condition), ",") {
 			if len(c) > 0 {
 				// retrieve value
 				vv, err := cvals.PathValue(cpath + c)

pkg/cmd/load_plugins.go

@@ -350,7 +350,7 @@ func pluginDynamicComp(plug *plugin.Plugin, cmd *cobra.Command, args []string, t
 	}
 
 	var completions []string
-	for _, comp := range strings.Split(buf.String(), "\n") {
+	for comp := range strings.SplitSeq(buf.String(), "\n") {
 		// Remove any empty lines
 		if len(comp) > 0 {
 			completions = append(completions, comp)

pkg/release/util/manifest_sorter.go

@@ -185,7 +185,7 @@ func (file *manifestFile) sort(result *result) error {
 		}
 
 		isUnknownHook := false
-		for _, hookType := range strings.Split(hookTypes, ",") {
+		for hookType := range strings.SplitSeq(hookTypes, ",") {
 			hookType = strings.ToLower(strings.TrimSpace(hookType))
 			e, ok := events[hookType]
 			if !ok {
@@ -236,7 +236,7 @@ func calculateHookWeight(entry SimpleHead) int {
 // operateAnnotationValues finds the given annotation and runs the operate function with the value of that annotation
 func operateAnnotationValues(entry SimpleHead, annotation string, operate func(p string)) {
 	if dps, ok := entry.Metadata.Annotations[annotation]; ok {
-		for _, dp := range strings.Split(dps, ",") {
+		for dp := range strings.SplitSeq(dps, ",") {
 			dp = strings.ToLower(strings.TrimSpace(dp))
 			operate(dp)
 		}