msb-public
/
helm
mirror of https://github.com/helm/helm
1
0
Code Issues Projects Releases Wiki Activity

fix: use semantic versioning in tests and enrich them

Browse Source 
Signed-off-by: canardleteer <eris.has.a.dad+github@gmail.com>
pull/30512/head
canardleteer 8 months ago
parent 259b311815
commit 878f52b883
1 changed files with 45 additions and 15 deletions
Show Stats Download Patch File Download Diff File

60
pkg/chart/metadata_test.go
Unescape View File

@ -32,17 +32,17 @@ func TestValidate(t *testing.T) {
}, },
{ {
"chart without apiVersion", "chart without apiVersion",
&Metadata{Name: "test", Version: "1.0"}, &Metadata{Name: "test", Version: "1.0.0"},
ValidationError("chart.metadata.apiVersion is required"), ValidationError("chart.metadata.apiVersion is required"),
}, },
{ {
"chart without name", "chart without name",
&Metadata{APIVersion: "v2", Version: "1.0"}, &Metadata{APIVersion: "v2", Version: "1.0.0"},
ValidationError("chart.metadata.name is required"), ValidationError("chart.metadata.name is required"),
}, },
{ {
"chart without name", "chart without name",
&Metadata{Name: "../../test", APIVersion: "v2", Version: "1.0"}, &Metadata{Name: "../../test", APIVersion: "v2", Version: "1.0.0"},
ValidationError("chart.metadata.name \"../../test\" is invalid"), ValidationError("chart.metadata.name \"../../test\" is invalid"),
}, },
{ {
@ -52,12 +52,12 @@ func TestValidate(t *testing.T) {
}, },
{ {
"chart with bad type", "chart with bad type",
&Metadata{Name: "test", APIVersion: "v2", Version: "1.0", Type: "test"}, &Metadata{Name: "test", APIVersion: "v2", Version: "1.0.0", Type: "test"},
ValidationError("chart.metadata.type must be application or library"), ValidationError("chart.metadata.type must be application or library"),
}, },
{ {
"chart without dependency", "chart without dependency",
&Metadata{Name: "test", APIVersion: "v2", Version: "1.0", Type: "application"}, &Metadata{Name: "test", APIVersion: "v2", Version: "1.0.0", Type: "application"},
nil, nil,
}, },
{ {
@ -65,7 +65,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "dependency", Alias: "legal-alias"}, {Name: "dependency", Alias: "legal-alias"},
@ -78,7 +78,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "bad", Alias: "illegal alias"}, {Name: "bad", Alias: "illegal alias"},
@ -91,7 +91,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "foo", Alias: ""}, {Name: "foo", Alias: ""},
@ -105,7 +105,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "foo", Alias: ""}, {Name: "foo", Alias: ""},
@ -121,7 +121,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "foo", Alias: "", Version: "1.2.3"}, {Name: "foo", Alias: "", Version: "1.2.3"},
@ -137,7 +137,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
{Name: "foo", Repository: "repo-0"}, {Name: "foo", Repository: "repo-0"},
@ -151,7 +151,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Dependencies: []*Dependency{ Dependencies: []*Dependency{
nil, nil,
@ -164,7 +164,7 @@ func TestValidate(t *testing.T) {
&Metadata{ &Metadata{
Name: "test", Name: "test",
APIVersion: "v2", APIVersion: "v2",
Version: "1.0", Version: "1.0.0",
Type: "application", Type: "application",
Maintainers: []*Maintainer{ Maintainers: []*Maintainer{
nil, nil,
@ -173,7 +173,37 @@ func TestValidate(t *testing.T) {
ValidationError("maintainers must not contain empty or null nodes"), ValidationError("maintainers must not contain empty or null nodes"),
}, },
{ {
"version invalid", "valid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "1.2.3-7"},
nil,
},
{
"valid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "1.0.0-branch.0"},
nil,
},
{
"valid but rediculous semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "99.3.3-rc2.-1.0.ab"},
nil,
},
{
"invalid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "-1.0.0"},
ValidationError("chart.metadata.version \"-1.0.0\" is invalid"),
},
{
"invalid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "1"},
ValidationError("chart.metadata.version \"1\" is invalid"),
},
{
"invalid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "1.0"},
ValidationError("chart.metadata.version \"1.0\" is invalid"),
},
{
"invalid semver",
&Metadata{APIVersion: "v2", Name: "test", Version: "1.2.3.4"}, &Metadata{APIVersion: "v2", Name: "test", Version: "1.2.3.4"},
ValidationError("chart.metadata.version \"1.2.3.4\" is invalid"), ValidationError("chart.metadata.version \"1.2.3.4\" is invalid"),
}, },
@ -188,7 +218,7 @@ func TestValidate(t *testing.T) {
} }
func TestValidate_sanitize(t *testing.T) { func TestValidate_sanitize(t *testing.T) {
md := &Metadata{APIVersion: "v2", Name: "test", Version: "1.0", Description: "\adescr\u0081iption\rtest", Maintainers: []*Maintainer{{Name: "\r"}}} md := &Metadata{APIVersion: "v2", Name: "test", Version: "1.0.0", Description: "\adescr\u0081iption\rtest", Maintainers: []*Maintainer{{Name: "\r"}}}
if err := md.Validate(); err != nil { if err := md.Validate(); err != nil {
t.Fatalf("unexpected error: %s", err) t.Fatalf("unexpected error: %s", err)
} }

Write Preview
Loading…
Cancel
Save