Merge pull request #3491 from oilbeater/fix-defer-in-loop

defer in loop may cause resource leak
pull/3449/merge
Matthew Fisher 8 years ago committed by GitHub
commit 86ae040bfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -63,11 +63,12 @@ func Expand(dir string, r io.Reader) error {
if err != nil { if err != nil {
return err return err
} }
defer file.Close()
_, err = io.Copy(file, tr) _, err = io.Copy(file, tr)
if err != nil { if err != nil {
file.Close()
return err return err
} }
file.Close()
} }
return nil return nil
} }

Loading…
Cancel
Save