Fix codestyle and update docs

Signed-off-by: Alexander Nesterenko <nestorf250@gmail.com>

cmd/helm/install.go

@@ -323,7 +323,9 @@ func (i *installCmd) run() error {
 				out:          i.out,
 				client:       i.client,
 			}
-			if err := deleteSideEffects.run(); err != nil { return err }
+			if err := deleteSideEffects.run(); err != nil {
+				return err
+			}
 		}
 		return prettyError(err)
 	}

cmd/helm/upgrade.go

@@ -275,9 +275,9 @@ func (u *upgradeCmd) run() error {
 		helm.UpgradeWait(u.wait),
 		helm.UpgradeDescription(u.description))
 	if err != nil {
-		fmt.Fprintf(u.out, "UPGRADE FAILED\nROLLING BACK\nError: %v", prettyError(err))
+		fmt.Fprintf(u.out, "UPGRADE FAILED\nROLLING BACK\nError: %v\n", prettyError(err))
 		if u.safe {
-			rollback := &rollbackCmd {
+			rollback := &rollbackCmd{
 				out:          u.out,
 				client:       u.client,
 				name:         u.release,
@@ -290,9 +290,11 @@ func (u *upgradeCmd) run() error {
 				revision:     releaseHistory.Releases[0].Version,
 				disableHooks: u.disableHooks,
 			}
-			if err := rollback.run(); err != nil { return err }
+			if err := rollback.run(); err != nil {
+				return err
+			}
 		}
-		return fmt.Errorf("UPGRADE FAILED: %v\n", prettyError(err))
+		return fmt.Errorf("UPGRADE FAILED: %v", prettyError(err))
 	}
 
 	if settings.Debug {

docs/helm/helm_install.md

@@ -96,6 +96,7 @@ helm install [CHART] [flags]
       --render-subchart-notes    render subchart notes along with the parent
       --replace                  re-use the given name, even if that name is already used. This is unsafe in production
       --repo string              chart repository url where to locate the requested chart
+      --safe                     if set, upgrade process rolls back changes made in case of failed upgrade
       --set stringArray          set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
       --set-file stringArray     set values from respective files specified via the command line (can specify multiple or separate values with commas: key1=path1,key2=path2)
       --set-string stringArray   set STRING values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
@@ -129,4 +130,4 @@ helm install [CHART] [flags]
 
 * [helm](helm.md)	 - The Helm package manager for Kubernetes.
 
-###### Auto generated by spf13/cobra on 1-Nov-2018
+###### Auto generated by spf13/cobra on 9-Jan-2019

docs/helm/helm_upgrade.md

@@ -19,7 +19,7 @@ To customize the chart values, use any of
  - '--set-string' to provide key=val forcing val to be stored as a string,
  - '--set-file' to provide key=path to read a single large value from a file at path.
 
-To edit or append to the existing customized values, add the 
+To edit or append to the existing customized values, add the
  '--reuse-values' flag, otherwise any existing customized values are ignored.
 
 If no chart value arguments are provided on the command line, any existing customized values are carried
@@ -83,6 +83,7 @@ helm upgrade [RELEASE] [CHART] [flags]
       --repo string              chart repository url where to locate the requested chart
       --reset-values             when upgrading, reset the values to the ones built into the chart
       --reuse-values             when upgrading, reuse the last release's values and merge in any overrides from the command line via --set and -f. If '--reset-values' is specified, this is ignored.
+      --safe                     if set, upgrade process rolls back changes made in case of failed upgrade
       --set stringArray          set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
       --set-file stringArray     set values from respective files specified via the command line (can specify multiple or separate values with commas: key1=path1,key2=path2)
       --set-string stringArray   set STRING values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)
@@ -116,4 +117,4 @@ helm upgrade [RELEASE] [CHART] [flags]
 
 * [helm](helm.md)	 - The Helm package manager for Kubernetes.
 
-###### Auto generated by spf13/cobra on 1-Nov-2018
+###### Auto generated by spf13/cobra on 9-Jan-2019