Fix a bug in storage/driver/secrets.go

Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>

pkg/storage/driver/secrets.go

@@ -186,7 +186,7 @@ func (secrets *Secrets) Delete(key string) (rls *rspb.Release, err error) {
 	// fetch the release to check existence
 	if rls, err = secrets.Get(key); err != nil {
 		if apierrors.IsNotFound(err) {
-			return nil, ErrReleaseExists
+			return nil, ErrReleaseNotFound
 		}
 
 		return nil, errors.Wrapf(err, "delete: failed to get release %q", key)

pkg/storage/driver/secrets_test.go

@@ -194,6 +194,12 @@ func TestSecretDelete(t *testing.T) {
 
 	secrets := newTestFixtureSecrets(t, []*rspb.Release{rel}...)
 
+	// perform the delete on a non-existing release
+	_, err := secrets.Delete("nonexistent")
+	if err != ErrReleaseNotFound {
+		t.Fatalf("Expected ErrReleaseNotFound, got: {%v}", err)
+	}
+
 	// perform the delete
 	rls, err := secrets.Delete(key)
 	if err != nil {