Rename newly introduced interface to InterfaceExt

Signed-off-by: Mike Ng <ming@redhat.com>
pull/9702/head
Mike Ng 4 years ago
parent d51a61f9ab
commit 75fe8883cc

@ -120,7 +120,7 @@ func (u *Uninstall) Run(name string) (*release.UninstallReleaseResponse, error)
res.Info = kept res.Info = kept
if u.Wait { if u.Wait {
if kubeClient, ok := u.cfg.KubeClient.(kube.ClientInterface); ok { if kubeClient, ok := u.cfg.KubeClient.(kube.InterfaceExt); ok {
if err := kubeClient.WaitForDelete(deletedResources, u.Timeout); err != nil { if err := kubeClient.WaitForDelete(deletedResources, u.Timeout); err != nil {
errs = append(errs, err) errs = append(errs, err)
} }

@ -70,13 +70,13 @@ type Interface interface {
IsReachable() error IsReachable() error
} }
// ClientInterface is introduced to avoid breaking backwards compatibility for Interface implementers. // InterfaceExt is introduced to avoid breaking backwards compatibility for Interface implementers.
// //
// TODO Helm 4: Remove ClientInterface and integrate its method(s) into the Interface. // TODO Helm 4: Remove InterfaceExt and integrate its method(s) into the Interface.
type ClientInterface interface { type InterfaceExt interface {
// WaitForDelete wait up to the given timeout for the specified resources to be deleted. // WaitForDelete wait up to the given timeout for the specified resources to be deleted.
WaitForDelete(resources ResourceList, timeout time.Duration) error WaitForDelete(resources ResourceList, timeout time.Duration) error
} }
var _ Interface = (*Client)(nil) var _ Interface = (*Client)(nil)
var _ ClientInterface = (*Client)(nil) var _ InterfaceExt = (*Client)(nil)

Loading…
Cancel
Save