Ensure `helm test --logs` only gets logs from pods

Signed-off-by: Akshay Mankar <itsakshaymankar@gmail.com>
pull/11777/head
Akshay Mankar 3 years ago
parent 76157c6d06
commit 61c29eb5e7

@ -108,19 +108,21 @@ func (r *ReleaseTesting) GetPodLogs(out io.Writer, rel *release.Release) error {
} }
for _, h := range rel.Hooks { for _, h := range rel.Hooks {
for _, e := range h.Events { if h.Kind == "Pod" {
if e == release.HookTest { for _, e := range h.Events {
req := client.CoreV1().Pods(r.Namespace).GetLogs(h.Name, &v1.PodLogOptions{}) if e == release.HookTest {
logReader, err := req.Stream(context.Background()) req := client.CoreV1().Pods(r.Namespace).GetLogs(h.Name, &v1.PodLogOptions{})
if err != nil { logReader, err := req.Stream(context.Background())
return errors.Wrapf(err, "unable to get pod logs for %s", h.Name) if err != nil {
} return errors.Wrapf(err, "unable to get pod logs for %s", h.Name)
}
fmt.Fprintf(out, "POD LOGS: %s\n", h.Name)
_, err = io.Copy(out, logReader) fmt.Fprintf(out, "POD LOGS: %s\n", h.Name)
fmt.Fprintln(out) _, err = io.Copy(out, logReader)
if err != nil { fmt.Fprintln(out)
return errors.Wrapf(err, "unable to write pod logs for %s", h.Name) if err != nil {
return errors.Wrapf(err, "unable to write pod logs for %s", h.Name)
}
} }
} }
} }

Loading…
Cancel
Save