fix(helm): pass the no-hooks flag during upgrade

Helm upgrades were not passing the no-hooks value to the server.

Closes #1590
pull/1599/head
Matt Butcher 8 years ago
parent 7a15ad381e
commit 5f3d255ecd
No known key found for this signature in database
GPG Key ID: DCD5F5E5EF32C345

@ -135,7 +135,12 @@ func (u *upgradeCmd) run() error {
return err return err
} }
_, err = u.client.UpdateRelease(u.release, chartPath, helm.UpdateValueOverrides(rawVals), helm.UpgradeDryRun(u.dryRun), helm.UpgradeDisableHooks(u.disableHooks)) _, err = u.client.UpdateRelease(
u.release,
chartPath,
helm.UpdateValueOverrides(rawVals),
helm.UpgradeDryRun(u.dryRun),
helm.UpgradeDisableHooks(u.disableHooks))
if err != nil { if err != nil {
return fmt.Errorf("UPGRADE FAILED: %v", prettyError(err)) return fmt.Errorf("UPGRADE FAILED: %v", prettyError(err))
} }

@ -132,6 +132,7 @@ func (h *Client) UpdateRelease(rlsName string, chstr string, opts ...UpdateOptio
req.Chart = chart req.Chart = chart
req.DryRun = h.opts.dryRun req.DryRun = h.opts.dryRun
req.Name = rlsName req.Name = rlsName
req.DisableHooks = h.opts.disableHooks
ctx := NewContext() ctx := NewContext()
if h.opts.before != nil { if h.opts.before != nil {

Loading…
Cancel
Save