Merge pull request #32235 from TerryHowe/fix/testifylint-empty-assertions

test: use assert.Empty for zero-length assertions in validate_test
pull/32237/head
George Jenkins 3 months ago committed by GitHub
commit 5b1fc3bbf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -237,7 +237,7 @@ func TestVerifyOwnershipBeforeDelete(t *testing.T) {
ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace) ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, ownedList, 2) assert.Len(t, ownedList, 2)
assert.Len(t, unownedList, 0) assert.Empty(t, unownedList)
}) })
// Test mix of owned and unowned resources // Test mix of owned and unowned resources
@ -261,8 +261,8 @@ func TestVerifyOwnershipBeforeDelete(t *testing.T) {
ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace) ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, ownedList, 0) assert.Empty(t, ownedList)
assert.Len(t, unownedList, 0) assert.Empty(t, unownedList)
}) })
// Test resource with no ownership metadata // Test resource with no ownership metadata
@ -272,7 +272,7 @@ func TestVerifyOwnershipBeforeDelete(t *testing.T) {
ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace) ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, ownedList, 0) assert.Empty(t, ownedList)
assert.Len(t, unownedList, 1) assert.Len(t, unownedList, 1)
}) })
@ -283,7 +283,7 @@ func TestVerifyOwnershipBeforeDelete(t *testing.T) {
ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace) ownedList, unownedList, _, err := verifyOwnershipBeforeDelete(resources, releaseName, releaseNamespace)
assert.NoError(t, err) assert.NoError(t, err)
assert.Len(t, ownedList, 0) assert.Empty(t, ownedList)
assert.Len(t, unownedList, 1) assert.Len(t, unownedList, 1)
}) })

Loading…
Cancel
Save