feat(get-dependencies): Feedback Github (#8081)

Signed-off-by: Ilan Zerath <ilan.prims@gmail.com>
pull/8190/head
Ilan Zerath 5 years ago
parent 2bcf089ffd
commit 543a784d57

@ -37,7 +37,6 @@ type dependencyElement struct {
Name string `json:"name"`
Version string `json:"version,omitempty"`
Repository string `json:"repository"`
Enabled bool `json:"enabled,omitempty"`
}
type dependencyListWriter struct {
@ -99,7 +98,6 @@ func newDependenciesListWriter(dependencies []*chart.Dependency) *dependencyList
Name: d.Name,
Version: d.Version,
Repository: d.Repository,
Enabled: d.Enabled,
}
elements = append(elements, element)
@ -111,10 +109,10 @@ func newDependenciesListWriter(dependencies []*chart.Dependency) *dependencyList
func (d dependencyListWriter) WriteTable(out io.Writer) error {
table := uitable.New()
table.AddRow("NAME", "VERSION", "REPOSITORY", "ENABLED")
table.AddRow("NAME", "VERSION", "REPOSITORY")
for _, r := range d.dependencies {
table.AddRow(r.Name, r.Version, r.Repository, r.Enabled)
table.AddRow(r.Name, r.Version, r.Repository)
}
return output.EncodeTable(out, table)

@ -36,8 +36,8 @@ func TestGetDependencies(t *testing.T) {
Version: "4.7.7-beta.1",
AppVersion: "1.0",
Dependencies: []*chart.Dependency{
{Name: "fuego", Version: "7.7.0", Repository: "https://prims47-fuego.com", Enabled: true},
{Name: "pepito", Version: "4.2.7'", Repository: "https://pepito.com", Enabled: true},
{Name: "fuego", Version: "7.7.0", Repository: "https://prims47-fuego.com"},
{Name: "pepito", Version: "4.2.7'", Repository: "https://pepito.com"},
},
},
Templates: []*chart.File{

@ -1 +1 @@
NAME VERSION REPOSITORY ENABLED
NAME VERSION REPOSITORY

@ -1 +1 @@
[{"name":"fuego","version":"7.7.0","repository":"https://prims47-fuego.com","enabled":true},{"name":"pepito","version":"4.2.7'","repository":"https://pepito.com","enabled":true}]
[{"name":"fuego","version":"7.7.0","repository":"https://prims47-fuego.com"},{"name":"pepito","version":"4.2.7'","repository":"https://pepito.com"}]

@ -1,3 +1,3 @@
NAME VERSION REPOSITORY ENABLED
fuego 7.7.0 https://prims47-fuego.com true
pepito 4.2.7' https://pepito.com true
NAME VERSION REPOSITORY
fuego 7.7.0 https://prims47-fuego.com
pepito 4.2.7' https://pepito.com

@ -1,8 +1,6 @@
- enabled: true
name: fuego
- name: fuego
repository: https://prims47-fuego.com
version: 7.7.0
- enabled: true
name: pepito
- name: pepito
repository: https://pepito.com
version: 4.2.7'

Loading…
Cancel
Save