Merge pull request #13494 from helm/rm_deprecated_repo_add_no_update_flag

Remove deprecated `repo add --no-update` flag

cmd/helm/repo_add.go

@@ -59,9 +59,6 @@ type repoAddOptions struct {
 
 	repoFile  string
 	repoCache string
-
-	// Deprecated, but cannot be removed until Helm 4
-	deprecatedNoUpdate bool
 }
 
 func newRepoAddCmd(out io.Writer) *cobra.Command {
@@ -92,7 +89,6 @@ func newRepoAddCmd(out io.Writer) *cobra.Command {
 	f.StringVar(&o.password, "password", "", "chart repository password")
 	f.BoolVarP(&o.passwordFromStdinOpt, "password-stdin", "", false, "read chart repository password from stdin")
 	f.BoolVar(&o.forceUpdate, "force-update", false, "replace (overwrite) the repo if it already exists")
-	f.BoolVar(&o.deprecatedNoUpdate, "no-update", false, "Ignored. Formerly, it would disabled forced updates. It is deprecated by force-update.")
 	f.StringVar(&o.certFile, "cert-file", "", "identify HTTPS client using this SSL certificate file")
 	f.StringVar(&o.keyFile, "key-file", "", "identify HTTPS client using this SSL key file")
 	f.StringVar(&o.caFile, "ca-file", "", "verify certificates of HTTPS-enabled servers using this CA bundle")

cmd/helm/repo_add_test.go

@@ -96,7 +96,6 @@ func TestRepoAdd(t *testing.T) {
 		name:        testRepoName,
 		url:         ts.URL(),
 		forceUpdate: false,
-		deprecatedNoUpdate: true,
 		repoFile:    repoFile,
 	}
 	os.Setenv(xdg.CacheHomeEnvVar, rootDir)
@@ -151,7 +150,6 @@ func TestRepoAddCheckLegalName(t *testing.T) {
 		name:        testRepoName,
 		url:         ts.URL(),
 		forceUpdate: false,
-		deprecatedNoUpdate: true,
 		repoFile:    repoFile,
 	}
 	os.Setenv(xdg.CacheHomeEnvVar, rootDir)
@@ -206,7 +204,6 @@ func repoAddConcurrent(t *testing.T, testName, repoFile string) {
 			o := &repoAddOptions{
 				name:        name,
 				url:         ts.URL(),
-				deprecatedNoUpdate: true,
 				forceUpdate: false,
 				repoFile:    repoFile,
 			}