fix(action): clarify Configuration copy comment for copylocks

Signed-off-by: Dean Chen <862469039@qq.com>
pull/32431/head
Dean Chen 4 weeks ago
parent 8ac25c5c8d
commit 42ffcd3a72
No known key found for this signature in database
GPG Key ID: 03656C0AA9B7E279

@ -333,8 +333,8 @@ func (i *Install) RunWithContext(ctx context.Context, ch ci.Charter, vals map[st
// Callers that reuse the same cfg for a later real install must
// still observe the original client and storage. See #11463.
//
// Copy fields explicitly: Configuration embeds sync.Mutex and
// logging.LogHolder (atomic.Pointer), which must not be copied
// Copy exported fields only. Configuration has an unexported mutex and
// embeds logging.LogHolder (atomic.Pointer); both must not be copied
// by value (govet copylocks).
origCfg := i.cfg
cfgCopy := &Configuration{

Loading…
Cancel
Save