From 42ffcd3a72a006575335275d8c790019bc03fb06 Mon Sep 17 00:00:00 2001 From: Dean Chen <862469039@qq.com> Date: Thu, 13 Aug 2026 00:47:33 +0500 Subject: [PATCH] fix(action): clarify Configuration copy comment for copylocks Signed-off-by: Dean Chen <862469039@qq.com> --- pkg/action/install.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/action/install.go b/pkg/action/install.go index b00ec6d88..37cbd387c 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -333,8 +333,8 @@ func (i *Install) RunWithContext(ctx context.Context, ch ci.Charter, vals map[st // Callers that reuse the same cfg for a later real install must // still observe the original client and storage. See #11463. // - // Copy fields explicitly: Configuration embeds sync.Mutex and - // logging.LogHolder (atomic.Pointer), which must not be copied + // Copy exported fields only. Configuration has an unexported mutex and + // embeds logging.LogHolder (atomic.Pointer); both must not be copied // by value (govet copylocks). origCfg := i.cfg cfgCopy := &Configuration{