fix(get): hard code DESIRED_VERSION when unset

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
pull/6953/head
Matthew Fisher 5 years ago
parent d8a32d6ddb
commit 3e77ca22c7
No known key found for this signature in database
GPG Key ID: 92AA783CBAAE8E3B

@ -78,13 +78,16 @@ verifySupported() {
# checkDesiredVersion checks if the desired version is available. # checkDesiredVersion checks if the desired version is available.
checkDesiredVersion() { checkDesiredVersion() {
if [ "x$DESIRED_VERSION" == "x" ]; then if [ "x$DESIRED_VERSION" == "x" ]; then
# FIXME(bacongobbler): hard code the desired version for the time being.
# A better fix would be to filter for Helm 2 release pages.
TAG="v2.16.1"
# Get tag from release URL # Get tag from release URL
local latest_release_url="https://github.com/helm/helm/releases/latest" # local latest_release_url="https://github.com/helm/helm/releases/latest"
if type "curl" > /dev/null; then # if type "curl" > /dev/null; then
TAG=$(curl -Ls -o /dev/null -w %{url_effective} $latest_release_url | grep -oE "[^/]+$" ) # TAG=$(curl -Ls -o /dev/null -w %{url_effective} $latest_release_url | grep -oE "[^/]+$" )
elif type "wget" > /dev/null; then # elif type "wget" > /dev/null; then
TAG=$(wget $latest_release_url --server-response -O /dev/null 2>&1 | awk '/^ Location: /{DEST=$2} END{ print DEST}' | grep -oE "[^/]+$") # TAG=$(wget $latest_release_url --server-response -O /dev/null 2>&1 | awk '/^ Location: /{DEST=$2} END{ print DEST}' | grep -oE "[^/]+$")
fi # fi
else else
TAG=$DESIRED_VERSION TAG=$DESIRED_VERSION
fi fi
@ -213,9 +216,7 @@ while [[ $# -gt 0 ]]; do
'--version'|-v) '--version'|-v)
shift shift
if [[ $# -ne 0 ]]; then if [[ $# -ne 0 ]]; then
# FIXME(bacongobbler): hard code the desired version for the time being. export DESIRED_VERSION="${1}"
# A better fix would be to filter for Helm 2 release pages.
export DESIRED_VERSION="${1:="v2.16.1"}"
else else
echo -e "Please provide the desired version. e.g. --version v2.4.0 or -v latest" echo -e "Please provide the desired version. e.g. --version v2.4.0 or -v latest"
exit 0 exit 0

Loading…
Cancel
Save