mirror of https://github.com/helm/helm
Merge pull request #2690 from adamreese/fix/helm-home-plugins-again-again
fix(helm): fix flag parsing once and for allpull/2691/head
Adam Reese
7 years ago
committed by
GitHub
commit
3cf8f2c8b3
@ -0,0 +1,134 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2016 The Kubernetes Authors All rights reserved.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package environment
|
||||||
|
|
||||||
|
import (
|
||||||
|
"os"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
|
||||||
|
"k8s.io/helm/pkg/helm/helmpath"
|
||||||
|
|
||||||
|
"github.com/spf13/pflag"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestEnvSettings(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
|
||||||
|
// input
|
||||||
|
args []string
|
||||||
|
envars map[string]string
|
||||||
|
|
||||||
|
// expected values
|
||||||
|
home, host, ns, kcontext, plugins string
|
||||||
|
debug bool
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "defaults",
|
||||||
|
args: []string{},
|
||||||
|
home: DefaultHelmHome,
|
||||||
|
plugins: helmpath.Home(DefaultHelmHome).Plugins(),
|
||||||
|
ns: "kube-system",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "with flags set",
|
||||||
|
args: []string{"--home", "/foo", "--host=here", "--debug", "--tiller-namespace=myns"},
|
||||||
|
home: "/foo",
|
||||||
|
plugins: helmpath.Home("/foo").Plugins(),
|
||||||
|
host: "here",
|
||||||
|
ns: "myns",
|
||||||
|
debug: true,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "with envvars set",
|
||||||
|
args: []string{},
|
||||||
|
envars: map[string]string{"HELM_HOME": "/bar", "HELM_HOST": "there", "HELM_DEBUG": "1", "TILLER_NAMESPACE": "yourns"},
|
||||||
|
home: "/bar",
|
||||||
|
plugins: helmpath.Home("/bar").Plugins(),
|
||||||
|
host: "there",
|
||||||
|
ns: "yourns",
|
||||||
|
debug: true,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "with flags and envvars set",
|
||||||
|
args: []string{"--home", "/foo", "--host=here", "--debug", "--tiller-namespace=myns"},
|
||||||
|
envars: map[string]string{"HELM_HOME": "/bar", "HELM_HOST": "there", "HELM_DEBUG": "1", "TILLER_NAMESPACE": "yourns", "HELM_PLUGIN": "glade"},
|
||||||
|
home: "/foo",
|
||||||
|
plugins: "glade",
|
||||||
|
host: "here",
|
||||||
|
ns: "myns",
|
||||||
|
debug: true,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
cleanup := resetEnv()
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
for k, v := range tt.envars {
|
||||||
|
os.Setenv(k, v)
|
||||||
|
}
|
||||||
|
|
||||||
|
flags := pflag.NewFlagSet("testing", pflag.ContinueOnError)
|
||||||
|
|
||||||
|
settings := &EnvSettings{}
|
||||||
|
settings.AddFlags(flags)
|
||||||
|
flags.Parse(tt.args)
|
||||||
|
|
||||||
|
settings.Init(flags)
|
||||||
|
|
||||||
|
if settings.Home != helmpath.Home(tt.home) {
|
||||||
|
t.Errorf("expected home %q, got %q", tt.home, settings.Home)
|
||||||
|
}
|
||||||
|
if settings.PluginDirs() != tt.plugins {
|
||||||
|
t.Errorf("expected plugins %q, got %q", tt.plugins, settings.PluginDirs())
|
||||||
|
}
|
||||||
|
if settings.TillerHost != tt.host {
|
||||||
|
t.Errorf("expected host %q, got %q", tt.host, settings.TillerHost)
|
||||||
|
}
|
||||||
|
if settings.Debug != tt.debug {
|
||||||
|
t.Errorf("expected debug %t, got %t", tt.debug, settings.Debug)
|
||||||
|
}
|
||||||
|
if settings.TillerNamespace != tt.ns {
|
||||||
|
t.Errorf("expected tiller-namespace %q, got %q", tt.ns, settings.TillerNamespace)
|
||||||
|
}
|
||||||
|
if settings.KubeContext != tt.kcontext {
|
||||||
|
t.Errorf("expected kube-context %q, got %q", tt.kcontext, settings.KubeContext)
|
||||||
|
}
|
||||||
|
|
||||||
|
cleanup()
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func resetEnv() func() {
|
||||||
|
origEnv := os.Environ()
|
||||||
|
|
||||||
|
// ensure any local envvars do not hose us
|
||||||
|
for _, e := range envMap {
|
||||||
|
os.Unsetenv(e)
|
||||||
|
}
|
||||||
|
|
||||||
|
return func() {
|
||||||
|
for _, pair := range origEnv {
|
||||||
|
kv := strings.SplitN(pair, "=", 2)
|
||||||
|
os.Setenv(kv[0], kv[1])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in new issue