add deprication notice for test hooks

Signed-off-by: Michelle Noorali <michellemolu@gmail.com>

pkg/hooks/hooks.go

@@ -39,6 +39,7 @@ const (
 	PostUpgrade  = "post-upgrade"
 	PreRollback  = "pre-rollback"
 	PostRollback = "post-rollback"
+	//TODO: remove test hooks entirely when release helm v3.0.0-beta
 	ReleaseTestSuccess = "test-success"
 	ReleaseTestFailure = "test-failure"
 )

pkg/release/hook.go

@@ -30,6 +30,7 @@ const (
 	HookPostUpgrade  HookEvent = "post-upgrade"
 	HookPreRollback  HookEvent = "pre-rollback"
 	HookPostRollback HookEvent = "post-rollback"
+	//TODO: remove depricated test hooks entirely with helm v3.0.0-beta
 	HookReleaseTestSuccess HookEvent = "release-test-success"
 	HookReleaseTestFailure HookEvent = "release-test-failure"
 )

pkg/releaseutil/manifest_sorter.go

@@ -62,6 +62,9 @@ var events = map[string]release.HookEvent{
 	hooks.PostUpgrade:  release.HookPostUpgrade,
 	hooks.PreRollback:  release.HookPreRollback,
 	hooks.PostRollback: release.HookPostRollback,
+}
+
+var DepricatedHookEvents = map[string]release.HookEvent{
 	hooks.ReleaseTestSuccess: release.HookReleaseTestSuccess,
 	hooks.ReleaseTestFailure: release.HookReleaseTestFailure,
 }
@@ -194,11 +197,17 @@ func (file *manifestFile) sort(result *result) error {
 		}
 
 		isUnknownHook := false
+		isDepricatedHook := false
 		for _, hookType := range strings.Split(hookTypes, ",") {
 			hookType = strings.ToLower(strings.TrimSpace(hookType))
 			e, ok := events[hookType]
 			if !ok {
+				_, depricated := DepricatedHookEvents[hookType]
+				if depricated {
+					isDepricatedHook = true
+				} else {
 					isUnknownHook = true
+				}
 				break
 			}
 			h.Events = append(h.Events, e)
@@ -209,6 +218,11 @@ func (file *manifestFile) sort(result *result) error {
 			continue
 		}
 
+		if isDepricatedHook {
+			log.Printf("info: skipping depricated hook: %q", hookTypes)
+			continue
+		}
+
 		result.hooks = append(result.hooks, h)
 
 		operateAnnotationValues(entry, hooks.HookDeleteAnno, func(value string) {

pkg/releaseutil/manifest_sorter_test.go

@@ -187,12 +187,13 @@ metadata:
 		t.Errorf("Expected 3 test manifests, got %d", len(ts))
 	}
 
-	if len(hs) != 4 {
+	if len(hs) != 3 {
-		t.Errorf("Expected 4 hooks, got %d", len(hs))
+		t.Errorf("Expected 3 hook manifests, got %d", len(hs))
 	}
 
 	for _, out := range hs {
 		found := false
+
 		for _, expect := range data {
 			if out.Path == expect.path {
 				found = true