chore: store err separately for clarity

Signed-off-by: Jeaeun Kim <me@kyoku.dev>
(cherry picked from commit ea847fef95)
release-4.2
Jeaeun Kim 1 year ago committed by Scott Rigby
parent 211ffae93d
commit 3507ea5bfd
No known key found for this signature in database
GPG Key ID: C7C6FBB5B91C1155

@ -113,6 +113,7 @@ func newTemplateCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
} }
return err return err
} }
savedErr := err
// We ignore a potential error here because, when the --debug flag was specified, // We ignore a potential error here because, when the --debug flag was specified,
// we always want to print the YAML, even if it is not valid. The error is still returned afterwards. // we always want to print the YAML, even if it is not valid. The error is still returned afterwards.
@ -187,9 +188,9 @@ func newTemplateCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
missing = false missing = false
} }
if missing { if missing {
if err != nil && settings.Debug { if savedErr != nil && settings.Debug {
// assume the manifest itself is too malformed to be rendered // assume the manifest itself is too malformed to be rendered
return err return savedErr
} else { } else {
return fmt.Errorf("could not find template %s in chart", f) return fmt.Errorf("could not find template %s in chart", f)
} }
@ -203,7 +204,7 @@ func newTemplateCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
} }
} }
return err return savedErr
}, },
} }

Loading…
Cancel
Save