Merge pull request #3465 from oilbeater/fix/defer-in-loop

defer in loop may cause resource leak
pull/4207/head^2
Matthew Fisher 8 years ago committed by GitHub
commit 2ff873a0d7

@ -193,10 +193,11 @@ func (g *TarGzExtractor) Extract(buffer *bytes.Buffer, targetDir string) error {
if err != nil { if err != nil {
return err return err
} }
defer outFile.Close()
if _, err := io.Copy(outFile, tarReader); err != nil { if _, err := io.Copy(outFile, tarReader); err != nil {
outFile.Close()
return err return err
} }
outFile.Close()
default: default:
return fmt.Errorf("unknown type: %b in %s", header.Typeflag, header.Name) return fmt.Errorf("unknown type: %b in %s", header.Typeflag, header.Name)
} }

Loading…
Cancel
Save