chore: Spelling (#9410)

* spelling: annotate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: asserts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: behavior

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: binary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: contain

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: copied

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: dependency

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: depending

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deprecated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: doesn't

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: donot

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: inputting

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: iteration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: jabberwocky

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: length

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: mismatch

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nonexistent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: outputs

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: panicking

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: plugins

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parsing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: porthos

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: regular

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resource

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repositories

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: something

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: strict

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: string

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unknown

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
pull/9494/head
Josh Soref 4 years ago committed by GitHub
parent 25ec7a60c7
commit 2bf8fdf45d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -259,7 +259,7 @@ Like any good open source project, we use Pull Requests (PRs) to track code chan
maintainers before it can be merged. Those with `size/XS` are per the judgement of the maintainers before it can be merged. Those with `size/XS` are per the judgement of the
maintainers. For more detail see the [Size Labels](#size-labels) section. maintainers. For more detail see the [Size Labels](#size-labels) section.
4. Reviewing/Discussion 4. Reviewing/Discussion
- All reviews will be completed using Github review tool. - All reviews will be completed using GitHub review tool.
- A "Comment" review should be used when there are questions about the code that should be - A "Comment" review should be used when there are questions about the code that should be
answered, but that don't involve code changes. This type of review does not count as approval. answered, but that don't involve code changes. This type of review does not count as approval.
- A "Changes Requested" review indicates that changes to the code need to be made before they - A "Changes Requested" review indicates that changes to the code need to be made before they

@ -25,7 +25,7 @@ TESTFLAGS :=
LDFLAGS := -w -s LDFLAGS := -w -s
GOFLAGS := GOFLAGS :=
# Rebuild the buinary if any of these files change # Rebuild the binary if any of these files change
SRC := $(shell find . -type f -name '*.go' -print) go.mod go.sum SRC := $(shell find . -type f -name '*.go' -print) go.mod go.sum
# Required for globs to work correctly # Required for globs to work correctly

@ -54,7 +54,7 @@ Get started with the [Quick Start guide](https://helm.sh/docs/intro/quickstart/)
## Roadmap ## Roadmap
The [Helm roadmap uses Github milestones](https://github.com/helm/helm/milestones) to track the progress of the project. The [Helm roadmap uses GitHub milestones](https://github.com/helm/helm/milestones) to track the progress of the project.
## Community, discussion, contribution, and support ## Community, discussion, contribution, and support

@ -150,7 +150,7 @@ func TestDependencyUpdateCmd(t *testing.T) {
} }
} }
func TestDependencyUpdateCmd_DontDeleteOldChartsOnError(t *testing.T) { func TestDependencyUpdateCmd_DoNotDeleteOldChartsOnError(t *testing.T) {
defer resetEnv()() defer resetEnv()()
defer ensure.HelmHome(t)() defer ensure.HelmHome(t)()

@ -98,7 +98,7 @@ func newRootCmd(actionConfig *action.Configuration, out io.Writer, args []string
// Setup shell completion for the namespace flag // Setup shell completion for the namespace flag
err := cmd.RegisterFlagCompletionFunc("namespace", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { err := cmd.RegisterFlagCompletionFunc("namespace", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
if client, err := actionConfig.KubernetesClientSet(); err == nil { if client, err := actionConfig.KubernetesClientSet(); err == nil {
// Choose a long enough timeout that the user notices somethings is not working // Choose a long enough timeout that the user notices something is not working
// but short enough that the user is not made to wait very long // but short enough that the user is not made to wait very long
to := int64(3) to := int64(3)
cobra.CompDebugln(fmt.Sprintf("About to call kube client for namespaces with timeout of: %d", to), settings.Debug) cobra.CompDebugln(fmt.Sprintf("About to call kube client for namespaces with timeout of: %d", to), settings.Debug)

@ -27,7 +27,7 @@ import (
func checkPerms() { func checkPerms() {
// This function MUST NOT FAIL, as it is just a check for a common permissions problem. // This function MUST NOT FAIL, as it is just a check for a common permissions problem.
// If for some reason the function hits a stopping condition, it may panic. But only if // If for some reason the function hits a stopping condition, it may panic. But only if
// we can be sure that it is panicing because Helm cannot proceed. // we can be sure that it is panicking because Helm cannot proceed.
kc := settings.KubeConfig kc := settings.KubeConfig
if kc == "" { if kc == "" {

@ -56,5 +56,5 @@ func TestSearchHubOutputCompletion(t *testing.T) {
} }
func TestSearchHubFileCompletion(t *testing.T) { func TestSearchHubFileCompletion(t *testing.T) {
checkFileCompletion(t, "search hub", true) // File completion may be useful when inputing a keyword checkFileCompletion(t, "search hub", true) // File completion may be useful when inputting a keyword
} }

@ -89,5 +89,5 @@ func TestSearchRepoOutputCompletion(t *testing.T) {
} }
func TestSearchRepoFileCompletion(t *testing.T) { func TestSearchRepoFileCompletion(t *testing.T) {
checkFileCompletion(t, "search repo", true) // File completion may be useful when inputing a keyword checkFileCompletion(t, "search repo", true) // File completion may be useful when inputting a keyword
} }

@ -188,7 +188,7 @@ func isTestHook(h *release.Hook) bool {
} }
// The following functions (writeToFile, createOrOpenFile, and ensureDirectoryForFile) // The following functions (writeToFile, createOrOpenFile, and ensureDirectoryForFile)
// are coppied from the actions package. This is part of a change to correct a // are copied from the actions package. This is part of a change to correct a
// bug introduced by #8156. As part of the todo to refactor renderResources // bug introduced by #8156. As part of the todo to refactor renderResources
// this duplicate code should be removed. It is added here so that the API // this duplicate code should be removed. It is added here so that the API
// surface area is as minimally impacted as possible in fixing the issue. // surface area is as minimally impacted as possible in fixing the issue.

@ -4,7 +4,7 @@ kind: Ingress
{{ template "common.metadata" . }} {{ template "common.metadata" . }}
{{- if .Values.ingress.annotations }} {{- if .Values.ingress.annotations }}
annotations: annotations:
{{ include "common.annote" .Values.ingress.annotations | indent 4 }} {{ include "common.annotate" .Values.ingress.annotations | indent 4 }}
{{- end }} {{- end }}
spec: spec:
rules: rules:

@ -11,7 +11,7 @@ Any valid hook may be passed in. Separate multiple hooks with a ",".
"helm.sh/hook": {{printf "%s" . | quote}} "helm.sh/hook": {{printf "%s" . | quote}}
{{- end -}} {{- end -}}
{{- define "common.annote" -}} {{- define "common.annotate" -}}
{{- range $k, $v := . }} {{- range $k, $v := . }}
{{ $k | quote }}: {{ $v | quote }} {{ $k | quote }}: {{ $v | quote }}
{{- end -}} {{- end -}}

@ -4,7 +4,7 @@ kind: Ingress
{{ template "common.metadata" . }} {{ template "common.metadata" . }}
{{- if .Values.ingress.annotations }} {{- if .Values.ingress.annotations }}
annotations: annotations:
{{ include "common.annote" .Values.ingress.annotations | indent 4 }} {{ include "common.annotate" .Values.ingress.annotations | indent 4 }}
{{- end }} {{- end }}
spec: spec:
rules: rules:

@ -11,7 +11,7 @@ Any valid hook may be passed in. Separate multiple hooks with a ",".
"helm.sh/hook": {{printf "%s" . | quote}} "helm.sh/hook": {{printf "%s" . | quote}}
{{- end -}} {{- end -}}
{{- define "common.annote" -}} {{- define "common.annotate" -}}
{{- range $k, $v := . }} {{- range $k, $v := . }}
{{ $k | quote }}: {{ $v | quote }} {{ $k | quote }}: {{ $v | quote }}
{{- end -}} {{- end -}}

@ -96,7 +96,7 @@ func TestResolve(t *testing.T) {
{ {
name: "repo from invalid local path", name: "repo from invalid local path",
req: []*chart.Dependency{ req: []*chart.Dependency{
{Name: "notexist", Repository: "file://testdata/notexist", Version: "0.1.0"}, {Name: "nonexistent", Repository: "file://testdata/nonexistent", Version: "0.1.0"},
}, },
err: true, err: true,
}, },
@ -255,7 +255,7 @@ func TestGetLocalPath(t *testing.T) {
}, },
{ {
name: "invalid local path", name: "invalid local path",
repo: "file://testdata/notexist", repo: "file://testdata/nonexistent",
chartpath: "testdata/chartpath", chartpath: "testdata/chartpath",
err: true, err: true,
}, },

@ -58,7 +58,7 @@ func AssertGoldenString(t TestingT, actual, filename string) {
} }
} }
// AssertGoldenFile assers that the content of the actual file matches the contents of the expected file // AssertGoldenFile asserts that the content of the actual file matches the contents of the expected file
func AssertGoldenFile(t TestingT, actualFileName string, expectedFilename string) { func AssertGoldenFile(t TestingT, actualFileName string, expectedFilename string) {
t.Helper() t.Helper()

@ -46,7 +46,7 @@ func TestClientConfig(t *testing.T) {
t.Fatalf("expecting 1 client certificates, got %d", got) t.Fatalf("expecting 1 client certificates, got %d", got)
} }
if cfg.InsecureSkipVerify { if cfg.InsecureSkipVerify {
t.Fatalf("insecure skip verify mistmatch, expecting false") t.Fatalf("insecure skip verify mismatch, expecting false")
} }
if cfg.RootCAs == nil { if cfg.RootCAs == nil {
t.Fatalf("mismatch tls RootCAs, expecting non-nil") t.Fatalf("mismatch tls RootCAs, expecting non-nil")
@ -75,7 +75,7 @@ func TestNewClientTLS(t *testing.T) {
t.Fatalf("expecting 1 client certificates, got %d", got) t.Fatalf("expecting 1 client certificates, got %d", got)
} }
if cfg.InsecureSkipVerify { if cfg.InsecureSkipVerify {
t.Fatalf("insecure skip verify mistmatch, expecting false") t.Fatalf("insecure skip verify mismatch, expecting false")
} }
if cfg.RootCAs == nil { if cfg.RootCAs == nil {
t.Fatalf("mismatch tls RootCAs, expecting non-nil") t.Fatalf("mismatch tls RootCAs, expecting non-nil")
@ -90,7 +90,7 @@ func TestNewClientTLS(t *testing.T) {
t.Fatalf("expecting 0 client certificates, got %d", got) t.Fatalf("expecting 0 client certificates, got %d", got)
} }
if cfg.InsecureSkipVerify { if cfg.InsecureSkipVerify {
t.Fatalf("insecure skip verify mistmatch, expecting false") t.Fatalf("insecure skip verify mismatch, expecting false")
} }
if cfg.RootCAs == nil { if cfg.RootCAs == nil {
t.Fatalf("mismatch tls RootCAs, expecting non-nil") t.Fatalf("mismatch tls RootCAs, expecting non-nil")
@ -105,7 +105,7 @@ func TestNewClientTLS(t *testing.T) {
t.Fatalf("expecting 1 client certificates, got %d", got) t.Fatalf("expecting 1 client certificates, got %d", got)
} }
if cfg.InsecureSkipVerify { if cfg.InsecureSkipVerify {
t.Fatalf("insecure skip verify mistmatch, expecting false") t.Fatalf("insecure skip verify mismatch, expecting false")
} }
if cfg.RootCAs != nil { if cfg.RootCAs != nil {
t.Fatalf("mismatch tls RootCAs, expecting nil") t.Fatalf("mismatch tls RootCAs, expecting nil")

@ -62,14 +62,14 @@ func (d *Dependency) List(chartpath string, out io.Writer) error {
return nil return nil
} }
// dependecyStatus returns a string describing the status of a dependency viz a viz the parent chart. // dependencyStatus returns a string describing the status of a dependency viz a viz the parent chart.
func (d *Dependency) dependencyStatus(chartpath string, dep *chart.Dependency, parent *chart.Chart) string { func (d *Dependency) dependencyStatus(chartpath string, dep *chart.Dependency, parent *chart.Chart) string {
filename := fmt.Sprintf("%s-%s.tgz", dep.Name, "*") filename := fmt.Sprintf("%s-%s.tgz", dep.Name, "*")
// If a chart is unpacked, this will check the unpacked chart's `charts/` directory for tarballs. // If a chart is unpacked, this will check the unpacked chart's `charts/` directory for tarballs.
// Technically, this is COMPLETELY unnecessary, and should be removed in Helm 4. It is here // Technically, this is COMPLETELY unnecessary, and should be removed in Helm 4. It is here
// to preserved backward compatibility. In Helm 2/3, there is a "difference" between // to preserved backward compatibility. In Helm 2/3, there is a "difference" between
// the tgz version (which outputs "ok" if it unpacks) and the loaded version (which outouts // the tgz version (which outputs "ok" if it unpacks) and the loaded version (which outputs
// "unpacked"). Early in Helm 2's history, this would have made a difference. But it no // "unpacked"). Early in Helm 2's history, this would have made a difference. But it no
// longer does. However, since this code shipped with Helm 3, the output must remain stable // longer does. However, since this code shipped with Helm 3, the output must remain stable
// until Helm 4. // until Helm 4.

@ -94,7 +94,7 @@ type Upgrade struct {
// PostRender is an optional post-renderer // PostRender is an optional post-renderer
// //
// If this is non-nil, then after templates are rendered, they will be sent to the // If this is non-nil, then after templates are rendered, they will be sent to the
// post renderer before sending to the Kuberntes API server. // post renderer before sending to the Kubernetes API server.
PostRenderer postrender.PostRenderer PostRenderer postrender.PostRenderer
// DisableOpenAPIValidation controls whether OpenAPI validation is enforced. // DisableOpenAPIValidation controls whether OpenAPI validation is enforced.
DisableOpenAPIValidation bool DisableOpenAPIValidation bool

@ -190,13 +190,13 @@ func TestProcessDependencyImportValues(t *testing.T) {
e["overridden-chartA.SCAbool"] = "true" e["overridden-chartA.SCAbool"] = "true"
e["overridden-chartA.SCAfloat"] = "41.3" e["overridden-chartA.SCAfloat"] = "41.3"
e["overridden-chartA.SCAint"] = "808" e["overridden-chartA.SCAint"] = "808"
e["overridden-chartA.SCAstring"] = "jaberwocky" e["overridden-chartA.SCAstring"] = "jabberwocky"
e["overridden-chartA.SPextra4"] = "true" e["overridden-chartA.SPextra4"] = "true"
e["overridden-chartA-B.SCAbool"] = "true" e["overridden-chartA-B.SCAbool"] = "true"
e["overridden-chartA-B.SCAfloat"] = "41.3" e["overridden-chartA-B.SCAfloat"] = "41.3"
e["overridden-chartA-B.SCAint"] = "808" e["overridden-chartA-B.SCAint"] = "808"
e["overridden-chartA-B.SCAstring"] = "jaberwocky" e["overridden-chartA-B.SCAstring"] = "jabberwocky"
e["overridden-chartA-B.SCBbool"] = "false" e["overridden-chartA-B.SCBbool"] = "false"
e["overridden-chartA-B.SCBfloat"] = "1.99" e["overridden-chartA-B.SCBfloat"] = "1.99"
e["overridden-chartA-B.SCBint"] = "77" e["overridden-chartA-B.SCBint"] = "77"

@ -102,7 +102,7 @@ func TestSave(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
if c2.Lock == nil { if c2.Lock == nil {
t.Fatal("Expected v2 chart archive to containe a Chart.lock file") t.Fatal("Expected v2 chart archive to contain a Chart.lock file")
} }
if c2.Lock.Digest != c.Lock.Digest { if c2.Lock.Digest != c.Lock.Digest {
t.Fatal("Chart.lock data did not match") t.Fatal("Chart.lock data did not match")

@ -18,7 +18,7 @@ overridden-chartA:
SCAbool: true SCAbool: true
SCAfloat: 41.3 SCAfloat: 41.3
SCAint: 808 SCAint: 808
SCAstring: "jaberwocky" SCAstring: "jabberwocky"
SPextra4: true SPextra4: true
imported-chartA-B: imported-chartA-B:
@ -28,7 +28,7 @@ overridden-chartA-B:
SCAbool: true SCAbool: true
SCAfloat: 41.3 SCAfloat: 41.3
SCAint: 808 SCAint: 808
SCAstring: "jaberwocky" SCAstring: "jabberwocky"
SCBbool: false SCBbool: false
SCBfloat: 1.99 SCBfloat: 1.99
SCBint: 77 SCBint: 77

@ -61,7 +61,7 @@ const (
// ValidateReleaseName performs checks for an entry for a Helm release name // ValidateReleaseName performs checks for an entry for a Helm release name
// //
// For Helm to allow a name, it must be below a certain character count (53) and also match // For Helm to allow a name, it must be below a certain character count (53) and also match
// a reguar expression. // a regular expression.
// //
// According to the Kubernetes help text, the regular expression it uses is: // According to the Kubernetes help text, the regular expression it uses is:
// //

@ -176,7 +176,7 @@ func (m *Manager) Update() error {
// TODO(mattfarina): Repositories should be explicitly added by end users // TODO(mattfarina): Repositories should be explicitly added by end users
// rather than automattic. In Helm v4 require users to add repositories. They // rather than automattic. In Helm v4 require users to add repositories. They
// should have to add them in order to make sure they are aware of the // should have to add them in order to make sure they are aware of the
// respoitories and opt-in to any locations, for security. // repositories and opt-in to any locations, for security.
repoNames, err = m.ensureMissingRepos(repoNames, req) repoNames, err = m.ensureMissingRepos(repoNames, req)
if err != nil { if err != nil {
return err return err

@ -160,7 +160,7 @@ func TestRenderRefsOrdering(t *testing.T) {
for name, data := range expect { for name, data := range expect {
if out[name] != data { if out[name] != data {
t.Fatalf("Expected %q, got %q (iteraction %d)", data, out[name], i+1) t.Fatalf("Expected %q, got %q (iteration %d)", data, out[name], i+1)
} }
} }
} }

@ -80,7 +80,7 @@ func NewLookupFunction(config *rest.Config) lookupFunc {
// getDynamicClientOnUnstructured returns a dynamic client on an Unstructured type. This client can be further namespaced. // getDynamicClientOnUnstructured returns a dynamic client on an Unstructured type. This client can be further namespaced.
func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config) (dynamic.NamespaceableResourceInterface, bool, error) { func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config) (dynamic.NamespaceableResourceInterface, bool, error) {
gvk := schema.FromAPIVersionAndKind(apiversion, kind) gvk := schema.FromAPIVersionAndKind(apiversion, kind)
apiRes, err := getAPIReourceForGVK(gvk, config) apiRes, err := getAPIResourceForGVK(gvk, config)
if err != nil { if err != nil {
log.Printf("[ERROR] unable to get apiresource from unstructured: %s , error %s", gvk.String(), err) log.Printf("[ERROR] unable to get apiresource from unstructured: %s , error %s", gvk.String(), err)
return nil, false, errors.Wrapf(err, "unable to get apiresource from unstructured: %s", gvk.String()) return nil, false, errors.Wrapf(err, "unable to get apiresource from unstructured: %s", gvk.String())
@ -99,7 +99,7 @@ func getDynamicClientOnKind(apiversion string, kind string, config *rest.Config)
return res, apiRes.Namespaced, nil return res, apiRes.Namespaced, nil
} }
func getAPIReourceForGVK(gvk schema.GroupVersionKind, config *rest.Config) (metav1.APIResource, error) { func getAPIResourceForGVK(gvk schema.GroupVersionKind, config *rest.Config) (metav1.APIResource, error) {
res := metav1.APIResource{} res := metav1.APIResource{}
discoveryClient, err := discovery.NewDiscoveryClientForConfig(config) discoveryClient, err := discovery.NewDiscoveryClientForConfig(config)
if err != nil { if err != nil {

@ -233,7 +233,7 @@ func TestDownloadInsecureSkipTLSVerify(t *testing.T) {
u, _ := url.ParseRequestURI(ts.URL) u, _ := url.ParseRequestURI(ts.URL)
// Ensure the default behaviour did not change // Ensure the default behavior did not change
g, err := NewHTTPGetter( g, err := NewHTTPGetter(
WithURL(u.String()), WithURL(u.String()),
) )

@ -152,7 +152,7 @@ func Templates(linter *support.Linter, values map[string]interface{}, namespace
// validateTopIndentLevel checks that the content does not start with an indent level > 0. // validateTopIndentLevel checks that the content does not start with an indent level > 0.
// //
// This error can occur when a template accidentally inserts space. It can cause // This error can occur when a template accidentally inserts space. It can cause
// unpredictable errors dependening on whether the text is normalized before being passed // unpredictable errors depending on whether the text is normalized before being passed
// into the YAML parser. So we trap it here. // into the YAML parser. So we trap it here.
// //
// See https://github.com/helm/helm/issues/8467 // See https://github.com/helm/helm/issues/8467

@ -208,7 +208,7 @@ data:
myval2: {{default "val" .Values.mymap.key2 }} myval2: {{default "val" .Values.mymap.key2 }}
` `
// TestSTrictTemplatePrasingMapError is a regression test. // TestStrictTemplateParsingMapError is a regression test.
// //
// The template engine should not produce an error when a map in values.yaml does // The template engine should not produce an error when a map in values.yaml does
// not contain all possible keys. // not contain all possible keys.

@ -289,7 +289,7 @@ func TestFindPlugins(t *testing.T) {
expected: 0, expected: 0,
}, },
{ {
name: "plugdirs doens't have plugin", name: "plugdirs doesn't have plugin",
plugdirs: ".", plugdirs: ".",
expected: 0, expected: 0,
}, },

@ -72,7 +72,7 @@ func (p *execRender) Run(renderedManifests *bytes.Buffer) (*bytes.Buffer, error)
func getFullPath(binaryPath string) (string, error) { func getFullPath(binaryPath string) (string, error) {
// NOTE(thomastaylor312): I am leaving this code commented out here. During // NOTE(thomastaylor312): I am leaving this code commented out here. During
// the implementation of post-render, it was brought up that if we are // the implementation of post-render, it was brought up that if we are
// relying on plguins, we should actually use the plugin system so it can // relying on plugins, we should actually use the plugin system so it can
// properly handle multiple OSs. This will be a feature add in the future, // properly handle multiple OSs. This will be a feature add in the future,
// so I left this code for reference. It can be deleted or reused once the // so I left this code for reference. It can be deleted or reused once the
// feature is implemented // feature is implemented
@ -85,7 +85,7 @@ func getFullPath(binaryPath string) (string, error) {
// if v, ok := os.LookupEnv("HELM_PLUGINS"); ok { // if v, ok := os.LookupEnv("HELM_PLUGINS"); ok {
// pluginDir = v // pluginDir = v
// } // }
// // The plugins variable can actually contain multple paths, so loop through those // // The plugins variable can actually contain multiple paths, so loop through those
// for _, p := range filepath.SplitList(pluginDir) { // for _, p := range filepath.SplitList(pluginDir) {
// _, err := os.Stat(filepath.Join(p, binaryPath)) // _, err := os.Stat(filepath.Join(p, binaryPath))
// if err != nil && !os.IsNotExist(err) { // if err != nil && !os.IsNotExist(err) {

@ -102,5 +102,5 @@ const (
HookPhaseFailed HookPhase = "Failed" HookPhaseFailed HookPhase = "Failed"
) )
// Strng converts a hook phase to a printable string // String converts a hook phase to a printable string
func (x HookPhase) String() string { return string(x) } func (x HookPhase) String() string { return string(x) }

@ -267,7 +267,7 @@ type ChartVersion struct {
// YAML parser enabled, this field must be present. // YAML parser enabled, this field must be present.
TillerVersionDeprecated string `json:"tillerVersion,omitempty"` TillerVersionDeprecated string `json:"tillerVersion,omitempty"`
// URLDeprecated is deprectaed in Helm 3, superseded by URLs. It is ignored. However, // URLDeprecated is deprecated in Helm 3, superseded by URLs. It is ignored. However,
// with a strict YAML parser enabled, this must be present on the struct. // with a strict YAML parser enabled, this must be present on the struct.
URLDeprecated string `json:"url,omitempty"` URLDeprecated string `json:"url,omitempty"`
} }

@ -288,7 +288,7 @@ func (s *SQL) Query(labels map[string]string) ([]*rspb.Release, error) {
sb = sb.Where(sq.Eq{key: labels[key]}) sb = sb.Where(sq.Eq{key: labels[key]})
} else { } else {
s.Log("unknown label %s", key) s.Log("unknown label %s", key)
return nil, fmt.Errorf("unknow label %s", key) return nil, fmt.Errorf("unknown label %s", key)
} }
} }

@ -156,7 +156,7 @@ func (s *Storage) History(name string) ([]*rspb.Release, error) {
return s.Driver.Query(map[string]string{"name": name, "owner": "helm"}) return s.Driver.Query(map[string]string{"name": name, "owner": "helm"})
} }
// removeLeastRecent removes items from history until the lengh number of releases // removeLeastRecent removes items from history until the length number of releases
// does not exceed max. // does not exceed max.
// //
// We allow max to be set explicitly so that calling functions can "make space" // We allow max to be set explicitly so that calling functions can "make space"

@ -361,7 +361,7 @@ func TestStorageRemoveLeastRecent(t *testing.T) {
} }
} }
func TestStorageDontDeleteDeployed(t *testing.T) { func TestStorageDoNotDeleteDeployed(t *testing.T) {
storage := Init(driver.NewMemory()) storage := Init(driver.NewMemory())
storage.Log = t.Logf storage.Log = t.Logf
storage.MaxHistory = 3 storage.MaxHistory = 3

@ -17,7 +17,7 @@
status: deployed status: deployed
chart: chart:
metadata: metadata:
name: prothos-chart name: porthos-chart
version: 0.2.0 version: 0.2.0
appversion: 0.2.2 appversion: 0.2.2
- name: aramis - name: aramis

Loading…
Cancel
Save