Signed-off-by: Herbert Mühlburger <mail@muehlburger.at>
pull/5818/head
Herbert Mühlburger 6 years ago
parent 2a3b7b5395
commit 2130d8e1ce

@ -118,8 +118,8 @@ func (cache *filesystemCache) ChartToLayers(ch *chart.Chart) ([]ocispec.Descript
// such as "no chart name specified (Chart.yaml)"
ch.Metadata = &chart.Metadata{
APIVersion: chart.APIVersionV1,
Name: "-",
Version: "0.1.0",
Name: name,
Version: version,
}
destDir := mkdir(filepath.Join(cache.rootDir, "blobs", ".build"))
tmpFile, err := chartutil.Save(ch, destDir)

@ -128,12 +128,12 @@ func (suite *RegistryClientTestSuite) Test_1_SaveChart() {
// empty chart
err = suite.RegistryClient.SaveChart(&chart.Chart{}, ref)
suite.NotNil(err)
suite.NotNil(err, "chart.metadata is required")
// valid chart
ch := &chart.Chart{}
ch.Metadata = &chart.Metadata{
APIVersion: "v1",
APIVersion: chart.APIVersionV1,
Name: "testchart",
Version: "1.2.3",
}
@ -141,6 +141,29 @@ func (suite *RegistryClientTestSuite) Test_1_SaveChart() {
suite.Nil(err)
}
func (suite *RegistryClientTestSuite) TestSaveChartLatest() {
ref, err := ParseReference(fmt.Sprintf("%s/testrepo/testchart", suite.DockerRegistryHost))
suite.Nil(err)
ch := &chart.Chart{}
ch.Metadata = &chart.Metadata{
APIVersion: chart.APIVersionV1,
Name: "testchart",
Version: "latest",
}
err = suite.RegistryClient.SaveChart(ch, ref)
suite.Nil(err)
suite.Equal("testchart", ch.Metadata.Name)
suite.Equal("latest", ch.Metadata.Version)
ref, err = ParseReference(fmt.Sprintf("%s/testrepo/testchart:latest", suite.DockerRegistryHost))
suite.Nil(err)
err = suite.RegistryClient.SaveChart(ch, ref)
suite.Nil(err)
suite.Equal("testchart", ch.Metadata.Name)
suite.Equal("latest", ch.Metadata.Version)
}
func (suite *RegistryClientTestSuite) Test_2_LoadChart() {
// non-existent ref

@ -18,6 +18,7 @@ package registry // import "helm.sh/helm/pkg/registry"
import (
"errors"
"fmt"
"regexp"
"strings"
@ -39,6 +40,11 @@ type (
}
)
// String returns the normalized string for the ref.
func (r Reference) String() string {
return fmt.Sprintf("%v:%v", r.Repo, r.Tag)
}
// ParseReference converts a string to a Reference
func ParseReference(s string) (*Reference, error) {
spec, err := reference.Parse(s)

Loading…
Cancel
Save